Skip to content

Commit 9cf0a27

Browse files
author
hwyu@adobe.com
committed
MC-36034: Session size configuration
- Fixed static test failures
1 parent c2a591c commit 9cf0a27

File tree

6 files changed

+9
-5
lines changed

6 files changed

+9
-5
lines changed

app/code/Magento/Security/Model/Config/Backend/Session/SessionSize.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@
1919
class SessionSize extends Value
2020
{
2121
/**
22+
* Handles the before save event
23+
*
2224
* @return $this
2325
*/
2426
public function beforeSave()

app/code/Magento/Security/etc/adminhtml/system.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@
5858
<comment>Limit the maximum session size in bytes. Use 0 to disable.</comment>
5959
</field>
6060
</group>
61-
</section>s
61+
</section>
6262
<section id="customer">
6363
<group id="password">
6464
<field id="password_reset_protection_type" translate="label" type="select" sortOrder="5" showInDefault="1" showInWebsite="1" showInStore="1" canRestore="1">

app/code/Magento/Security/view/adminhtml/templates/system/config/session_size_admin/modal_content_body.phtml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@
88
<div>
99
<p>
1010
<strong><?= $block->escapeHtml(__('Warning')) ?></strong>
11-
<?= $block->escapeHtml(__(': You are about to set max session size in admin to be lower than recommended default session size. Low max session size in admin could break admin functionalities such as admin panel login. Are you sure you want to make this change?')) ?>
11+
<?= $block->escapeHtml(__(': You are about to set max session size in admin to be lower than recommended ' .
12+
'default session size. Low max session size in admin could break admin functionalities such as admin ' .
13+
'panel login. Are you sure you want to make this change?')) ?>
1214
</p>
1315
</div>

app/code/Magento/Security/view/adminhtml/templates/system/config/session_size_storefront/modal_content_body.phtml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@
88
<div>
99
<p>
1010
<strong><?= $block->escapeHtml(__('Warning')) ?></strong>
11-
<?= $block->escapeHtml(__(': You are about to set max session size in storefront to be lower than recommended default session size. Low max session size in storefront could break storefront functionalities such as customer login. Are you sure you want to make this change?')) ?>
11+
<?= $block->escapeHtml(__(': You are about to set max session size in storefront to be lower than ' .
12+
' recommended default session size. Low max session size in storefront could break storefront ' .
13+
'functionalities such as customer login. Are you sure you want to make this change?')) ?>
1214
</p>
1315
</div>

lib/internal/Magento/Framework/Session/SessionMaxSizeConfig.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616

1717
/**
1818
* Magento session max size configuration
19-
*
2019
*/
2120
class SessionMaxSizeConfig
2221
{

lib/internal/Magento/Framework/Session/Test/Unit/SaveHandlerTest.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,6 @@ protected function setUp(): void
9393
'sessionMaxSizeConfig' => $this->sessionMaxSizeConfigMock,
9494
]
9595
);
96-
9796
}
9897

9998
public function testWriteSessionMaxSizeValid()

0 commit comments

Comments
 (0)