Skip to content

Commit 9bd2fac

Browse files
author
Joan He
committed
Merge remote-tracking branch 'origin/MC-5596' into BugFixPR
2 parents 1049dd6 + 8734aef commit 9bd2fac

File tree

3 files changed

+10
-6
lines changed

3 files changed

+10
-6
lines changed

app/code/Magento/Sales/Model/Order/Creditmemo.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,10 @@
1919
* Order creditmemo model
2020
*
2121
* @api
22-
* @method \Magento\Sales\Model\Order\Invoice setSendEmail(bool $value)
23-
* @method \Magento\Sales\Model\Order\Invoice setCustomerNote(string $value)
22+
* @method \Magento\Sales\Model\Order\Creditmemo setSendEmail(bool $value)
23+
* @method \Magento\Sales\Model\Order\Creditmemo setCustomerNote(string $value)
2424
* @method string getCustomerNote()
25-
* @method \Magento\Sales\Model\Order\Invoice setCustomerNoteNotify(bool $value)
25+
* @method \Magento\Sales\Model\Order\Creditmemo setCustomerNoteNotify(bool $value)
2626
* @method bool getCustomerNoteNotify()
2727
* @SuppressWarnings(PHPMD.ExcessivePublicCount)
2828
* @SuppressWarnings(PHPMD.ExcessiveClassComplexity)

app/code/Magento/Sales/Model/Order/CreditmemoDocumentFactory.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,11 +99,14 @@ private function attachComment(
9999
->setCreditmemo($creditmemo)
100100
->setIsCustomerNotified($appendComment);
101101
$creditmemo->setComments([$comment]);
102+
$creditmemo->setCustomerNote($comment->getComment());
103+
$creditmemo->setCustomerNoteNotify($appendComment);
102104
return $creditmemo;
103105
}
104106

105107
/**
106108
* Create new Creditmemo
109+
*
107110
* @param \Magento\Sales\Api\Data\OrderInterface $order
108111
* @param \Magento\Sales\Api\Data\CreditmemoItemCreationInterface[] $items
109112
* @param \Magento\Sales\Api\Data\CreditmemoCommentCreationInterface|null $comment
@@ -128,6 +131,8 @@ public function createFromOrder(
128131
}
129132

130133
/**
134+
* Create credit memo from invoice
135+
*
131136
* @param \Magento\Sales\Api\Data\InvoiceInterface $invoice
132137
* @param \Magento\Sales\Api\Data\CreditmemoItemCreationInterface[] $items
133138
* @param \Magento\Sales\Api\Data\CreditmemoCommentCreationInterface|null $comment

app/code/Magento/Sales/Test/Unit/Model/Order/CreditmemoDocumentFactoryTest.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
use Magento\Sales\Api\Data\CreditmemoCommentInterface;
1313
use Magento\Sales\Model\Order;
1414
use Magento\Sales\Model\Order\Invoice;
15-
use Magento\Sales\Api\Data\CreditmemoInterface;
1615
use Magento\Sales\Api\Data\CreditmemoItemCreationInterface;
1716
use Magento\Sales\Api\Data\CreditmemoCommentCreationInterface;
1817
use Magento\Framework\EntityManager\HydratorPool;
@@ -82,7 +81,7 @@ class CreditmemoDocumentFactoryTest extends \PHPUnit\Framework\TestCase
8281
private $commentCreationArgumentsMock;
8382

8483
/**
85-
* @var CreditmemoInterface|\PHPUnit_Framework_MockObject_MockObject
84+
* @var Order\Creditmemo|\PHPUnit_Framework_MockObject_MockObject
8685
*/
8786
private $creditmemoMock;
8887

@@ -121,7 +120,7 @@ public function setUp()
121120
$this->creditmemoItemCreationMock = $this->getMockBuilder(CreditmemoItemCreationInterface::class)
122121
->disableOriginalConstructor()
123122
->getMock();
124-
$this->creditmemoMock = $this->getMockBuilder(CreditmemoInterface::class)
123+
$this->creditmemoMock = $this->getMockBuilder(Order\Creditmemo::class)
125124
->disableOriginalConstructor()
126125
->getMock();
127126
$this->hydratorMock = $this->getMockBuilder(HydratorInterface::class)

0 commit comments

Comments
 (0)