MAGETWO-70885: [SOAP] The 'incrementId' property of the order with state 'complete' is increased after order status update

Aliaksei Yakimovich2 · Aliaksei Yakimovich2 · commit 9bbcd413f157 · 2019-07-09T13:43:06.000+03:00
- Fixed an issue with skipped incrent ids when order creates;
diff --git a/app/code/Magento/Sales/Model/ResourceModel/EntityAbstract.php b/app/code/Magento/Sales/Model/ResourceModel/EntityAbstract.php
@@ -125,7 +125,7 @@ protected function _prepareDataForSave(\Magento\Framework\Model\AbstractModel $o
     protected function _beforeSave(\Magento\Framework\Model\AbstractModel $object)
     {
         /** @var \Magento\Sales\Model\AbstractModel $object */
-        if ($object instanceof EntityInterface && $object->getEntityId() == null) {
+        if ($object instanceof EntityInterface && $object->getEntityId() == null && $object->getIncrementId() == null) {
             $store = $object->getStore();
             $storeId = $store->getId();
             if ($storeId === null) {

Original file line number	Diff line number	Diff line change
`@@ -125,7 +125,7 @@ protected function _prepareDataForSave(\Magento\Framework\Model\AbstractModel $o`
`125`	`125`	`protected function _beforeSave(\Magento\Framework\Model\AbstractModel $object)`
`126`	`126`	`{`
`127`	`127`	`/** @var \Magento\Sales\Model\AbstractModel $object */`
`128`		`- if ($object instanceof EntityInterface && $object->getEntityId() == null) {`
	`128`	`+ if ($object instanceof EntityInterface && $object->getEntityId() == null && $object->getIncrementId() == null) {`
`129`	`129`	`$store = $object->getStore();`
`130`	`130`	`$storeId = $store->getId();`
`131`	`131`	`if ($storeId === null) {`