ACPT-1666: Fix race conditions in _resetState methods

Author: andimov

dev/tests/integration/testsuite/Magento/GraphQl/App/GraphQlCheckoutMutationsStateTest.php

@@ -9,6 +9,10 @@
 
 use Magento\Catalog\Api\ProductRepositoryInterface;
 use Magento\GraphQl\App\State\GraphQlStateDiff;
+use Magento\Quote\Test\Fixture\GuestCart as GuestCartFixture;
+use Magento\TestFramework\Fixture\DataFixture;
+use Magento\TestFramework\Fixture\DataFixtureStorage;
+use Magento\TestFramework\Fixture\DataFixtureStorageManager;
 
 /**
  * Tests the dispatch method in the GraphQl Controller class using a simple product query
@@ -25,12 +29,18 @@ class GraphQlCheckoutMutationsStateTest extends \PHPUnit\Framework\TestCase
      */
     private ?GraphQlStateDiff $graphQlStateDiff = null;
 
+    /**
+     * @var DataFixtureStorage
+     */
+    private DataFixtureStorage $fixtures;
+
     /**
      * @inheritDoc
      */
     protected function setUp(): void
     {
         $this->graphQlStateDiff = new GraphQlStateDiff();
+        $this->fixtures = Bootstrap::getObjectManager()->get(DataFixtureStorageManager::class)->getStorage();
         parent::setUp();
     }
 
@@ -61,14 +71,17 @@ public function testCreateEmptyCart() : void
     }
 
     /**
-     * @magentoDataFixture Magento/GraphQl/Quote/_files/guest/create_two_empty_carts.php
      * @magentoDataFixture Magento/GraphQl/Catalog/_files/simple_product.php
      * @return void
      */
-    public function testAddSimpleProductToCart()
+    #[
+        DataFixture(GuestCartFixture::class, as: 'cart1'),
+        DataFixture(GuestCartFixture::class, as: 'cart2'),
+    ]
+    public function testAddSimpleProductToCart(): void
     {
-        $cartId1 = $this->graphQlStateDiff->getCartIdHash('test_quote1');
-        $cartId2 = $this->graphQlStateDiff->getCartIdHash('test_quote2');
+        $cartId1 = $this->fixtures->get('cart1')->getId();
+        $cartId2 = $this->fixtures->get('cart2')->getId();
         $query = $this->getAddProductToCartQuery();
         $this->graphQlStateDiff->testState(
             $query,
@@ -105,14 +118,17 @@ public function testAddCouponToCart()
     }
 
     /**
-     * @magentoDataFixture Magento/GraphQl/Quote/_files/guest/create_two_empty_carts.php
      * @magentoDataFixture Magento/GraphQl/Catalog/_files/virtual_product.php
      * @return void
      */
+    #[
+        DataFixture(GuestCartFixture::class, as: 'cart1'),
+        DataFixture(GuestCartFixture::class, as: 'cart2'),
+    ]
     public function testAddVirtualProductToCart()
     {
-        $cartId1 = $this->graphQlStateDiff->getCartIdHash('test_quote1');
-        $cartId2 = $this->graphQlStateDiff->getCartIdHash('test_quote2');
+        $cartId1 = $this->fixtures->get('cart1')->getId();
+        $cartId2 = $this->fixtures->get('cart2')->getId();
         $query = $this->getAddVirtualProductToCartQuery();
         $this->graphQlStateDiff->testState(
             $query,
@@ -126,14 +142,17 @@ public function testAddVirtualProductToCart()
     }
 
     /**
-     * @magentoDataFixture Magento/GraphQl/Quote/_files/guest/create_two_empty_carts.php
      * @magentoDataFixture Magento/Bundle/_files/product.php
      * @return void
      */
+    #[
+        DataFixture(GuestCartFixture::class, as: 'cart1'),
+        DataFixture(GuestCartFixture::class, as: 'cart2'),
+    ]
     public function testAddBundleProductToCart()
     {
-        $cartId1 = $this->graphQlStateDiff->getCartIdHash('test_quote1');
-        $cartId2 = $this->graphQlStateDiff->getCartIdHash('test_quote2');
+        $cartId1 = $this->fixtures->get('cart1')->getId();
+        $cartId2 = $this->fixtures->get('cart2')->getId();
         $query = $this->getAddBundleProductToCartQuery('bundle-product');
         $this->graphQlStateDiff->testState(
             $query,
@@ -147,14 +166,17 @@ public function testAddBundleProductToCart()
     }
 
     /**
-     * @magentoDataFixture Magento/GraphQl/Quote/_files/guest/create_two_empty_carts.php
      * @magentoDataFixture Magento/ConfigurableProduct/_files/product_configurable.php
      * @return void
      */
+    #[
+        DataFixture(GuestCartFixture::class, as: 'cart1'),
+        DataFixture(GuestCartFixture::class, as: 'cart2'),
+    ]
     public function testAddConfigurableProductToCart(): void
     {
-        $cartId1 = $this->graphQlStateDiff->getCartIdHash('test_quote1');
-        $cartId2 = $this->graphQlStateDiff->getCartIdHash('test_quote2');
+        $cartId1 = $this->fixtures->get('cart1')->getId();
+        $cartId2 = $this->fixtures->get('cart2')->getId();
         $query = $this->getAddConfigurableProductToCartQuery();
         $this->graphQlStateDiff->testState(
             $query,
@@ -168,14 +190,17 @@ public function testAddConfigurableProductToCart(): void
     }
 
     /**
-     * @magentoDataFixture Magento/GraphQl/Quote/_files/guest/create_two_empty_carts.php
      * @magentoDataFixture Magento/Downloadable/_files/product_downloadable_with_purchased_separately_links.php
      * @return void
      */
+    #[
+        DataFixture(GuestCartFixture::class, as: 'cart1'),
+        DataFixture(GuestCartFixture::class, as: 'cart2'),
+    ]
     public function testAddDownloadableProductToCart(): void
     {
-        $cartId1 = $this->graphQlStateDiff->getCartIdHash('test_quote1');
-        $cartId2 = $this->graphQlStateDiff->getCartIdHash('test_quote2');
+        $cartId1 = $this->fixtures->get('cart1')->getId();
+        $cartId2 = $this->fixtures->get('cart2')->getId();
         $sku = 'downloadable-product-with-purchased-separately-links';
         $links = $this->getProductsLinks($sku);
         $linkId = key($links);