Skip to content

Commit 9aa3485

Browse files
committed
B2B-2530: Unskip GraphQL cache tests skipped due to DEVOPS-4924
- Adjusted review comments
1 parent 93f7004 commit 9aa3485

File tree

1 file changed

+11
-4
lines changed

1 file changed

+11
-4
lines changed

dev/tests/api-functional/testsuite/Magento/GraphQl/PageCache/Cms/BlockCacheTest.php

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -94,23 +94,30 @@ public function testCacheIsInvalidatedOnBlockUpdate()
9494
[CacheIdCalculator::CACHE_ID_HEADER => $cacheIdOfEnabledBlock]
9595
);
9696

97-
//cache-debug should be a MISS after updating content on fixture block
97+
//updating content on fixture block
9898
$newBlockContent = 'New block content!!!';
9999
$this->updateBlockContent($fixtureBlockIdentifier, $newBlockContent);
100100

101-
// Verify we obtain a cache MISS on the fixture block query after the content update
101+
// Verify we obtain a cache MISS on the fixture block query
102+
// after the content update on the fixture block
102103
$fixtureBlockMissResponse = $this->assertCacheMissAndReturnResponse(
103104
$fixtureBlockQuery,
104105
[CacheIdCalculator::CACHE_ID_HEADER => $cacheIdOfFixtureBlock]
105106
);
106107

108+
$fixtureBlockHitResponse = $this->assertCacheHitAndReturnResponse(
109+
$fixtureBlockQuery,
110+
[CacheIdCalculator::CACHE_ID_HEADER => $cacheIdOfFixtureBlock]
111+
);
112+
107113
//Verify we obtain a cache HIT on the enabled block query after the fixture block is updated
108-
$enabledBlockHitResponse = $this->assertCacheHitAndReturnResponse(
114+
$this->assertCacheHitAndReturnResponse(
109115
$enabledBlockQuery,
110116
[CacheIdCalculator::CACHE_ID_HEADER => $cacheIdOfEnabledBlock]
111117
);
112118

113-
$this->assertNotEmpty($enabledBlockHitResponse['body']);
119+
$this->assertNotEmpty($fixtureBlockHitResponse['body']);
120+
114121
//updated block data should be correct on fixture block
115122
$blocks = $fixtureBlockMissResponse['body']['cmsBlocks']['items'];
116123
$this->assertArrayNotHasKey('errors', $fixtureBlockMissResponse['body']);

0 commit comments

Comments
 (0)