Fixed unit tests

Author: sivaschenko

app/code/Magento/MediaGallery/Test/Unit/Model/Asset/Command/GetByIdExceptionDuringMediaAssetInitializationTest.php

@@ -23,9 +23,19 @@
  */
 class GetByIdExceptionDuringMediaAssetInitializationTest extends \PHPUnit\Framework\TestCase
 {
-    private const MEDIA_ASSET_STUB_ID = 1;
-
-    private const MEDIA_ASSET_DATA = ['id' => 1];
+    private const MEDIA_ASSET_STUB_ID = 45;
+    private const MEDIA_ASSET_DATA = [
+        'id' => 45,
+        'path' => 'img.jpg',
+        'title' => 'Img',
+        'source' => 'Adobe Stock',
+        'content_type' => 'image/jpeg',
+        'width' => 420,
+        'height' => 240,
+        'size' => 12877,
+        'created_at' => '2020',
+        'updated_at' => '2020'
+    ];
 
     /**
      * @var GetById|MockObject
@@ -47,11 +57,6 @@ class GetByIdExceptionDuringMediaAssetInitializationTest extends \PHPUnit\Framew
      */
     private $selectStub;
 
-    /**
-     * @var Statement|MockObject
-     */
-    private $statementMock;
-
     /**
      * @var LoggerInterface|MockObject
      */
@@ -81,19 +86,21 @@ protected function setUp(): void
         $this->selectStub->method('from')->willReturnSelf();
         $this->selectStub->method('where')->willReturnSelf();
         $this->adapter->method('select')->willReturn($this->selectStub);
-
-        $this->statementMock = $this->getMockBuilder(\Zend_Db_Statement_Interface::class)->getMock();
     }
 
     /**
      * Test case when a problem occurred during asset initialization from received data.
      */
     public function testErrorDuringMediaAssetInitializationException(): void
     {
-        $this->statementMock->method('fetch')->willReturn(self::MEDIA_ASSET_DATA);
-        $this->adapter->method('query')->willReturn($this->statementMock);
-
-        $this->assetFactory->expects($this->once())->method('create')->willThrowException(new \Exception());
+        $statementMock = $this->createMock(\Zend_Db_Statement_Interface::class);
+        $statementMock->method('fetch')
+            ->willReturn(self::MEDIA_ASSET_DATA);
+        $this->adapter->method('query')->willReturn($statementMock);
+
+        $this->assetFactory->expects($this->once())
+            ->method('create')
+            ->willThrowException(new \Exception());
 
         $this->expectException(IntegrationException::class);
         $this->logger->expects($this->any())

app/code/Magento/MediaGallery/Test/Unit/Model/Asset/Command/GetByIdExceptionOnGetDataTest.php

@@ -23,9 +23,19 @@
  */
 class GetByIdExceptionOnGetDataTest extends \PHPUnit\Framework\TestCase
 {
-    private const MEDIA_ASSET_STUB_ID = 1;
-
-    private const MEDIA_ASSET_DATA = ['id' => 1];
+    private const MEDIA_ASSET_STUB_ID = 45;
+    private const MEDIA_ASSET_DATA = [
+        'id' => 45,
+        'path' => 'img.jpg',
+        'title' => 'Img',
+        'source' => 'Adobe Stock',
+        'content_type' => 'image/jpeg',
+        'width' => 420,
+        'height' => 240,
+        'size' => 12877,
+        'created_at' => '2020',
+        'updated_at' => '2020'
+    ];
 
     /**
      * @var GetById|MockObject

app/code/Magento/MediaGallery/Test/Unit/Model/Asset/Command/GetByIdSuccessfulTest.php

@@ -23,9 +23,19 @@
  */
 class GetByIdSuccessfulTest extends \PHPUnit\Framework\TestCase
 {
-    private const MEDIA_ASSET_STUB_ID = 1;
-
-    private const MEDIA_ASSET_DATA = ['id' => 1];
+    private const MEDIA_ASSET_STUB_ID = 45;
+    private const MEDIA_ASSET_DATA = [
+        'id' => 45,
+        'path' => 'img.jpg',
+        'title' => 'Img',
+        'source' => 'Adobe Stock',
+        'content_type' => 'image/jpeg',
+        'width' => 420,
+        'height' => 240,
+        'size' => 12877,
+        'created_at' => '2020',
+        'updated_at' => '2020'
+    ];
 
     /**
      * @var GetById|MockObject

app/code/Magento/MediaGallery/Test/Unit/Model/Keyword/Command/GetAssetKeywordsTest.php

@@ -83,9 +83,32 @@ public function testFind(array $databaseQueryResult, int $expectedNumberOfFoundK
     public function casesProvider(): array
     {
         return [
-            'not_found' => [[],0],
-            'find_one_keyword' => [['keywordRawData'],1],
-            'find_several_keywords' => [['keywordRawData', 'keywordRawData'],2],
+            'not_found' => [
+                [],
+                0
+            ],
+            'find_one_keyword' => [
+                [
+                    [
+                        'id' => 1,
+                        'keyword' => 'keywordRawData'
+                    ]
+                ],
+                1
+            ],
+            'find_several_keywords' => [
+                [
+                    [
+                        'id' => 1,
+                        'keyword' => 'keywordRawData'
+                    ],
+                    [
+                        'id' => 2,
+                        'keyword' => 'keywordRawData2'
+                    ]
+                ],
+                2
+            ],
         ];
     }