MAGETWO-67431: Functional test \Magento\ConfigurableProduct\Test\TestCase\CreateConfigurableProductEntityTest fails randomly

- fixed MAGETWO-69870
- fixed MAGETWO-57942
- fixed MAGETWO-69084
- fixed MAGETWO-60449

Author: vgoncharenko

dev/tests/functional/tests/app/Magento/Analytics/Test/Constraint/AssertBIEssentialsLink.php

@@ -3,16 +3,23 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+
 namespace Magento\Analytics\Test\Constraint;
 
 use Magento\Mtf\Client\BrowserInterface;
 use Magento\Mtf\Constraint\AbstractConstraint;
+use Magento\Backend\Test\Page\Adminhtml\Dashboard;
 
 /**
  * Assert BI Essentials Sign Up page is opened by admin menu link
  */
 class AssertBIEssentialsLink extends AbstractConstraint
 {
+    /**
+     * Count of try for choose menu item.
+     */
+    const MAX_TRY_COUNT = 2;
+
     /**
      * Browser instance.
      *
@@ -25,19 +32,46 @@ class AssertBIEssentialsLink extends AbstractConstraint
      *
      * @param BrowserInterface $browser
      * @param string $businessIntelligenceLink
+     * @param Dashboard $dashboard
+     * @param string $menuItem
+     * @param bool $waitMenuItemNotVisible
      * @return void
      */
-    public function processAssert(BrowserInterface $browser, $businessIntelligenceLink)
-    {
+    public function processAssert(
+        BrowserInterface $browser,
+        $businessIntelligenceLink,
+        Dashboard $dashboard,
+        $menuItem,
+        $waitMenuItemNotVisible = false
+    ) {
+        /**
+         * In the parallel run case new windows that adding to selenium grid windows handler
+         * are in competition with another windows in another browsers in the same selenium grid.
+         * During this case need to have some algorithm for retrying some operations that changed
+         * current window for browser, because it's some times happens.
+         */
         $this->browser = $browser;
-        $this->browser->selectWindow();
-        \PHPUnit_Framework_Assert::assertTrue(
-            $this->browser->waitUntil(
-                function () use ($businessIntelligenceLink) {
+        $count = 0;
+        $isVisible = false;
+        do {
+            try {
+                $this->browser->selectWindow();
+                $isVisible = $this->browser->waitUntil(function () use ($businessIntelligenceLink) {
                     return ($this->browser->getUrl() === $businessIntelligenceLink) ?: null;
-                }
-            ),
-            'BI Essentials Sign Up page was not opened by link.'
+                });
+                break;
+            } catch (\Throwable $e) {
+                $dashboard->open();
+                $dashboard->getMenuBlock()->navigate($menuItem, $waitMenuItemNotVisible);
+                $count++;
+            }
+        } while ($count < self::MAX_TRY_COUNT);
+
+        \PHPUnit_Framework_Assert::assertTrue(
+            $isVisible,
+            "BI Essentials Sign Up page was not opened by link.\n
+                Actual link is '{$this->browser->getUrl()}'\n
+                Expected link is '$businessIntelligenceLink'"
         );
     }
 

dev/tests/functional/tests/app/Magento/SalesRule/Test/Repository/SalesRule.xml

@@ -202,8 +202,8 @@
             <field name="coupon_type" xsi:type="string">No Coupon</field>
             <field name="sort_order" xsi:type="string">0</field>
             <field name="is_rss" xsi:type="string">Yes</field>
-            <field name="conditions_serialized" xsi:type="string">{Products subselection|total quantity|is|2|:[[Price in cart|is|50]]}</field>
-            <field name="actions_serialized" xsi:type="string">[Price in cart|is|50]</field>
+            <field name="conditions_serialized" xsi:type="string">{Products subselection|qty|is|2|:[[Price in cart|is|50]]}</field>
+            <field name="actions_serialized" xsi:type="string">{Conditions combination|ALL|TRUE|:[[Price in cart|is|50]]}</field>
             <field name="simple_action" xsi:type="string">Percent of product price discount</field>
             <field name="discount_amount" xsi:type="string">10</field>
             <field name="discount_qty" xsi:type="string">1</field>

dev/tests/functional/tests/app/Magento/SalesRule/Test/TestCase/ApplySeveralSalesRuleEntityTest.xml

@@ -8,7 +8,6 @@
 <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../../vendor/magento/mtf/etc/variations.xsd">
     <testCase name="Magento\SalesRule\Test\TestCase\ApplySeveralSalesRuleEntityTest" summary="Apply Several Sales Rules" ticketId="MAGETWO-45883">
         <variation name="ApplySeveralSalesRuleEntityTestVariation1" summary="Rules with same priority, both are applied">
-            <data name="tag" xsi:type="string">to_maintain:yes</data>
             <data name="salesRules/rule1" xsi:type="string">active_sales_rule_product_subselection</data>
             <data name="salesRules/rule2" xsi:type="string">active_sales_rule_product_attribute</data>
             <data name="cartPrice/sub_total" xsi:type="string">200.00</data>