MAGETWO-33622: Junior+ Developer Workflow

- fix static tests

Author: Pavlo Cherniavskyi

dev/tests/unit/testsuite/Magento/Framework/App/View/Asset/MaterializationStrategy/FactoryTest.php

@@ -54,7 +54,9 @@ public function testCreateSupported()
             ->with($asset)
             ->willReturn(false);
 
-        $supportedStrategy = $this->getMockBuilder('Magento\Framework\App\View\Asset\MaterializationStrategy\StrategyInterface')
+        $supportedStrategy = $this->getMockBuilder(
+            'Magento\Framework\App\View\Asset\MaterializationStrategy\StrategyInterface'
+        )
             ->setMethods([])
             ->getMock();
         $supportedStrategy->expects($this->once())

dev/tests/unit/testsuite/Magento/Framework/App/View/Asset/MaterializationStrategy/SymlinkTest.php

@@ -65,4 +65,4 @@ public function sourceFileDataProvider()
             [DirectoryList::TMP_MATERIALIZATION_DIR . '/path/to/file', false]
         ];
     }
-}
+}

lib/internal/Magento/Framework/App/View/Asset/MaterializationStrategy/Copy.php

@@ -16,8 +16,8 @@ class Copy implements StrategyInterface
      *
      * @param WriteInterface $rootDir
      * @param WriteInterface $targetDir
-     * @param $sourcePath
-     * @param $destinationPath
+     * @param string $sourcePath
+     * @param string $destinationPath
      * @return bool
      */
     public function publishFile(

lib/internal/Magento/Framework/App/View/Asset/MaterializationStrategy/StrategyInterface.php

@@ -16,8 +16,8 @@ interface StrategyInterface
      *
      * @param WriteInterface $rootDir
      * @param WriteInterface $targetDir
-     * @param $sourcePath
-     * @param $destinationPath
+     * @param string $sourcePath
+     * @param string $destinationPath
      * @return bool
      */
     public function publishFile(

lib/internal/Magento/Framework/App/View/Asset/MaterializationStrategy/Symlink.php

@@ -17,8 +17,8 @@ class Symlink implements StrategyInterface
      *
      * @param WriteInterface $rootDir
      * @param WriteInterface $targetDir
-     * @param $sourcePath
-     * @param $destinationPath
+     * @param string $sourcePath
+     * @param string $destinationPath
      * @return bool
      */
     public function publishFile(

lib/internal/Magento/Framework/View/Asset/File.php

@@ -101,7 +101,7 @@ public function getPath()
     public function getRelativeSourceFilePath()
     {
         $path = $this->filePath;
-        if  (strpos($this->source->findRelativeSourceFilePath($this), 'less'))  {
+        if (strpos($this->source->findRelativeSourceFilePath($this), 'less')) {
             $path = str_replace('.css', '.less', $this->filePath);
         }
         $result = '';

lib/internal/Magento/Framework/View/Asset/PreProcessor/Chain.php

@@ -47,6 +47,9 @@ class Chain
      */
     private $appMode;
 
+    /**
+     * @var null|string
+     */
     private $targetAssetPath;
 
     /**
@@ -60,7 +63,7 @@ public function __construct(
         \Magento\Framework\View\Asset\LocalInterface $asset,
         $origContent,
         $origContentType,
-        $origAssetPath =  null,
+        $origAssetPath = null,
         $appMode = \Magento\Framework\App\State::MODE_DEFAULT
     ) {
         $this->asset = $asset;

lib/internal/Magento/Framework/View/Asset/Source.php

@@ -62,6 +62,7 @@ class Source
      * @param PreProcessor\Pool $preProcessorPool
      * @param \Magento\Framework\View\Design\FileResolution\Fallback\StaticFile $fallback
      * @param \Magento\Framework\View\Design\Theme\ListInterface $themeList
+     * @param string $appMode
      */
     public function __construct(
         PreProcessor\Cache $cache,
@@ -229,6 +230,11 @@ private function findFile(LocalInterface $asset, \Magento\Framework\View\Asset\F
         return $dir->getAbsolutePath($asset->getPath());
     }
 
+    /**
+     * @param \Magento\Framework\View\Asset\LocalInterface $asset
+     *
+     * @return bool|string
+     */
     public function findRelativeSourceFilePath(LocalInterface $asset)
     {
         $sourceFile = $this->findSourceFile($asset);

lib/internal/Magento/Framework/View/Page/Config/Renderer.php

@@ -72,6 +72,8 @@ class Renderer
      * @param \Magento\Framework\Escaper $escaper
      * @param \Magento\Framework\Stdlib\String $string
      * @param \Psr\Log\LoggerInterface $logger
+     * @param \Magento\Framework\View\Asset\Repository $assetRepo
+     * @param string $appMode
      */
     public function __construct(
         Config $pageConfig,
@@ -402,7 +404,7 @@ protected function renderAssetHtml($template, $assets)
     /**
      * Injecting less.js compiler
      *
-     * @param $resultGroups
+     * @param array $resultGroups
      *
      * @return mixed
      */