MC-42358: Flex attributes are sent to PayPal even though Text style was configured for Message

Author: krissyhiserote

app/code/Magento/Paypal/Model/PayLaterConfig.php

@@ -7,8 +7,6 @@
 
 namespace Magento\Paypal\Model;
 
-use Magento\Framework\App\Config\ScopeConfigInterface;
-
 /**
  * Provides configuration values for PayPal PayLater Banners
  */
@@ -34,25 +32,17 @@ class PayLaterConfig
      */
     private $config;
 
-    /**
-     * @var ScopeConfigInterface
-     */
-    private $scopeConfig;
-
     /**
      * @var array
      */
     private $configData = [];
 
     /**
-     * @param ScopeConfigInterface $scopeConfig
      * @param ConfigFactory $configFactory
      */
     public function __construct(
-        ScopeConfigInterface $scopeConfig,
         ConfigFactory $configFactory
     ) {
-        $this->scopeConfig = $scopeConfig;
         $this->config = $configFactory->create();
     }
 
@@ -76,9 +66,9 @@ public function isEnabled(string $placement): bool
     /**
      * Check that PayPal Credit enabled with any PayPal express method
      *
-     * @return
+     * @return bool
      */
-    private function isPPCreditEnabled()
+    private function isPPCreditEnabled(): bool
     {
         $isEnabled = false;
         if ($this->config->setMethod(Config::METHOD_EXPRESS)->getValue('in_context')) {
@@ -106,32 +96,43 @@ public function getSectionConfig(string $section, string $key)
             $this->configData[$section] = [
                 'display' => (boolean)$this->config->getPayLaterConfigValue("${sectionName}_display"),
                 'position' => $this->config->getPayLaterConfigValue("${sectionName}_position"),
-                'style' => [
-                    'data-pp-style-layout' => $this->config->getPayLaterConfigValue(
-                        "${sectionName}_stylelayout"
-                    ),
-                    'data-pp-style-logo-type' => $this->config->getPayLaterConfigValue(
-                        "${sectionName}_logotype"
-                    ),
-                    'data-pp-style-logo-position' => $this->config->getPayLaterConfigValue(
-                        "${sectionName}_logoposition"
-                    ),
-                    'data-pp-style-text-color' => $this->config->getPayLaterConfigValue(
-                        "${sectionName}_textcolor"
-                    ),
-                    'data-pp-style-text-size' => $this->config->getPayLaterConfigValue(
-                        "${sectionName}_textsize"
-                    ),
-                    'data-pp-style-color' => $this->config->getPayLaterConfigValue(
-                        "${sectionName}_color"
-                    ),
-                    'data-pp-style-ratio' => $this->config->getPayLaterConfigValue(
-                        "${sectionName}_ratio"
-                    )
-                ]
+                'style' => $this->getConfigStyles($sectionName)
             ];
         }
 
         return $this->configData[$section][$key];
     }
+
+    /**
+     * Get only the config styles that are needed
+     *
+     * @param string $sectionName
+     * @return array
+     */
+    private function getConfigStyles(string $sectionName): array
+    {
+        $styleLayout = $this->config->getPayLaterConfigValue("${sectionName}_stylelayout");
+        $logoType = $styleLayout === 'text'
+            ? $this->config->getPayLaterConfigValue("${sectionName}_logotype") : null;
+        $logoPosition = $styleLayout === 'text' && ($logoType === 'primary' || $logoType === 'alternative')
+            ? $this->config->getPayLaterConfigValue("${sectionName}_logoposition") : null;
+        $textColor = $styleLayout === 'text'
+            ? $this->config->getPayLaterConfigValue("${sectionName}_textcolor") : null;
+        $textSize = $styleLayout === 'text'
+            ? $this->config->getPayLaterConfigValue("${sectionName}_textsize") : null;
+        $color = $styleLayout === 'flex'
+            ? $this->config->getPayLaterConfigValue("${sectionName}_color") : null;
+        $ratio = $styleLayout === 'flex'
+            ? $this->config->getPayLaterConfigValue("${sectionName}_ratio") : null;
+
+        return [
+            'data-pp-style-layout' => $styleLayout,
+            'data-pp-style-logo-type' => $logoType,
+            'data-pp-style-logo-position' => $logoPosition,
+            'data-pp-style-text-color' => $textColor,
+            'data-pp-style-text-size' => $textSize,
+            'data-pp-style-color' => $color,
+            'data-pp-style-ratio' => $ratio
+        ];
+    }
 }