Skip to content

Commit 992d40d

Browse files
author
Roman Ganin
committed
MAGETWO-32396: Create integration test for minifier
- removed constants for better readability - renamed preminified file to avoid fallback calls for minified files
1 parent 43f4455 commit 992d40d

File tree

2 files changed

+5
-11
lines changed

2 files changed

+5
-11
lines changed

dev/tests/integration/testsuite/Magento/Framework/View/Asset/MinifierTest.php

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -12,17 +12,11 @@
1212
*/
1313
class MinifierTest extends \PHPUnit_Framework_TestCase
1414
{
15-
/**
16-
* Request path for test minifier
17-
*/
18-
const REQUEST_PATH = '/frontend/Magento/blank/en_US/css/styles.css';
19-
2015
/**
2116
* @var \Magento\Framework\ObjectManagerInterface
2217
*/
2318
protected $objectManager;
2419

25-
2620
protected function setUp()
2721
{
2822
$this->objectManager = Bootstrap::getInstance()->getObjectManager();
@@ -125,7 +119,7 @@ protected function _testCssMinification($requestedUri, $requestedFilePath, $test
125119
public function testCssMinification()
126120
{
127121
$this->_testCssMinification(
128-
self::REQUEST_PATH,
122+
'/frontend/Magento/blank/en_US/css/styles.css',
129123
'/frontend/Magento/blank/web/css/styles.css',
130124
dirname(__DIR__) . '/_files/static/css/styles.css',
131125
function ($path) {
@@ -144,7 +138,7 @@ function ($path) {
144138
public function testCssMinificationOff()
145139
{
146140
$this->_testCssMinification(
147-
self::REQUEST_PATH,
141+
'/frontend/Magento/blank/en_US/css/styles.css',
148142
'/frontend/Magento/blank/web/css/styles.css',
149143
dirname(__DIR__) . '/_files/static/css/styles.css',
150144
function ($path) {
@@ -166,9 +160,9 @@ function ($path) {
166160
public function testCssMinificationForMinifiedFiles()
167161
{
168162
$this->_testCssMinification(
169-
'/frontend/Magento/blank/en_US/css/styles.min.css',
170-
'/frontend/Magento/blank/web/css/styles.min.css',
171-
dirname(__DIR__) . '/_files/static/css/styles.min.css',
163+
'/frontend/Magento/blank/en_US/css/preminified-styles.min.css',
164+
'/frontend/Magento/blank/web/css/preminified-styles.min.css',
165+
dirname(__DIR__) . '/_files/static/css/preminified-styles.min.css',
172166
function ($path) {
173167
$content = file_get_contents($path);
174168
$this->assertNotEmpty($content);

0 commit comments

Comments
 (0)