Skip to content

Commit 98f59df

Browse files
committed
MAGETWO-32640: Move Magento\Core\Model\Factory.php is to Magento Framework as a part of Magento\Framework\Data\Collection
- fix tests
1 parent 047ebdf commit 98f59df

File tree

5 files changed

+13
-7
lines changed

5 files changed

+13
-7
lines changed

app/code/Magento/Backend/Model/Auth.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ class Auth
4040
protected $_coreConfig;
4141

4242
/**
43-
* @var \Magento\Framework\Data\Collection\Factory
43+
* @var \Magento\Framework\Data\Collection\ModelFactory
4444
*/
4545
protected $_modelFactory;
4646

@@ -50,15 +50,15 @@ class Auth
5050
* @param \Magento\Backend\Model\Auth\StorageInterface $authStorage
5151
* @param \Magento\Backend\Model\Auth\Credential\StorageInterface $credentialStorage
5252
* @param \Magento\Framework\App\Config\ScopeConfigInterface $coreConfig
53-
* @param \Magento\Framework\Data\Collection\Factory $modelFactory
53+
* @param \Magento\Framework\Data\Collection\ModelFactory $modelFactory
5454
*/
5555
public function __construct(
5656
\Magento\Framework\Event\ManagerInterface $eventManager,
5757
\Magento\Backend\Helper\Data $backendData,
5858
\Magento\Backend\Model\Auth\StorageInterface $authStorage,
5959
\Magento\Backend\Model\Auth\Credential\StorageInterface $credentialStorage,
6060
\Magento\Framework\App\Config\ScopeConfigInterface $coreConfig,
61-
\Magento\Framework\Data\Collection\Factory $modelFactory
61+
\Magento\Framework\Data\Collection\ModelFactory $modelFactory
6262
) {
6363
$this->_eventManager = $eventManager;
6464
$this->_backendData = $backendData;

dev/tests/static/testsuite/Magento/Test/Legacy/_files/obsolete_classes.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2837,7 +2837,7 @@
28372837
['Magento\GiftMessage\Helper\Url'],
28382838
['Magento\Rss\Helper\Data'],
28392839
['Magento\Core\Model\EntityFactory', 'Magento\Framework\Data\Collection\EntityFactory'],
2840-
['Magento\Core\Model\Factory', 'Magento\Framework\Data\Collection\Factory'],
2840+
['Magento\Core\Model\Factory', 'Magento\Framework\Data\Collection\ModelFactory'],
28412841
['Magento\Sales\Model\ConverterInterface'],
28422842
['Magento\Paypal\Block\System\Config\Fieldset\Location'],
28432843
['Magento\Paypal\Block\Payflow\Advanced\Review'],

dev/tests/unit/testsuite/Magento/Backend/Model/AuthTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ protected function setUp()
3636
{
3737
$this->_eventManagerMock = $this->getMock('\Magento\Framework\Event\ManagerInterface');
3838
$this->_credentialStorage = $this->getMock('\Magento\Backend\Model\Auth\Credential\StorageInterface');
39-
$this->_modelFactoryMock = $this->getMock('\Magento\Framework\Data\Collection\Factory', [], [], '', false);
39+
$this->_modelFactoryMock = $this->getMock('\Magento\Framework\Data\Collection\ModelFactory', [], [], '', false);
4040
$objectManager = new ObjectManager($this);
4141
$this->_model = $objectManager->getObject(
4242
'Magento\Backend\Model\Auth',

dev/tests/unit/testsuite/Magento/Eav/Model/Entity/Collection/AbstractCollectionTest.php

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,13 @@ class AbstractCollectionTest extends \PHPUnit_Framework_TestCase
5959

6060
public function setUp()
6161
{
62-
$this->coreEntityFactoryMock = $this->getMock('Magento\Framework\Data\Collection\EntityFactory', [], [], '', false);
62+
$this->coreEntityFactoryMock = $this->getMock(
63+
'Magento\Framework\Data\Collection\EntityFactory',
64+
[],
65+
[],
66+
'',
67+
false
68+
);
6369
$this->loggerMock = $this->getMock('Psr\Log\LoggerInterface');
6470
$this->fetchStrategyMock = $this->getMock(
6571
'Magento\Framework\Data\Collection\Db\FetchStrategyInterface',

lib/internal/Magento/Framework/Data/Collection/Factory.php renamed to lib/internal/Magento/Framework/Data/Collection/ModelFactory.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
/**
99
* Model object factory
1010
*/
11-
class Factory
11+
class ModelFactory
1212
{
1313
/**
1414
* @var \Magento\Framework\ObjectManagerInterface

0 commit comments

Comments
 (0)