Skip to content

Commit 9885eef

Browse files
committed
MCP-826: Use RabbitMQ for all consumers if AMQP is set in deployment config
- Fix static tests;
1 parent 3b2379a commit 9885eef

File tree

3 files changed

+5
-9
lines changed

3 files changed

+5
-9
lines changed

dev/tests/integration/testsuite/Magento/Framework/MessageQueue/Consumer/DeprecatedConfigTest.php

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,11 @@
66
namespace Magento\Framework\MessageQueue\Consumer;
77

88
use Magento\Framework\MessageQueue\Consumer\Config\ConsumerConfigItem\Handler\Iterator as HandlerIterator;
9-
use Magento\TestModuleMessageQueueConfiguration\AsyncHandler;
10-
use Magento\TestModuleMessageQueueConfiguration\SyncHandler;
119

1210
/**
1311
* Test access to consumer configuration declared in deprecated queue.xml configs using Consumer\ConfigInterface.
1412
*
1513
* @magentoCache config disabled
16-
* @SuppressWarnings(PHPMD)
1714
*/
1815
class DeprecatedConfigTest extends \PHPUnit\Framework\TestCase
1916
{
@@ -43,9 +40,9 @@ public function testGetConsumerMultipleHandlersFromCommunicationConfig()
4340
$this->assertInstanceOf(HandlerIterator::class, $handlers);
4441
$this->assertCount(2, $handlers);
4542
$this->assertEquals('methodWithBoolParam', $handlers[0]->getMethod());
46-
$this->assertEquals(AsyncHandler::class, $handlers[0]->getType());
43+
$this->assertEquals('Magento\TestModuleMessageQueueConfiguration\AsyncHandler', $handlers[0]->getType());
4744
$this->assertEquals('methodWithMixedParam', $handlers[1]->getMethod());
48-
$this->assertEquals(AsyncHandler::class, $handlers[1]->getType());
45+
$this->assertEquals('Magento\TestModuleMessageQueueConfiguration\AsyncHandler', $handlers[1]->getType());
4946
}
5047

5148
public function testGetConsumerCustomHandler()
@@ -64,7 +61,7 @@ public function testGetConsumerCustomHandler()
6461
$this->assertInstanceOf(HandlerIterator::class, $handlers);
6562
$this->assertCount(1, $handlers);
6663
$this->assertEquals('methodWithMixedParam', $handlers[0]->getMethod());
67-
$this->assertEquals(AsyncHandler::class, $handlers[0]->getType());
64+
$this->assertEquals('Magento\TestModuleMessageQueueConfiguration\AsyncHandler', $handlers[0]->getType());
6865
}
6966

7067
public function testGetConsumerCustomConnectionSync()
@@ -83,7 +80,7 @@ public function testGetConsumerCustomConnectionSync()
8380
$this->assertInstanceOf(HandlerIterator::class, $handlers);
8481
$this->assertCount(1, $handlers);
8582
$this->assertEquals('methodWithBoolParam', $handlers[0]->getMethod());
86-
$this->assertEquals(SyncHandler::class, $handlers[0]->getType());
83+
$this->assertEquals('Magento\TestModuleMessageQueueConfiguration\SyncHandler', $handlers[0]->getType());
8784
}
8885

8986
public function testGetConsumerCustomConsumerAndMaxMessages()

lib/internal/Magento/Framework/MessageQueue/Config/Reader/Xml/Converter/TopicConfig.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,6 @@ private function buildConsumers($topics)
164164
*
165165
* @param array $topics
166166
* @return array
167-
* @SuppressWarnings(PHPMD)
168167
*/
169168
private function processWildcard($topics)
170169
{

lib/internal/Magento/Framework/MessageQueue/Topology/Config/Xml/Converter.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ public function __construct(
5858

5959
/**
6060
* @inheritdoc
61-
* @SuppressWarnings(PHPMD)
61+
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
6262
*/
6363
public function convert($source)
6464
{

0 commit comments

Comments
 (0)