Skip to content

Commit 97f683f

Browse files
Shortened variable names
1 parent 1146503 commit 97f683f

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

app/code/Magento/ConfigurableImportExport/Test/Unit/Model/Import/Product/Type/ConfigurableTest.php

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -587,9 +587,9 @@ public function testIsRowValid()
587587
'_product_websites' => 'website_1',
588588
];
589589
// Checking that variations with duplicate sku are invalid
590-
$duplicateVariationSKU = 'configurableskuI22DuplicateVariation';
591-
$duplicateVariationProduct = [
592-
'sku' => $duplicateVariationSKU,
590+
$duplicateSKU = 'configurableskuI22DuplicateVariation';
591+
$duplicateProduct = [
592+
'sku' => $duplicateSKU,
593593
'store_view_code' => null,
594594
'attribute_set_code' => 'Default',
595595
'product_type' => 'configurable',
@@ -610,9 +610,9 @@ public function testIsRowValid()
610610
];
611611
// Checking that variations with SKUs that are the same when interpreted as number,
612612
// but different when interpreted as string are valid
613-
$nonDuplicateVariationSKU = 'configurableskuI22NonDuplicateVariation';
614-
$nonDuplicateVariationProduct = [
615-
'sku' => $nonDuplicateVariationSKU,
613+
$nonDuplicateSKU = 'configurableskuI22NonDuplicateVariation';
614+
$nonDuplicateProduct = [
615+
'sku' => $nonDuplicateSKU,
616616
'store_view_code' => null,
617617
'attribute_set_code' => 'Default',
618618
'product_type' => 'configurable',
@@ -633,8 +633,8 @@ public function testIsRowValid()
633633
];
634634
$bunch[] = $badProduct;
635635
$bunch[] = $caseInsensitiveProduct;
636-
$bunch[] = $duplicateVariationProduct;
637-
$bunch[] = $nonDuplicateVariationProduct;
636+
$bunch[] = $duplicateProduct;
637+
$bunch[] = $nonDuplicateProduct;
638638
// Set _attributes to avoid error in Magento\CatalogImportExport\Model\Import\Product\Type\AbstractType.
639639
$this->setPropertyValue($this->configurable, '_attributes', [
640640
$badProduct[\Magento\CatalogImportExport\Model\Import\Product::COL_ATTR_SET] => [],
@@ -660,10 +660,10 @@ public function testIsRowValid()
660660
if ($rowData['sku'] === $caseInsensitiveSKU) {
661661
$this->assertTrue($result);
662662
}
663-
if ($rowData['sku'] === $duplicateVariationSKU) {
663+
if ($rowData['sku'] === $duplicateSKU) {
664664
$this->assertFalse($result);
665665
}
666-
if ($rowData['sku'] === $nonDuplicateVariationSKU) {
666+
if ($rowData['sku'] === $nonDuplicateSKU) {
667667
$this->assertTrue($result);
668668
}
669669
}

0 commit comments

Comments
 (0)