@@ -587,9 +587,9 @@ public function testIsRowValid()
587
587
'_product_websites ' => 'website_1 ' ,
588
588
];
589
589
// Checking that variations with duplicate sku are invalid
590
- $ duplicateVariationSKU = 'configurableskuI22DuplicateVariation ' ;
591
- $ duplicateVariationProduct = [
592
- 'sku ' => $ duplicateVariationSKU ,
590
+ $ duplicateSKU = 'configurableskuI22DuplicateVariation ' ;
591
+ $ duplicateProduct = [
592
+ 'sku ' => $ duplicateSKU ,
593
593
'store_view_code ' => null ,
594
594
'attribute_set_code ' => 'Default ' ,
595
595
'product_type ' => 'configurable ' ,
@@ -610,9 +610,9 @@ public function testIsRowValid()
610
610
];
611
611
// Checking that variations with SKUs that are the same when interpreted as number,
612
612
// but different when interpreted as string are valid
613
- $ nonDuplicateVariationSKU = 'configurableskuI22NonDuplicateVariation ' ;
614
- $ nonDuplicateVariationProduct = [
615
- 'sku ' => $ nonDuplicateVariationSKU ,
613
+ $ nonDuplicateSKU = 'configurableskuI22NonDuplicateVariation ' ;
614
+ $ nonDuplicateProduct = [
615
+ 'sku ' => $ nonDuplicateSKU ,
616
616
'store_view_code ' => null ,
617
617
'attribute_set_code ' => 'Default ' ,
618
618
'product_type ' => 'configurable ' ,
@@ -633,8 +633,8 @@ public function testIsRowValid()
633
633
];
634
634
$ bunch [] = $ badProduct ;
635
635
$ bunch [] = $ caseInsensitiveProduct ;
636
- $ bunch [] = $ duplicateVariationProduct ;
637
- $ bunch [] = $ nonDuplicateVariationProduct ;
636
+ $ bunch [] = $ duplicateProduct ;
637
+ $ bunch [] = $ nonDuplicateProduct ;
638
638
// Set _attributes to avoid error in Magento\CatalogImportExport\Model\Import\Product\Type\AbstractType.
639
639
$ this ->setPropertyValue ($ this ->configurable , '_attributes ' , [
640
640
$ badProduct [\Magento \CatalogImportExport \Model \Import \Product::COL_ATTR_SET ] => [],
@@ -660,10 +660,10 @@ public function testIsRowValid()
660
660
if ($ rowData ['sku ' ] === $ caseInsensitiveSKU ) {
661
661
$ this ->assertTrue ($ result );
662
662
}
663
- if ($ rowData ['sku ' ] === $ duplicateVariationSKU ) {
663
+ if ($ rowData ['sku ' ] === $ duplicateSKU ) {
664
664
$ this ->assertFalse ($ result );
665
665
}
666
- if ($ rowData ['sku ' ] === $ nonDuplicateVariationSKU ) {
666
+ if ($ rowData ['sku ' ] === $ nonDuplicateSKU ) {
667
667
$ this ->assertTrue ($ result );
668
668
}
669
669
}
0 commit comments