MAGETWO-98680: Cart Price Rule code is absent on "view Order/Invoice" Admin page if had been used for Free Shipping

Author: romadjelf

app/code/Magento/Sales/Block/Adminhtml/Totals.php

@@ -9,8 +9,6 @@
 
 /**
  * Adminhtml sales totals block
- *
- * @package Magento\Sales\Block\Adminhtml
  */
 class Totals extends \Magento\Sales\Block\Order\Totals
 {
@@ -75,7 +73,7 @@ protected function _initTotals()
             $this->getSource()->getShippingDescription())
         ) {
             $shippingLabel = __('Shipping & Handling');
-            if ($this->isHasFreeShipping($this->getOrder()) && $this->getSource()->getDiscountDescription()) {
+            if ($this->isFreeShipping($this->getOrder()) && $this->getSource()->getDiscountDescription()) {
                 $shippingLabel .= sprintf(' (%s)', $this->getSource()->getDiscountDescription());
             }
             $this->_totals['shipping'] = new \Magento\Framework\DataObject(
@@ -127,16 +125,16 @@ protected function _initTotals()
      * @param Order $order
      * @return bool
      */
-    private function isHasFreeShipping(Order $order): bool
+    private function isFreeShipping(Order $order): bool
     {
-        $isActive = false;
+        $isFreeShipping = false;
         foreach ($order->getItems() as $orderItem) {
-            if ($orderItem->getFreeShipping() === '1') {
-                $isActive = true;
+            if ($orderItem->getFreeShipping() == '1') {
+                $isFreeShipping = true;
                 break;
             }
         }
 
-        return $isActive;
+        return $isFreeShipping;
     }
 }

dev/tests/integration/testsuite/Magento/Sales/Block/Adminhtml/TotalsTest.php

@@ -3,6 +3,8 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
+
 namespace Magento\Sales\Block\Adminhtml;
 
 use Magento\Framework\View\LayoutInterface;
@@ -15,10 +17,10 @@
 class TotalsTest extends \Magento\TestFramework\TestCase\AbstractBackendController
 {
     /** @var LayoutInterface */
-    protected $_layout;
+    private $layout;
 
     /** @var Totals */
-    protected $_block;
+    private $block;
 
     /** @var OrderFactory */
     private $orderFactory;
@@ -29,8 +31,8 @@ class TotalsTest extends \Magento\TestFramework\TestCase\AbstractBackendControll
     protected function setUp()
     {
         parent::setUp();
-        $this->_layout = $this->_objectManager->get(LayoutInterface::class);
-        $this->_block = $this->_layout->createBlock(Totals::class, 'totals_block');
+        $this->layout = $this->_objectManager->get(LayoutInterface::class);
+        $this->block = $this->layout->createBlock(Totals::class, 'totals_block');
         $this->orderFactory = $this->_objectManager->get(OrderFactory::class);
     }
 
@@ -43,10 +45,10 @@ public function testShowShippingCoupon()
         $order = $this->orderFactory->create();
         $order->loadByIncrementId('100000001');
 
-        $this->_block->setOrder($order);
-        $this->_block->toHtml();
+        $this->block->setOrder($order);
+        $this->block->toHtml();
 
-        $shippingTotal = $this->_block->getTotal('shipping');
+        $shippingTotal = $this->block->getTotal('shipping');
         $this->assertNotFalse($shippingTotal, 'Shipping method is absent on the total\'s block.');
         $this->assertContains(
             '1234567890',

dev/tests/integration/testsuite/Magento/Sales/_files/order_with_free_shipping_by_coupon.php

@@ -3,6 +3,7 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
 
 use Magento\Sales\Api\OrderRepositoryInterface;
 use Magento\Sales\Model\Order;