Skip to content

Commit 97096f9

Browse files
committed
AC-233: Refactor core MFTF TinyMCE ActionGroup
Added variable for CliEnableTinyMCEActionGroup
1 parent db18939 commit 97096f9

File tree

30 files changed

+89
-30
lines changed

30 files changed

+89
-30
lines changed

app/code/Magento/Catalog/Test/Mftf/Data/WYSIWYGConfigData.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
<data key="label">Yes</data>
2121
<data key="value">mage/adminhtml/wysiwyg/tiny_mce/tinymce4Adapter</data>
2222
</entity>
23-
<entity name="EnableTinyMCE">
23+
<entity name="TinyMCE">
2424
<data key="path">cms/wysiwyg/editor</data>
2525
<data key="scope_id">0</data>
2626
<data key="label">Yes</data>

app/code/Magento/Catalog/Test/Mftf/Test/AdminAddImageToWYSIWYGCatalogTest.xml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,9 @@
1111
<before>
1212
<actionGroup ref="AdminLoginActionGroup" stepKey="login"/>
1313
<actionGroup ref="EnabledWYSIWYGActionGroup" stepKey="enableWYSIWYG"/>
14-
<actionGroup ref="CliEnableTinyMCEActionGroup" stepKey="switchToTinyMCE" />
14+
<actionGroup ref="CliEnableTinyMCEActionGroup" stepKey="switchToTinyMCE" >
15+
<argument name="TinyMCEValue" value="{{TinyMCE.value}}"/>
16+
</actionGroup>
1517
</before>
1618
<annotations>
1719
<features value="Catalog"/>

app/code/Magento/Catalog/Test/Mftf/Test/AdminAddImageToWYSIWYGProductTest.xml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,9 @@
2121
<before>
2222
<actionGroup ref="AdminLoginActionGroup" stepKey="login"/>
2323
<actionGroup ref="EnabledWYSIWYGActionGroup" stepKey="enableWYSIWYG"/>
24-
<actionGroup ref="CliEnableTinyMCEActionGroup" stepKey="switchToTinyMCE" />
24+
<actionGroup ref="CliEnableTinyMCEActionGroup" stepKey="switchToTinyMCE" >
25+
<argument name="TinyMCEValue" value="{{TinyMCE.value}}"/>
26+
</actionGroup>
2527
</before>
2628

2729
<after>

app/code/Magento/Catalog/Test/Mftf/Test/AdminEditTextEditorProductAttributeTest.xml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,9 @@
2020
<before>
2121
<actionGroup ref="AdminLoginActionGroup" stepKey="loginGetFromGeneralFile"/>
2222
<actionGroup ref="EnabledWYSIWYGActionGroup" stepKey="enableWYSIWYG"/>
23-
<actionGroup ref="CliEnableTinyMCEActionGroup" stepKey="switchToTinyMCE" />
23+
<actionGroup ref="CliEnableTinyMCEActionGroup" stepKey="switchToTinyMCE" >
24+
<argument name="TinyMCEValue" value="{{TinyMCE.value}}"/>
25+
</actionGroup>
2426
<createData stepKey="myProductAttributeCreation" entity="productAttributeWysiwyg"/>
2527
<createData stepKey="myProductAttributeSetAssign" entity="AddToDefaultSet">
2628
<requiredEntity createDataKey="myProductAttributeCreation"/>

app/code/Magento/Catalog/Test/Mftf/Test/VerifyDefaultWYSIWYGToolbarOnProductTest/VerifyDefaultWYSIWYGToolbarOnProductTest.xml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,9 @@
2020
<before>
2121
<actionGroup ref="AdminLoginActionGroup" stepKey="loginGetFromGeneralFile"/>
2222
<actionGroup ref="EnabledWYSIWYGActionGroup" stepKey="enableWYSIWYG"/>
23-
<actionGroup ref="CliEnableTinyMCEActionGroup" stepKey="switchToTinyMCE"/>
23+
<actionGroup ref="CliEnableTinyMCEActionGroup" stepKey="switchToTinyMCE">
24+
<argument name="TinyMCEValue" value="{{TinyMCE.value}}"/>
25+
</actionGroup>
2426
</before>
2527
<amOnPage url="{{AdminProductCreatePage.url(AddToDefaultSet.attributeSetId, 'simple')}}" stepKey="navigateToProduct"/>
2628
<waitForPageLoad stepKey="wait"/>

app/code/Magento/Catalog/Test/Mftf/Test/VerifyDefaultWYSIWYGToolbarOnProductTest/VerifydefaultcontrolsonproductshortdescriptionTest.xml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,9 @@
2020
<before>
2121
<actionGroup ref="AdminLoginActionGroup" stepKey="loginGetFromGeneralFile"/>
2222
<actionGroup ref="EnabledWYSIWYGActionGroup" stepKey="enableWYSIWYG"/>
23-
<actionGroup ref="CliEnableTinyMCEActionGroup" stepKey="switchToTinyMCE"/>
23+
<actionGroup ref="CliEnableTinyMCEActionGroup" stepKey="switchToTinyMCE">
24+
<argument name="TinyMCEValue" value="{{TinyMCE.value}}"/>
25+
</actionGroup>
2426
</before>
2527
<amOnPage url="{{AdminProductCreatePage.url(AddToDefaultSet.attributeSetId, 'simple')}}" stepKey="navigateToProduct"/>
2628
<waitForPageLoad stepKey="wait"/>

app/code/Magento/Catalog/Test/Mftf/Test/VerifyTinyMCEv4IsNativeWYSIWYGOnCatalogTest.xml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,9 @@
2121
<before>
2222
<actionGroup ref="AdminLoginActionGroup" stepKey="loginGetFromGeneralFile"/>
2323
<actionGroup ref="EnabledWYSIWYGActionGroup" stepKey="enableWYSIWYG"/>
24-
<actionGroup ref="CliEnableTinyMCEActionGroup" stepKey="switchToTinyMCE" />
24+
<actionGroup ref="CliEnableTinyMCEActionGroup" stepKey="switchToTinyMCE" >
25+
<argument name="TinyMCEValue" value="{{TinyMCE.value}}"/>
26+
</actionGroup>
2527
</before>
2628
<actionGroup ref="AdminOpenCategoryPageActionGroup" stepKey="navigateToNewCatalog"/>
2729
<waitForLoadingMaskToDisappear stepKey="wait2" />

app/code/Magento/Catalog/Test/Mftf/Test/VerifyTinyMCEv4IsNativeWYSIWYGOnProductTest.xml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,9 @@
2020
<before>
2121
<actionGroup ref="AdminLoginActionGroup" stepKey="loginGetFromGeneralFile"/>
2222
<actionGroup ref="EnabledWYSIWYGActionGroup" stepKey="enableWYSIWYG"/>
23-
<actionGroup ref="CliEnableTinyMCEActionGroup" stepKey="switchToTinyMCE" />
23+
<actionGroup ref="CliEnableTinyMCEActionGroup" stepKey="switchToTinyMCE" >
24+
<argument name="TinyMCEValue" value="{{TinyMCE.value}}"/>
25+
</actionGroup>
2426
</before>
2527
<amOnPage url="{{AdminProductCreatePage.url(AddToDefaultSet.attributeSetId, 'simple')}}" stepKey="navigateToNewProduct"/>
2628
<waitForPageLoad stepKey="wait1"/>

app/code/Magento/Cms/Test/Mftf/ActionGroup/CliEnableTinyMCEActionGroup.xml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,10 @@
1212
<annotations>
1313
<description>Enable Tiny MCE by CLI command config:set</description>
1414
</annotations>
15+
<arguments>
16+
<argument name="TinyMCEValue" type="string"/>
17+
</arguments>
1518

16-
<magentoCLI command="config:set {{EnableTinyMCE.path}} {{EnableTinyMCE.value}}" stepKey="enableTinyMCE"/>
19+
<magentoCLI command="config:set {{TinyMCE.path}} {{TinyMCEValue}}" stepKey="enableTinyMCE"/>
1720
</actionGroup>
1821
</actionGroups>

app/code/Magento/Cms/Test/Mftf/Test/AdminAddImageToWYSIWYGBlockTest.xml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,9 @@
2222
<createData entity="_defaultBlock" stepKey="createPreReqBlock" />
2323
<actionGroup ref="AdminLoginActionGroup" stepKey="login"/>
2424
<actionGroup ref="EnabledWYSIWYGActionGroup" stepKey="enableWYSIWYG"/>
25-
<actionGroup ref="CliEnableTinyMCEActionGroup" stepKey="switchToTinyMCE" />
25+
<actionGroup ref="CliEnableTinyMCEActionGroup" stepKey="switchToTinyMCE" >
26+
<argument name="TinyMCEValue" value="{{TinyMCE.value}}"/>
27+
</actionGroup>
2628
</before>
2729
<actionGroup ref="AssignBlockToCMSPage" stepKey="assignBlockToCMSPage">
2830
<argument name="Block" value="$$createPreReqBlock$$"/>

0 commit comments

Comments
 (0)