B2B-1789: First Request For Storefront Image After Deleting Local File System Cached Images Results In Magento Placeholder Image When Using S3 -

Changed plugin to around type

Author: avattam06

app/code/Magento/RemoteStorage/Plugin/File/Storage/SynchronizationFactory.php

@@ -8,7 +8,7 @@
 namespace Magento\RemoteStorage\Plugin\File\Storage;
 
 use Magento\RemoteStorage\Model\File\Storage\Synchronization;
-use Magento\MediaStorage\Model\File\Storage\SynchronizationFactory as mediaSynchronizationFactory;
+use Magento\MediaStorage\Model\File\Storage\SynchronizationFactory as MediaSynchronizationFactory;
 use Magento\RemoteStorage\Model\Config;
 use Magento\Framework\ObjectManagerInterface;
 
@@ -44,17 +44,20 @@ public function __construct(ObjectManagerInterface $objectManager, Config $confi
     /**
      * Create remote synchronization instance
      *
-     * @param mediaSynchronizationFactory $subject
+     * @param MediaSynchronizationFactory $subject
+     * @param callable $proceed
      * @param array $data
      * @return mixed
      * @throws \Magento\Framework\Exception\FileSystemException
      * @throws \Magento\Framework\Exception\RuntimeException
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
-    public function beforeCreate(mediaSynchronizationFactory $subject, array $data = [])
+    public function aroundCreate(MediaSynchronizationFactory $subject, callable $proceed, array $data = [])
     {
+        $result = $proceed($data);
         if ($this->config->isEnabled()) {
             return $this->objectManager->create(Synchronization::class, $data);
         }
+        return $result;
     }
 }