MC-20648: Implement the changes

- Renamed Discount Interface to Rule Discount Interface

Author: Prabhu Ram

app/code/Magento/SalesRule/Api/Data/DiscountInterface.php renamed to app/code/Magento/SalesRule/Api/Data/RuleDiscountInterface.php

@@ -8,7 +8,7 @@
 /**
  * @api
  */
-interface DiscountInterface
+interface RuleDiscountInterface
 {
     /**
      * Get Discount Data

app/code/Magento/SalesRule/Model/Data/RuleDiscount.php

@@ -7,12 +7,12 @@
 namespace Magento\SalesRule\Model\Data;
 
 use Magento\SalesRule\Model\Rule\Action\Discount\Data;
-use Magento\SalesRule\Api\Data\DiscountInterface;
+use Magento\SalesRule\Api\Data\RuleDiscountInterface;
 
 /**
  * Data Model for Rule Discount
  */
-class RuleDiscount extends \Magento\Framework\Api\AbstractExtensibleObject implements DiscountInterface
+class RuleDiscount extends \Magento\Framework\Api\AbstractExtensibleObject implements RuleDiscountInterface
 {
     const KEY_DISCOUNT_DATA = 'discount';
     const KEY_RULE_LABEL = 'rule';
@@ -84,7 +84,7 @@ public function setRuleID(string $ruleID)
     /**
      * Retrieve existing extension attributes object or create a new one.
      *
-     * @return DiscountInterface|null
+     * @return RuleDiscountInterface|null
      */
     public function getExtensionAttributes()
     {
@@ -94,11 +94,11 @@ public function getExtensionAttributes()
     /**
      * Set an extension attributes object.
      *
-     * @param DiscountInterface $extensionAttributes
+     * @param RuleDiscountInterface $extensionAttributes
      * @return $this
      */
     public function setExtensionAttributes(
-        DiscountInterface $extensionAttributes
+        RuleDiscountInterface $extensionAttributes
     ) {
         return $this->_setExtensionAttributes($extensionAttributes);
     }

app/code/Magento/SalesRule/Model/Plugin/Discount.php

@@ -9,7 +9,7 @@
 use Magento\SalesRule\Model\Rule\Action\Discount\DataFactory;
 use Magento\Quote\Model\Quote;
 use Magento\Framework\Data\Collection;
-use Magento\SalesRule\Api\Data\DiscountInterfaceFactory;
+use Magento\SalesRule\Api\Data\RuleDiscountInterfaceFactory;
 
 /**
  * Plugin for persisting discounts along with Quote Address
@@ -27,19 +27,19 @@ class Discount
     private $discountFactory;
 
     /**
-     * @var DiscountInterfaceFactory
+     * @var RuleDiscountInterfaceFactory
      */
     private $discountInterfaceFactory;
 
     /**
      * @param Json $json
      * @param DataFactory $discountDataFactory
-     * @param DiscountInterfaceFactory $discountInterfaceFactory
+     * @param RuleDiscountInterfaceFactory $discountInterfaceFactory
      */
     public function __construct(
         Json $json,
         DataFactory $discountDataFactory,
-        DiscountInterfaceFactory $discountInterfaceFactory
+        RuleDiscountInterfaceFactory $discountInterfaceFactory
     ) {
         $this->json = $json;
         $this->discountFactory = $discountDataFactory;

app/code/Magento/SalesRule/Model/Quote/Discount.php

@@ -7,7 +7,7 @@
 
 use Magento\SalesRule\Model\Rule\Action\Discount\DataFactory;
 use Magento\Framework\App\ObjectManager;
-use Magento\SalesRule\Api\Data\DiscountInterfaceFactory;
+use Magento\SalesRule\Api\Data\RuleDiscountInterfaceFactory;
 
 /**
  * Discount totals calculation model.
@@ -46,7 +46,7 @@ class Discount extends \Magento\Quote\Model\Quote\Address\Total\AbstractTotal
     private $discountFactory;
 
     /**
-     * @var DiscountInterfaceFactory
+     * @var RuleDiscountInterfaceFactory
      */
     private $discountInterfaceFactory;
 
@@ -56,15 +56,15 @@ class Discount extends \Magento\Quote\Model\Quote\Address\Total\AbstractTotal
      * @param \Magento\SalesRule\Model\Validator $validator
      * @param \Magento\Framework\Pricing\PriceCurrencyInterface $priceCurrency
      * @param DataFactory|null $discountDataFactory
-     * @param DiscountInterfaceFactory|null $discountInterfaceFactory
+     * @param RuleDiscountInterfaceFactory|null $discountInterfaceFactory
      */
     public function __construct(
         \Magento\Framework\Event\ManagerInterface $eventManager,
         \Magento\Store\Model\StoreManagerInterface $storeManager,
         \Magento\SalesRule\Model\Validator $validator,
         \Magento\Framework\Pricing\PriceCurrencyInterface $priceCurrency,
         DataFactory $discountDataFactory = null,
-        DiscountInterfaceFactory $discountInterfaceFactory = null
+        RuleDiscountInterfaceFactory $discountInterfaceFactory = null
     ) {
         $this->setCode(self::COLLECTOR_TYPE_CODE);
         $this->eventManager = $eventManager;
@@ -73,7 +73,7 @@ public function __construct(
         $this->priceCurrency = $priceCurrency;
         $this->discountFactory = $discountDataFactory ?: ObjectManager::getInstance()->get(DataFactory::class);
         $this->discountInterfaceFactory = $discountInterfaceFactory
-            ?: ObjectManager::getInstance()->get(DiscountInterfaceFactory::class);
+            ?: ObjectManager::getInstance()->get(RuleDiscountInterfaceFactory::class);
     }
 
     /**

app/code/Magento/SalesRule/Model/RulesApplier.php

@@ -12,7 +12,7 @@
 use Magento\SalesRule\Model\ResourceModel\Rule\Collection;
 use Magento\SalesRule\Model\Rule\Action\Discount\CalculatorFactory;
 use Magento\SalesRule\Model\Rule\Action\Discount\DataFactory;
-use Magento\SalesRule\Api\Data\DiscountInterfaceFactory;
+use Magento\SalesRule\Api\Data\RuleDiscountInterfaceFactory;
 
 /**
  * Class RulesApplier
@@ -49,7 +49,7 @@ class RulesApplier
     protected $discountFactory;
 
     /**
-     * @var DiscountInterfaceFactory
+     * @var RuleDiscountInterfaceFactory
      */
     private $discountInterfaceFactory;
 
@@ -64,15 +64,15 @@ class RulesApplier
      * @param Utility $utility
      * @param ChildrenValidationLocator|null $childrenValidationLocator
      * @param DataFactory|null $discountDataFactory
-     * @param DiscountInterfaceFactory|null $discountInterfaceFactory
+     * @param RuleDiscountInterfaceFactory|null $discountInterfaceFactory
      */
     public function __construct(
         \Magento\SalesRule\Model\Rule\Action\Discount\CalculatorFactory $calculatorFactory,
         \Magento\Framework\Event\ManagerInterface $eventManager,
         \Magento\SalesRule\Model\Utility $utility,
         ChildrenValidationLocator $childrenValidationLocator = null,
         DataFactory $discountDataFactory = null,
-        DiscountInterfaceFactory $discountInterfaceFactory = null
+        RuleDiscountInterfaceFactory $discountInterfaceFactory = null
     ) {
         $this->calculatorFactory = $calculatorFactory;
         $this->validatorUtility = $utility;
@@ -81,7 +81,7 @@ public function __construct(
              ?: ObjectManager::getInstance()->get(ChildrenValidationLocator::class);
         $this->discountFactory = $discountDataFactory ?: ObjectManager::getInstance()->get(DataFactory::class);
         $this->discountInterfaceFactory = $discountInterfaceFactory
-            ?: ObjectManager::getInstance()->get(DiscountInterfaceFactory::class);
+            ?: ObjectManager::getInstance()->get(RuleDiscountInterfaceFactory::class);
     }
 
     /**

app/code/Magento/SalesRule/etc/di.xml

@@ -30,7 +30,7 @@
                 type="Magento\SalesRule\Model\Data\CouponMassDeleteResult" />
     <preference for="Magento\SalesRule\Api\CouponManagementInterface"
                 type="Magento\SalesRule\Model\Service\CouponManagementService" />
-    <preference for="Magento\SalesRule\Api\Data\DiscountInterface"
+    <preference for="Magento\SalesRule\Api\Data\RuleDiscountInterface"
                 type="Magento\SalesRule\Model\Data\RuleDiscount" />
     <type name="Magento\SalesRule\Helper\Coupon">
         <arguments>

app/code/Magento/SalesRule/etc/extension_attributes.xml

@@ -7,9 +7,9 @@
 -->
 <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Api/etc/extension_attributes.xsd">
     <extension_attributes for="Magento\Quote\Api\Data\CartItemInterface">
-        <attribute code="discounts" type="Magento\SalesRule\Api\Data\DiscountInterface[]" />
+        <attribute code="discounts" type="Magento\SalesRule\Api\Data\RuleDiscountInterface[]" />
     </extension_attributes>
     <extension_attributes for="Magento\Quote\Api\Data\AddressInterface">
-        <attribute code="discounts" type="Magento\SalesRule\Api\Data\DiscountInterface[]" />
+        <attribute code="discounts" type="Magento\SalesRule\Api\Data\RuleDiscountInterface[]" />
     </extension_attributes>
 </config>