Skip to content

Commit 9656d08

Browse files
committed
MC-21542: Category query does not handle disabled children properly
- image expects model - skip inactive categories
1 parent 7e31850 commit 9656d08

File tree

2 files changed

+12
-10
lines changed

2 files changed

+12
-10
lines changed

app/code/Magento/CatalogGraphQl/Model/Resolver/Category/Image.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ public function resolve(
4141
array $args = null
4242
) {
4343
if (!isset($value['model'])) {
44-
throw new LocalizedException(__('"model" value should be specified'));
44+
return null;
4545
}
4646
/** @var \Magento\Catalog\Model\Category $category */
4747
$category = $value['model'];

app/code/Magento/CatalogGraphQl/Model/Resolver/Products/DataProvider/ExtractDataFromCategoryTree.php

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -52,16 +52,18 @@ public function execute(\Iterator $iterator): array
5252
/** @var CategoryInterface $category */
5353
$category = $iterator->current();
5454
$iterator->next();
55-
$pathElements = explode("/", $category->getPath());
56-
if (empty($tree)) {
57-
$this->startCategoryFetchLevel = count($pathElements) - 1;
55+
if ($category->getIsActive()) {
56+
$pathElements = explode("/", $category->getPath());
57+
if (empty($tree)) {
58+
$this->startCategoryFetchLevel = count($pathElements) - 1;
59+
}
60+
$this->iteratingCategory = $category;
61+
$currentLevelTree = $this->explodePathToArray($pathElements, $this->startCategoryFetchLevel);
62+
if (empty($tree)) {
63+
$tree = $currentLevelTree;
64+
}
65+
$tree = $this->mergeCategoriesTrees($currentLevelTree, $tree);
5866
}
59-
$this->iteratingCategory = $category;
60-
$currentLevelTree = $this->explodePathToArray($pathElements, $this->startCategoryFetchLevel);
61-
if (empty($tree)) {
62-
$tree = $currentLevelTree;
63-
}
64-
$tree = $this->mergeCategoriesTrees($currentLevelTree, $tree);
6567
}
6668
return $tree;
6769
}

0 commit comments

Comments
 (0)