MTA-550: Re-factor Tests for Assign Promoted Products

- Fixed logical and code style errors

Author: Oleksandr Manchenko

dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertProductAbsentCrossSellSection.php

@@ -22,7 +22,7 @@ class AssertProductRelatedProducts extends AbstractConstraint
     /* end tags */
 
     /**
-     * Assert that product is displayed in related products section.
+     * Assert that products are displayed in related products section.
      *
      * @param BrowserInterface $browser
      * @param CatalogProductSimple $product

dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertProductCrossSellSection.php

@@ -22,7 +22,7 @@ class AssertProductUpSells extends AbstractConstraint
     /* end tags */
 
     /**
-     * Assert that product is displayed in up-sell section.
+     * Assert that products are displayed in up-sell section.
      *
      * @param BrowserInterface $browser
      * @param CatalogProductView $catalogProductView

dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertProductRelatedProducts.php

@@ -169,26 +169,26 @@ protected function parsePromotedProducts($promotedProducts)
     }
 
     /**
-     * Convert list steps to array.
+     * Convert list of navigate products to array.
      *
-     * @param string $steps
+     * @param string $navigateProductsOrder
      * @return array
      */
-    protected function parseSteps($steps)
+    protected function parseNavigateProductsOrder($navigateProductsOrder)
     {
-        return array_map('trim', explode(',', $steps));
+        return array_map('trim', explode(',', $navigateProductsOrder));
     }
 
     /**
-     * Convert assert data to array.
+     * Convert products to verify data to array.
      *
-     * @param string $assert
+     * @param string $productsToVerify
      * @return array
      */
-    protected function parseAssert($assert)
+    protected function parseProductsToVerify($productsToVerify)
     {
         $result = [];
-        $list = array_map('trim', explode(';', $assert));
+        $list = array_map('trim', explode(';', $productsToVerify));
 
         foreach ($list as $item) {
             list($step, $products) = array_map('trim', explode(':', $item));