Skip to content

Commit 9613e1f

Browse files
committed
B2B-2530: Unskip GraphQL cache tests skipped due to DEVOPS-4924
- Added fixes on comments
1 parent 604c02b commit 9613e1f

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

dev/tests/api-functional/testsuite/Magento/GraphQl/PageCache/Cms/BlockCacheTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ public function testCacheIsInvalidatedOnBlockUpdate()
105105
);
106106

107107
//cache-debug should be a HIT after update the block on enabled block query
108-
// Verify we obtain a cache HIT the second time on the updated enabled block
108+
// Verify we obtain a cache HIT on the updated enabled block
109109
$this->assertCacheHitAndReturnResponse(
110110
$enabledBlockQuery,
111111
[CacheIdCalculator::CACHE_ID_HEADER => $cacheIdOfEnabledBlock]

dev/tests/api-functional/testsuite/Magento/GraphQl/PageCache/Cms/PageCacheTest.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -124,15 +124,14 @@ public function testCacheIsInvalidatedOnPageUpdate()
124124
$pageBlankQuery,
125125
[CacheIdCalculator::CACHE_ID_HEADER => $cacheIdPageBlankResponse]
126126
);
127-
128-
$page100ResponseHitAfterUpdate = $this->graphQlQueryWithResponseHeaders($page100Query);
127+
129128
$this->assertCacheHitAndReturnResponse(
130129
$page100Query,
131130
[CacheIdCalculator::CACHE_ID_HEADER => $cacheIdPage100Response]
132131
);
133132

134133
//updated page data should be correct
135-
$this->assertNotEmpty($page100ResponseHitAfterUpdate['body']);
134+
$this->assertNotEmpty($pageBlankResponseMissAfterUpdate['body']);
136135
$pageData = $pageBlankResponseMissAfterUpdate['body']['cmsPage'];
137136
$this->assertArrayNotHasKey('errors', $pageBlankResponseMissAfterUpdate['body']);
138137
$this->assertEquals('Cms Page Design Blank', $pageData['title']);

dev/tests/api-functional/testsuite/Magento/GraphQl/PageCache/UrlRewrite/UrlResolverCacheTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ public function testCacheIsInvalidatedForUrlResolver()
137137
$urlResolverQuery,
138138
[CacheIdCalculator::CACHE_ID_HEADER => $cacheIdForUrlResolver]
139139
);
140-
// Verify we obtain a cache HIT the second time
140+
// Verify we obtain a cache HIT the second time
141141
$this->assertCacheHitAndReturnResponse(
142142
$urlResolverQuery,
143143
[CacheIdCalculator::CACHE_ID_HEADER => $cacheIdForUrlResolver]

0 commit comments

Comments
 (0)