Skip to content

Commit 95a14c3

Browse files
author
Valeriy Nayda
committed
Merge branch 'MAGETWO-52535' into PR-5
2 parents 5471bca + 2b7946c commit 95a14c3

File tree

2 files changed

+25
-4
lines changed

2 files changed

+25
-4
lines changed

lib/internal/Magento/Framework/Search/Request/Binder.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,10 @@ private function processData($data, $bindData)
7373
array_walk_recursive($bindData, function (&$item) {
7474
$item = trim($item);
7575
});
76-
$bindData = array_filter($bindData);
76+
$bindData = array_filter($bindData, function ($element) {
77+
return is_array($element) ? count($element) : strlen($element);
78+
});
79+
7780
foreach ($data as $key => $value) {
7881
if (is_array($value)) {
7982
$data[$key] = $this->processData($value, $bindData);

lib/internal/Magento/Framework/Search/Test/Unit/Request/BinderTest.php

Lines changed: 21 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,18 @@ public function testBind()
3434
'queries' => [
3535
'query' => ['value' => '$query$'],
3636
'empty_query' => ['value' => '$empty_query$'],
37-
'space_query' => ['value' => '$space_query$']
37+
'space_query' => ['value' => '$space_query$'],
38+
'zero_value_query' => ['name' => 'zero_value', 'type' => 'filteredQuery'],
39+
],
40+
'filters' => [
41+
'filter' => ['from' => '$from$', 'to' => '$to$', 'value' => '$filter$'],
42+
'zero_value_filter' => [
43+
'type' => 'termFilter',
44+
'name' => 'zero_value',
45+
'field' => 'zero_value',
46+
'value' => '$zero_value$',
47+
],
3848
],
39-
'filters' => ['filter' => ['from' => '$from$', 'to' => '$to$', 'value' => '$filter$']],
4049
'aggregations' => ['price' => ['method' => '$method$']],
4150
'from' => 0,
4251
'size' => 15,
@@ -51,6 +60,7 @@ public function testBind()
5160
'$to$' => 'filter_to',
5261
'$filter$' => 'filter_value',
5362
'$method$' => 'filter_method',
63+
'$zero_value$' => '0',
5464
],
5565
'from' => 1,
5666
'size' => 10,
@@ -60,14 +70,22 @@ public function testBind()
6070
'queries' => [
6171
'query' => ['value' => 'match_query', 'is_bind' => true],
6272
'empty_query' => ['value' => '$empty_query$'],
63-
'space_query' => ['value' => 'value', 'is_bind' => true]
73+
'space_query' => ['value' => 'value', 'is_bind' => true],
74+
'zero_value_query' => ['name' => 'zero_value', 'type' => 'filteredQuery'],
6475
],
6576
'filters' => [
6677
'filter' => [
6778
'from' => 'filter_from',
6879
'to' => 'filter_to',
6980
'value' => 'filter_value',
7081
'is_bind' => true
82+
],
83+
'zero_value_filter' => [
84+
'type' => 'termFilter',
85+
'name' => 'zero_value',
86+
'field' => 'zero_value',
87+
'value' => '0',
88+
'is_bind' => true,
7189
]
7290
],
7391
'aggregations' => ['price' => ['method' => 'filter_method', 'is_bind' => true]],

0 commit comments

Comments
 (0)