MAGETWO-44459: Check javascript function calls and labels are translatable

 - added missing translation phrases to i18n files
 - added translate attribute to xml template files
 - modified layout & attribute processors to translate fields whose values are loaded from attribute sets in the database

Author: Cari Spruiell

app/code/Magento/Backend/Block/Widget/Form.php

@@ -187,7 +187,7 @@ protected function _setFieldset($attributes, $fieldset, $exclude = [])
                     $fieldType,
                     [
                         'name' => $attribute->getAttributeCode(),
-                        'label' => $attribute->getFrontend()->getLabel(),
+                        'label' => __($attribute->getFrontend()->getLabel()),
                         'class' => $attribute->getFrontend()->getClass(),
                         'required' => $attribute->getIsRequired(),
                         'note' => $attribute->getNote()

app/code/Magento/Backend/i18n/de_DE.csv

@@ -606,3 +606,4 @@ Tags,Tags
 Options,Options
 "Magento Admin","Magento Admin"
 "Community Edition","Community Edition"
+"VAT number","VAT number"

app/code/Magento/Backend/i18n/en_US.csv

@@ -606,3 +606,4 @@ Tags,Tags
 Options,Options
 "Magento Admin","Magento Admin"
 "Community Edition","Community Edition"
+"VAT number","VAT number"

app/code/Magento/Backend/i18n/es_ES.csv

@@ -606,3 +606,4 @@ Tags,Tags
 Options,Options
 "Magento Admin","Magento Admin"
 "Community Edition","Community Edition"
+"VAT number","VAT number"

app/code/Magento/Backend/i18n/fr_FR.csv

@@ -606,3 +606,4 @@ Tags,Tags
 Options,Options
 "Magento Admin","Magento Admin"
 "Community Edition","Community Edition"
+"VAT number","VAT number"

app/code/Magento/Backend/i18n/nl_NL.csv

@@ -606,3 +606,4 @@ Tags,Tags
 Options,Options
 "Magento Admin","Magento Admin"
 "Community Edition","Community Edition"
+"VAT number","VAT number"

app/code/Magento/Backend/i18n/pt_BR.csv

@@ -606,3 +606,4 @@ Tags,Tags
 Options,Options
 "Magento Admin","Magento Admin"
 "Community Edition","Community Edition"
+"VAT number","VAT number"

app/code/Magento/Backend/i18n/zh_Hans_CN.csv

@@ -606,3 +606,4 @@ Tags,Tags
 Options,Options
 "Magento Admin","Magento Admin"
 "Community Edition","Community Edition"
+"VAT number","VAT number"

app/code/Magento/Catalog/Block/Product/View/Attributes.php

@@ -88,7 +88,7 @@ public function getAdditionalData(array $excludeAttr = [])
 
                 if (is_string($value) && strlen($value)) {
                     $data[$attribute->getAttributeCode()] = [
-                        'label' => $attribute->getStoreLabel(),
+                        'label' => __($attribute->getStoreLabel()),
                         'value' => $value,
                         'code' => $attribute->getAttributeCode(),
                     ];

app/code/Magento/Catalog/etc/adminhtml/di.xml

@@ -16,19 +16,19 @@
         <arguments>
             <argument name="imageTypes" xsi:type="array">
                 <item name="small" xsi:type="array">
-                    <item name="title" xsi:type="string">Small</item>
+                    <item name="title" xsi:type="string" translate="true">Small</item>
                     <item name="attribute" xsi:type="string">small_image</item>
                 </item>
                 <item name="main" xsi:type="array">
-                    <item name="title" xsi:type="string">Main</item>
+                    <item name="title" xsi:type="string" translate="true">Main</item>
                     <item name="attribute" xsi:type="string">image</item>
                 </item>
                 <item name="cart" xsi:type="array">
-                    <item name="title" xsi:type="string">Thumbnail</item>
+                    <item name="title" xsi:type="string" translate="true">Thumbnail</item>
                     <item name="attribute" xsi:type="string">thumbnail</item>
                 </item>
                 <item name="custom" xsi:type="array">
-                    <item name="title" xsi:type="string">Custom image</item>
+                    <item name="title" xsi:type="string" translate="true">Custom image</item>
                     <item name="attribute" xsi:type="string">custom_image</item>
                 </item>
             </argument>