MAGETWO-59555: Mass Actions are slow

- Added code to fix build failures
- Fixed unit tests

Author: abarua17

app/code/Magento/Ui/Component/MassAction/Filter.php

@@ -88,6 +88,17 @@ public function getComponent()
      */
     public function getCollection(AbstractDb $collection)
     {
+        $selected = $this->request->getParam(static::SELECTED_PARAM);
+        $excluded = $this->request->getParam(static::EXCLUDED_PARAM);
+
+        $isExcludedIdsValid = (is_array($excluded) && !empty($excluded));
+        $isSelectedIdsValid = (is_array($selected) && !empty($selected));
+
+        if ('false' !== $excluded) {
+            if (!$isExcludedIdsValid && !$isSelectedIdsValid) {
+                throw new LocalizedException(__('Please select item(s).'));
+            }
+        }
         $idsArray = $this->getFilterIds();
         if (!empty($idsArray)) {
             $collection->addFieldToFilter(

app/code/Magento/Ui/Test/Unit/Component/MassAction/FilterTest.php

@@ -134,10 +134,10 @@ public function testApplySelectionOnTargetProvider($selectedIds, $excludedIds, $
     public function applySelectionOnTargetProviderDataProvider()
     {
         return [
-            [[1, 2, 3], false , 1, 'in'],
+            [[1, 2, 3], 'false' , 0, 'in'],
             [[1, 2, 3], [1, 2, 3] , 1, 'nin'],
-            [false, [1, 2, 3] , 1, 'nin'],
-            [false, false , 0, '']
+            ['false', [1, 2, 3] , 1, 'nin'],
+            ['false', 'false' , 0, '']
         ];
     }
 
@@ -184,10 +184,18 @@ public function testApplySelectionOnTargetProviderException()
     public function testGetCollection($selectedIds, $excludedIds, $filterExpected, $conditionExpected)
     {
         $this->setUpApplySelection($selectedIds, $excludedIds, $filterExpected, $conditionExpected);
-        $this->requestMock->expects($this->at(2))
+        $this->requestMock->expects($this->at(4))
             ->method('getParam')
             ->with('namespace')
             ->willReturn('');
+        $this->requestMock->expects($this->at(2))
+            ->method('getParam')
+            ->with(Filter::SELECTED_PARAM)
+            ->willReturn($selectedIds);
+        $this->requestMock->expects($this->at(3))
+            ->method('getParam')
+            ->with(Filter::EXCLUDED_PARAM)
+            ->willReturn($excludedIds);
         $this->assertEquals($this->abstractDbMock, $this->filter->getCollection($this->abstractDbMock));
     }