MAGETWO-15418: Sold products aren't displayed in Bestsellers

- Moved selectors to separate properties in Ordered class;

Author: Dmytro Poperechnyy

dev/tests/functional/tests/app/Magento/Backend/Test/Block/Dashboard/Tab/Products/Ordered.php

@@ -15,6 +15,20 @@
  */
 class Ordered extends Grid
 {
+    /**
+     * Base part of row locator template
+     *
+     * @var string
+     */
+    protected $location = '//table[@id="productsOrderedGrid_table"]/tbody/tr';
+
+    /**
+     * Secondary part of row locator template
+     *
+     * @var string
+     */
+    protected $rowTemplate = 'td[contains(., "%s")]';
+
     /**
      * Check if ordered product is in grid
      *
@@ -23,19 +37,17 @@ class Ordered extends Grid
      */
     public function isProductVisible(CatalogProductSimple $product)
     {
-        $location = '//table[@id="productsOrderedGrid_table"]/tbody/tr[';
-        $rowTemplate = 'td[contains(., "%s")]';
         $filter = [
             $product->getName(),
             $product->getPrice(),
             $product->getCheckoutData()['qty'],
         ];
         $rows = [];
         foreach ($filter as $value) {
-            $rows[] = sprintf($rowTemplate, $value);
+            $rows[] = sprintf($this->rowTemplate, $value);
         }
-        $location = $location . implode(' and ', $rows) . ']';
+        $location = $this->location . '[' . implode(' and ', $rows) . ']';
 
-        return $this->_rootElement->find($location, Locator::SELECTOR_XPATH)->isVisible() ? true : false;
+        return $this->_rootElement->find($location, Locator::SELECTOR_XPATH)->isVisible();
     }
 }