File content extracted to a separate var. Type hinting, strict comparison

Author: rogyar

lib/internal/Magento/Framework/App/Response/Http/FileFactory.php

@@ -59,6 +59,7 @@ public function create(
         $dir = $this->_filesystem->getDirectoryWrite($baseDir);
         $isFile = false;
         $file = null;
+        $fileContent = $this->getFileContent($content);
         if (is_array($content)) {
             if (!isset($content['type']) || !isset($content['value'])) {
                 throw new \InvalidArgumentException("Invalid arguments. Keys 'type' and 'value' are required.");
@@ -76,11 +77,7 @@ public function create(
             ->setHeader('Pragma', 'public', true)
             ->setHeader('Cache-Control', 'must-revalidate, post-check=0, pre-check=0', true)
             ->setHeader('Content-type', $contentType, true)
-            ->setHeader(
-                'Content-Length',
-                $contentLength === null ? strlen($this->getFileContent($content)) : $contentLength,
-                true
-            )
+            ->setHeader('Content-Length', $contentLength === null ? strlen($fileContent) : $contentLength, true)
             ->setHeader('Content-Disposition', 'attachment; filename="' . $fileName . '"', true)
             ->setHeader('Last-Modified', date('r'), true);
 
@@ -92,7 +89,7 @@ public function create(
                     echo $stream->read(1024);
                 }
             } else {
-                $dir->writeFile($fileName, $this->getFileContent($content));
+                $dir->writeFile($fileName, $fileContent);
                 $file = $fileName;
                 $stream = $dir->openFile($fileName, 'r');
                 while (!$stream->eof()) {
@@ -114,9 +111,9 @@ public function create(
      * @param string|array $content
      * @return string
      */
-    private function getFileContent($content)
+    private function getFileContent($content): string
     {
-        if (isset($content['type']) && $content['type'] == 'string') {
+        if (isset($content['type']) && $content['type'] === 'string') {
             return $content['value'];
         }