Skip to content

Commit 9311e5b

Browse files
committed
ACP2E-1714: Wrong Order Status for Bundle Product Partial Credit memo
- fix - modify test
1 parent c766d6c commit 9311e5b

File tree

3 files changed

+16
-2
lines changed

3 files changed

+16
-2
lines changed

app/code/Magento/Sales/Model/Order.php

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
*/
66
namespace Magento\Sales\Model;
77

8+
use Magento\Catalog\Model\Product\Type;
89
use Magento\Config\Model\Config\Source\Nooptreq;
910
use Magento\Directory\Model\Currency;
1011
use Magento\Directory\Model\RegionFactory;
@@ -197,7 +198,8 @@ class Order extends AbstractModel implements EntityInterface, OrderInterface
197198

198199
/**
199200
* @var \Magento\Catalog\Api\ProductRepositoryInterface
200-
* @deprecated 100.1.0 Remove unused dependency.
201+
* @deprecated 100.1.0
202+
* @see Remove unused dependency
201203
*/
202204
protected $productRepository;
203205

@@ -831,7 +833,10 @@ public function canShip()
831833
}
832834

833835
foreach ($this->getAllItems() as $item) {
834-
if ($item->getQtyToShip() > 0 && !$item->getIsVirtual() &&
836+
$qtyToShip = !$item->getParentItem() || $item->getParentItem()->getProductType() !== Type::TYPE_BUNDLE ?
837+
$item->getQtyToShip() : $item->getSimpleQtyToShip();
838+
839+
if ($qtyToShip > 0 && !$item->getIsVirtual() &&
835840
!$item->getLockedDoShip() && !$this->isRefunded($item)) {
836841
return true;
837842
}

app/code/Magento/Sales/Test/Mftf/Test/AdminCreateCreditMemoPartialRefundTest.xml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,10 @@
9090
<!-- Assert Credit Memo button -->
9191
<seeElement selector="{{AdminOrderFormItemsSection.creditMemo}}" stepKey="assertCreditMemoButton"/>
9292

93+
<actionGroup ref="AdminOrderViewCheckStatusActionGroup" stepKey="seeAdminOrderStatus">
94+
<argument name="status" value="{{OrderStatus.processing}}"/>
95+
</actionGroup>
96+
9397
<!--Assert refund in Credit Memo Tab-->
9498
<click selector="{{AdminOrderDetailsOrderViewSection.creditMemos}}" stepKey="clickCreditMemoTab"/>
9599
<waitForPageLoad stepKey="waitForTabLoad"/>

app/code/Magento/Sales/Test/Mftf/Test/AdminCreateCreditmemoWithBundleProductTest.xml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,11 +94,16 @@
9494

9595
<actionGroup ref="AdminOpenCreditMemoFromOrderPageActionGroup" stepKey="openCreditMemo" />
9696
<scrollTo selector="{{AdminCreditMemoViewTotalSection.subtotal}}" stepKey="scrollToTotal"/>
97+
98+
<!-- Perform asserts -->
9799
<actionGroup ref="AssertAdminCreditMemoViewPageTotalsActionGroup" stepKey="assertCreditMemoViewPageTotals">
98100
<argument name="subtotal" value="$0.00"/>
99101
<argument name="adjustmentRefund" value="$10.00"/>
100102
<argument name="adjustmentFee" value="$0.00"/>
101103
<argument name="grandTotal" value="$10.00"/>
102104
</actionGroup>
105+
<actionGroup ref="AdminOrderViewCheckStatusActionGroup" stepKey="AssertAdminOrderStatus">
106+
<argument name="status" value="{{OrderStatus.processing}}"/>
107+
</actionGroup>
103108
</test>
104109
</tests>

0 commit comments

Comments
 (0)