ACP2E-92: Credit memo with decimal qty could be created via API even in case decimal qty disabled

Author: glo23503

app/code/Magento/Sales/Model/Order/Creditmemo/Validation/QuantityValidator.php

@@ -83,6 +83,14 @@ public function validate($entity)
             }
             $orderItem = $orderItemsById[$item->getOrderItemId()];
 
+            if ($this->isValidRefundQty($orderItem->getIsQtyDecimal(), $item->getQty())) {
+                $messages[] =__(
+                    'You cannot use decimal quantity to refund item "%1".',
+                    $item->getSku()
+                );
+                continue;
+            }
+
             if (!$this->canRefundItem($orderItem, $item->getQty(), $invoiceQtysRefundLimits) ||
                 !$this->isQtyAvailable($orderItem, $item->getQty())
             ) {
@@ -105,6 +113,21 @@ public function validate($entity)
         return $messages;
     }
 
+    /**
+     * to check the refund qty is decimal if getIsQtyDecimal is unset.
+     *
+     * @param int|null $isQtyDecimal
+     * @param float $itemQty
+     * @return bool
+     */
+    private function isValidRefundQty($isQtyDecimal, float $itemQty): bool
+    {
+        if (!$isQtyDecimal && (floor($itemQty) !== $itemQty)) {
+            return true;
+        }
+        return false;
+    }
+
     /**
      * We can have problem with float in php (on some server $a=762.73;$b=762.73; $a-$b!=0)
      * for this we have additional diapason for 0

app/code/Magento/Sales/i18n/en_US.csv

@@ -806,3 +806,4 @@ If set YES Email field will be required during Admin order creation for new Cust
 "The coupon code has been removed.","The coupon code has been removed."
 "This creditmemo no longer exists.","This creditmemo no longer exists."
 "Add to address book","Add to address book"
+"You cannot use decimal quantity to refund item","You cannot use decimal quantity to refund item"