Skip to content

Commit 92ed498

Browse files
committed
MTA-3333: Deliver functional test fixes that were made during regression testing
1 parent 901637a commit 92ed498

File tree

4 files changed

+38
-4
lines changed

4 files changed

+38
-4
lines changed

dev/tests/functional/lib/Magento/Mtf/Client/Element/SwitcherElement.php

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@
66

77
namespace Magento\Mtf\Client\Element;
88

9+
use Magento\Mtf\Client\Locator;
10+
911
/**
1012
* Toggle element in the backend.
1113
* Switches value between YES and NO.
@@ -19,6 +21,13 @@ class SwitcherElement extends SimpleElement
1921
*/
2022
protected $parentContainer = 'parent::div[@data-role="switcher"]';
2123

24+
/**
25+
* XPath selector for label text on swticher element.
26+
*
27+
* @var string
28+
*/
29+
private $labelText = './following-sibling::label';
30+
2231
/**
2332
* Set value to Yes or No.
2433
*
@@ -33,7 +42,7 @@ public function setValue($value)
3342
);
3443
}
3544
if ($value != $this->getValue()) {
36-
$this->click();
45+
$this->find($this->labelText, Locator::SELECTOR_XPATH)->click();
3746
}
3847
}
3948

dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Adminhtml/Product/Edit/Section/AdvancedInventory.php

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,4 +61,27 @@ public function getFieldsData($fields = null, SimpleElement $element = null)
6161

6262
return $data;
6363
}
64+
65+
/**
66+
* Get data of specified form data.
67+
*
68+
* @param array $fields
69+
* @param SimpleElement|null $element
70+
* @return array
71+
*/
72+
protected function _getData(array $fields, SimpleElement $element = null)
73+
{
74+
$data = [];
75+
$context = ($element === null) ? $this->_rootElement : $element;
76+
foreach ($fields as $key => $field) {
77+
if (!isset($field['value'])) {
78+
$data[$key] = $this->_getData($field, $context);
79+
} else {
80+
$element = $this->getElement($context, $field);
81+
$data[$key] = $element->getValue();
82+
}
83+
}
84+
85+
return $data;
86+
}
6487
}

dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Adminhtml/Product/Edit/Section/Options/Type.php

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,11 @@ class Type extends OptgroupselectElement
4949
*/
5050
protected function getData(ElementInterface $element)
5151
{
52-
$this->find($this->advancedSelect)->click();
53-
return trim($element->getText());
52+
$element = $this->find($this->advancedSelect);
53+
$element->click();
54+
$text = trim($element->getText());
55+
$element->click();
56+
return $text;
5457
}
5558

5659
/**

dev/tests/functional/tests/app/Magento/Cms/Test/Block/Adminhtml/Page/Edit/PageForm.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
<fields>
1414
<title />
1515
<is_active>
16-
<selector>.admin__actions-switch-label</selector>
1716
<input>switcher</input>
1817
</is_active>
1918
</fields>

0 commit comments

Comments
 (0)