MAGETWO-85581: Enable metrics validation and run benchmark in multithread mode for PAT

Author: slopukhov

app/code/Magento/Catalog/Model/Product/Image.php

@@ -883,7 +883,6 @@ protected function _fileExists($filename)
      */
     public function getResizedImageInfo()
     {
-        $errorMessage = 'Can\'t get information about the picture: ';
         try {
             if ($this->isBaseFilePlaceholder() == true) {
                 $image = $this->imageAsset->getSourceFile();
@@ -896,7 +895,7 @@ public function getResizedImageInfo()
             return $imageProperties;
         } finally {
             if (empty($imageProperties)) {
-                throw new NotLoadInfoImageException(__($errorMessage . $image));
+                throw new NotLoadInfoImageException(__('Can\'t get information about the picture: %1', $image));
             }
         }
     }

app/code/Magento/Catalog/Model/Product/Image/NotLoadInfoImageException.php

@@ -5,12 +5,6 @@
  */
 namespace Magento\Catalog\Model\Product\Image;
 
-use Magento\Framework\Exception\LocalizedException;
-
-/**
- * @api
- * @since 102.0.0
- */
-class NotLoadInfoImageException extends LocalizedException
+class NotLoadInfoImageException extends \Exception
 {
 }

dev/tests/integration/testsuite/Magento/Setup/Fixtures/FixtureModelTest.php

@@ -118,7 +118,7 @@ public function testFixtureGeneration()
 
         foreach ($this->entityAsserts as $entityAssert) {
             try {
-                $entityAssert->assert();
+                $this->assertTrue($entityAssert->assert());
             } catch (\AssertionError $assertionError) {
                 $this->assertTrue(false, $assertionError->getMessage());
             }

dev/tests/integration/testsuite/Magento/Setup/Fixtures/FixturesAsserts/BundleProductsAssert.php

@@ -48,7 +48,7 @@ public function __construct(
     /**
      * Asserts that generated bundled products are valid
      *
-     * @return void
+     * @return bool
      * @throws \Magento\Framework\Exception\NoSuchEntityException
      * @throws \AssertionError
      */
@@ -74,5 +74,7 @@ public function assert()
                 throw new \AssertionError('Bundle option product links amount is wrong');
             }
         }
+
+        return true;
     }
 }

dev/tests/integration/testsuite/Magento/Setup/Fixtures/FixturesAsserts/ConfigurableProductsAssert.php

@@ -46,7 +46,7 @@ public function __construct(
     /**
      * Asserts that generated configurable products are valid
      *
-     * @return void
+     * @return bool
      * @throws \Magento\Framework\Exception\NoSuchEntityException
      * @throws \Magento\Framework\Exception\InputException
      * @throws \AssertionError
@@ -86,5 +86,7 @@ public function assert()
                 throw new \AssertionError('Configurable option values amount is wrong');
             }
         }
+
+        return true;
     }
 }

dev/tests/integration/testsuite/Magento/Setup/Fixtures/FixturesAsserts/ImagesAssert.php

@@ -70,6 +70,7 @@ public function __construct(
     /**
      * Performs assertions over images
      *
+     * @return bool
      * @throws \AssertionError
      */
     public function assert()
@@ -82,6 +83,8 @@ public function assert()
             $this->assertProductMediaAttributes($product);
             $this->assertProductImageExistsInFS($product);
         }
+
+        return true;
     }
 
     /**

dev/tests/integration/testsuite/Magento/Setup/Fixtures/FixturesAsserts/SimpleProductsAssert.php

@@ -43,7 +43,7 @@ public function __construct(
     /**
      * Asserts that generated simple products are valid
      *
-     * @return void
+     * @return bool
      * @throws \Magento\Framework\Exception\NoSuchEntityException
      * @throws \AssertionError
      */
@@ -52,5 +52,7 @@ public function assert()
         $product = $this->productRepository->get(sprintf(SimpleProductsFixture::SKU_PATTERN, 1));
         $this->productAssert->assertProductsCount(SimpleProductsFixture::SKU_PATTERN, 2);
         $this->productAssert->assertProductType('simple', $product);
+
+        return true;
     }
 }

dev/tests/static/testsuite/Magento/Test/Integrity/_files/blacklist/exception_hierarchy.txt

@@ -9,3 +9,4 @@
 \Magento\Framework\DB\Adapter\DuplicateException
 \Magento\Framework\DB\DataConverter\DataConversionException
 \Magento\Framework\DB\FieldDataConversionException
+\Magento\Catalog\Model\Product\Image\NotLoadInfoImageException

setup/src/Magento/Setup/Console/Command/GenerateFixturesCommand.php

@@ -17,6 +17,7 @@
 
 /**
  * Command generates fixtures for performance tests
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class GenerateFixturesCommand extends Command
 {
@@ -84,7 +85,8 @@ protected function execute(InputInterface $input, OutputInterface $output)
             }
 
             /** @var \Magento\Setup\Fixtures\ConfigsApplyFixture $configFixture */
-            $configFixture = $fixtureModel->getConfigurationFixture();
+            $configFixture = $fixtureModel
+                ->getFixtureByName(\Magento\Setup\Fixtures\ConfigsApplyFixture::class);
             $configFixture && $this->executeFixture($configFixture, $output);
 
             /** @var $config \Magento\Indexer\Model\Config */
@@ -106,7 +108,8 @@ protected function execute(InputInterface $input, OutputInterface $output)
             $this->clearChangelog();
 
             /** @var \Magento\Setup\Fixtures\IndexersStatesApplyFixture $indexerFixture */
-            $indexerFixture = $this->fixtureModel->getIndexerFixture();
+            $indexerFixture = $fixtureModel
+                ->getFixtureByName(\Magento\Setup\Fixtures\IndexersStatesApplyFixture::class);
             $indexerFixture && $this->executeFixture($indexerFixture, $output);
 
             if (!$input->getOption(self::SKIP_REINDEX_OPTION)) {

setup/src/Magento/Setup/Fixtures/ConfigsApplyFixture.php

@@ -14,7 +14,7 @@ class ConfigsApplyFixture extends Fixture
     /**
      * @var int
      */
-    protected $priority = 0;
+    protected $priority = -1;
 
     /**
      * {@inheritdoc}