Skip to content

Commit 91d4891

Browse files
committed
Merge remote-tracking branch 'trigger/MAGETWO-95534' into BugFixPR
2 parents cdf3ac0 + 0b52588 commit 91d4891

File tree

1 file changed

+17
-2
lines changed
  • dev/tests/integration/testsuite/Magento/Cms/Model

1 file changed

+17
-2
lines changed

dev/tests/integration/testsuite/Magento/Cms/Model/PageTest.php

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
namespace Magento\Cms\Model;
77

88
use Magento\Cms\Api\PageRepositoryInterface;
9+
use Magento\Framework\App\ResourceConnection;
910
use Magento\Framework\Stdlib\DateTime\DateTime;
1011

1112
/**
@@ -79,13 +80,27 @@ public function testGenerateIdentifierFromTitle($data, $expectedIdentifier)
7980
public function testUpdateTime()
8081
{
8182
$objectManager = \Magento\TestFramework\Helper\Bootstrap::getObjectManager();
83+
84+
/**
85+
* @var $db \Magento\Framework\DB\Adapter\AdapterInterface
86+
*/
87+
$db = $objectManager->get(\Magento\Framework\App\ResourceConnection::class)
88+
->getConnection(ResourceConnection::DEFAULT_CONNECTION);
89+
8290
/** @var \Magento\Cms\Model\Page $page */
8391
$page = $objectManager->create(\Magento\Cms\Model\Page::class);
8492
$page->setData(['title' => 'Test', 'stores' => [1]]);
93+
$beforeTimestamp = $db->fetchCol('SELECT UNIX_TIMESTAMP()')[0];
8594
$page->save();
95+
$afterTimestamp = $db->fetchCol('SELECT UNIX_TIMESTAMP()')[0];
8696
$page = $objectManager->get(PageRepositoryInterface::class)->getById($page->getId());
87-
$date = $objectManager->get(DateTime::class)->date();
88-
$this->assertEquals($date, $page->getUpdateTime());
97+
$pageTimestamp = strtotime($page->getUpdateTime());
98+
99+
/*
100+
* These checks prevent a race condition MAGETWO-95534
101+
*/
102+
$this->assertGreaterThanOrEqual($beforeTimestamp, $pageTimestamp);
103+
$this->assertLessThanOrEqual($afterTimestamp, $pageTimestamp);
89104
}
90105

91106
public function generateIdentifierFromTitleDataProvider() : array

0 commit comments

Comments
 (0)