MC-21347: Remove Customer module's dependency on Review

Author: SeruyV

app/code/Magento/Customer/Block/Account/Dashboard.php

@@ -129,16 +129,6 @@ public function getOrdersUrl()
         return '';
     }
 
-    /**
-     * Retrieve the Url for customer reviews.
-     *
-     * @return string
-     */
-    public function getReviewsUrl()
-    {
-        return $this->_urlBuilder->getUrl('review/customer/index', ['_secure' => true]);
-    }
-
     /**
      * Retrieve the Url for managing customer wishlist.
      *

app/code/Magento/Customer/Controller/Review.php

@@ -6,9 +6,16 @@
 namespace Magento\Customer\Controller;
 
 use Magento\Framework\App\Action\Context;
+use Magento\Framework\App\Action\HttpGetActionInterface;
 use Magento\Framework\View\Result\PageFactory;
 
-class Review extends \Magento\Framework\App\Action\Action
+/**
+ * Deprecated class which was in use as general class in Customer Account "My Product Reviews" tab.
+ *
+ * @deprecated Remove Customer module's dependency on Review. Non-used class.
+ * @see \Magento\Review\Controller\Customer
+ */
+class Review extends \Magento\Framework\App\Action\Action implements HttpGetActionInterface
 {
     /**
      * @var PageFactory
@@ -28,6 +35,8 @@ public function __construct(
     }
 
     /**
+     * Main page in Customer Account "My Product Reviews" tab.
+     *
      * @return \Magento\Framework\View\Result\Page
      */
     public function execute()

app/code/Magento/Customer/Controller/Review/Index.php

@@ -6,6 +6,14 @@
  */
 namespace Magento\Customer\Controller\Review;
 
-class Index extends \Magento\Customer\Controller\Review
+use Magento\Framework\App\Action\HttpGetActionInterface;
+
+/**
+ * Deprecated class which was in use as main page in Customer Account "My Product Reviews" tab.
+ *
+ * @deprecated Remove Customer module's dependency on Review. Non-used class.
+ * @see \Magento\Review\Controller\Customer\Index
+ */
+class Index extends \Magento\Customer\Controller\Review implements HttpGetActionInterface
 {
 }

app/code/Magento/Customer/Controller/Review/View.php

@@ -6,6 +6,14 @@
  */
 namespace Magento\Customer\Controller\Review;
 
-class View extends \Magento\Customer\Controller\Review
+use Magento\Framework\App\Action\HttpGetActionInterface;
+
+/**
+ * Deprecated class which was in use as view page in Customer Account "My Product Reviews" tab.
+ *
+ * @deprecated Remove Customer module's dependency on Review. Non-used class.
+ * @see \Magento\Review\Controller\Customer\View
+ */
+class View extends \Magento\Customer\Controller\Review implements HttpGetActionInterface
 {
 }

app/code/Magento/Customer/composer.json

@@ -19,7 +19,6 @@
         "magento/module-newsletter": "*",
         "magento/module-page-cache": "*",
         "magento/module-quote": "*",
-        "magento/module-review": "*",
         "magento/module-sales": "*",
         "magento/module-store": "*",
         "magento/module-tax": "*",

app/code/Magento/Customer/Block/Adminhtml/Edit/Tab/Reviews.php renamed to app/code/Magento/Review/Block/Adminhtml/Edit/Tab/Reviews.php

@@ -3,18 +3,21 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
-namespace Magento\Customer\Block\Adminhtml\Edit\Tab;
+declare(strict_types=1);
+
+namespace Magento\Review\Block\Adminhtml\Edit\Tab;
 
 /**
+ * Review tab in adminhtml area.
+ *
  * @api
- * @since 100.0.2
  */
 class Reviews extends \Magento\Review\Block\Adminhtml\Grid
 {
     /**
-     * Hide grid mass action elements
+     * Hide grid mass action elements.
      *
-     * @return \Magento\Customer\Block\Adminhtml\Edit\Tab\Reviews
+     * @return \Magento\Review\Block\Adminhtml\Edit\Tab\Reviews
      */
     protected function _prepareMassaction()
     {
@@ -28,6 +31,6 @@ protected function _prepareMassaction()
      */
     public function getGridUrl()
     {
-        return $this->getUrl('customer/*/productReviews', ['_current' => true]);
+        return $this->getUrl('review/customer/productReviews', ['_current' => true]);
     }
 }

app/code/Magento/Review/Block/Adminhtml/ReviewTab.php

@@ -11,9 +11,7 @@
 use Magento\Ui\Component\Layout\Tabs\TabWrapper;
 
 /**
- * Class ReviewTab
- *
- * @package Magento\Review\Block\Adminhtml
+ * Review tab block.
  */
 class ReviewTab extends TabWrapper
 {
@@ -30,8 +28,6 @@ class ReviewTab extends TabWrapper
     protected $isAjaxLoaded = true;
 
     /**
-     * Constructor
-     *
      * @param Context $context
      * @param Registry $registry
      * @param array $data
@@ -67,6 +63,6 @@ public function getTabLabel()
      */
     public function getTabUrl()
     {
-        return $this->getUrl('customer/*/productReviews', ['_current' => true]);
+        return $this->getUrl('review/customer/productReviews', ['_current' => true]);
     }
 }

app/code/Magento/Customer/Controller/Adminhtml/Index/ProductReviews.php renamed to app/code/Magento/Review/Controller/Adminhtml/Customer/ProductReviews.php

@@ -3,21 +3,29 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
-namespace Magento\Customer\Controller\Adminhtml\Index;
+declare(strict_types=1);
 
-class ProductReviews extends \Magento\Customer\Controller\Adminhtml\Index
+namespace Magento\Review\Controller\Adminhtml\Customer;
+
+use Magento\Framework\App\Action\HttpPostActionInterface;
+
+/**
+ * Customer product reviews page.
+ */
+class ProductReviews extends \Magento\Customer\Controller\Adminhtml\Index implements HttpPostActionInterface
 {
     /**
-     * Get customer's product reviews list
+     * Get customer's product reviews list.
      *
      * @return \Magento\Framework\View\Result\Layout
      */
     public function execute()
     {
-        $customerId = $this->initCurrentCustomer();
+        $customerId = (int)$this->initCurrentCustomer();
         $resultLayout = $this->resultLayoutFactory->create();
         $block = $resultLayout->getLayout()->getBlock('admin.customer.reviews');
         $block->setCustomerId($customerId)->setUseAjax(true);
+
         return $resultLayout;
     }
 }

app/code/Magento/Customer/view/adminhtml/layout/customer_index_productreviews.xml renamed to app/code/Magento/Review/view/adminhtml/layout/review_customer_productreviews.xml

@@ -7,6 +7,6 @@
 -->
 <layout xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:View/Layout/etc/layout_generic.xsd">
     <container name="root" label="Root">
-        <block class="Magento\Customer\Block\Adminhtml\Edit\Tab\Reviews" name="admin.customer.reviews"/>
+        <block class="Magento\Review\Block\Adminhtml\Edit\Tab\Reviews" name="admin.customer.reviews"/>
     </container>
 </layout>

dev/tests/integration/testsuite/Magento/Customer/Controller/Adminhtml/IndexTest.php

@@ -437,17 +437,6 @@ public function testCartAction()
         $this->assertContains('<div id="customer_cart_grid1"', $body);
     }
 
-    /**
-     * @magentoDataFixture Magento/Customer/_files/customer_sample.php
-     */
-    public function testProductReviewsAction()
-    {
-        $this->getRequest()->setParam('id', 1);
-        $this->dispatch('backend/customer/index/productReviews');
-        $body = $this->getResponse()->getBody();
-        $this->assertContains('<div id="reviwGrid"', $body);
-    }
-
     /**
      * @magentoDataFixture Magento/Customer/_files/customer.php
      * @magentoDataFixture Magento/Customer/_files/customer_address.php