Skip to content

Commit 916c4db

Browse files
committed
Merge remote-tracking branch 'origin/MAGETWO-62276' into BUGS
2 parents 9300561 + e98deb7 commit 916c4db

File tree

2 files changed

+35
-2
lines changed
  • app/code/Magento/Ui/view/base/web/js/form/element
  • dev/tests/js/jasmine/tests/app/code/Magento/Ui/base/js/form/element

2 files changed

+35
-2
lines changed

app/code/Magento/Ui/view/base/web/js/form/element/select.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,9 @@ define([
4444
if (_.isUndefined(caption)) {
4545
caption = node.label;
4646
}
47+
} else {
48+
return node;
4749
}
48-
49-
return node;
5050
});
5151

5252
return {

dev/tests/js/jasmine/tests/app/code/Magento/Ui/base/js/form/element/select.test.js

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -188,6 +188,39 @@ define([
188188
expect(model.setVisible).toHaveBeenCalled();
189189
expect(model.toggleInput).toHaveBeenCalled();
190190
});
191+
it('Check call "parseOptions" method without predefined "captionValue" property', function () {
192+
var data = [{
193+
value: null,
194+
label: 'label'
195+
}, {
196+
value: 'value'
197+
}];
198+
199+
model.options = jasmine.createSpy();
200+
model.caption = jasmine.createSpy().and.returnValue(false);
201+
202+
model.setOptions(data);
203+
expect(model.options).toHaveBeenCalledWith([{
204+
value: 'value'
205+
}]);
206+
expect(model.caption.calls.allArgs()).toEqual([[], ['label']]);
207+
208+
});
209+
it('Check call "parseOptions" method with predefined "captionValue" property', function () {
210+
var data = [{
211+
value: 'value',
212+
label: 'label'
213+
}];
214+
215+
model.options = jasmine.createSpy();
216+
model.caption = jasmine.createSpy().and.returnValue(false);
217+
model.captionValue = 'value';
218+
219+
model.setOptions(data);
220+
expect(model.options).toHaveBeenCalledWith([]);
221+
expect(model.caption.calls.allArgs()).toEqual([[], ['label']]);
222+
223+
});
191224
});
192225
describe('getPreview method', function () {
193226
it('check for default preview', function () {

0 commit comments

Comments
 (0)