MAGETWO-96314: Fix performance on MAGETWO-81469

irenelagno · irenelagno · commit 915e27335f3f · 2018-11-20T14:11:48.000-06:00
diff --git a/app/code/Magento/Config/App/Config/Type/System.php b/app/code/Magento/Config/App/Config/Type/System.php
@@ -23,6 +23,7 @@
  *
  * @api
  * @since 100.1.2
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class System implements ConfigTypeInterface
 {
@@ -88,6 +89,7 @@ class System implements ConfigTypeInterface
      * @param Encryptor|null $encryptorFilter
      *
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
+     * @SuppressWarnings(PHPMD.ExcessiveClassComplexity)
      */
     public function __construct(
         ConfigSourceInterface $source,
diff --git a/dev/tests/functional/tests/app/Magento/Install/Test/TestCase/InstallTest.xml b/dev/tests/functional/tests/app/Magento/Install/Test/TestCase/InstallTest.xml
@@ -17,7 +17,7 @@
         <variation name="InstallTestVariation2" firstConstraint="Magento\Install\Test\Constraint\AssertSuccessInstall" summary="Install with custom encryption key and changed currency and locale">
             <data name="user/dataset" xsi:type="string">default</data>
             <data name="install/keyOwn" xsi:type="string">I want to use my own encryption key</data>
-            <data name="install/keyValue" xsi:type="string">123123qa</data>
+            <data name="install/keyValue" xsi:type="string">I_want_to_use_my_own_encryption_key</data>
             <data name="install/storeLanguage" xsi:type="string">German (Germany)</data>
             <data name="install/storeCurrency" xsi:type="string">Euro (EUR)</data>
             <data name="currencySymbol" xsi:type="string">€</data>
diff --git a/lib/internal/Magento/Framework/Config/View.php b/lib/internal/Magento/Framework/Config/View.php
@@ -226,7 +226,8 @@ protected function initData()
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
+     *
      * @throws \InvalidArgumentException
      * @since 100.1.0
      */

Original file line number	Diff line number	Diff line change
`@@ -23,6 +23,7 @@`
`23`	`23`	`*`
`24`	`24`	`* @api`
`25`	`25`	`* @since 100.1.2`
	`26`	`+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)`
`26`	`27`	`*/`
`27`	`28`	`class System implements ConfigTypeInterface`
`28`	`29`	`{`
`@@ -88,6 +89,7 @@ class System implements ConfigTypeInterface`
`88`	`89`	`* @param Encryptor\|null $encryptorFilter`
`89`	`90`	`*`
`90`	`91`	`* @SuppressWarnings(PHPMD.UnusedFormalParameter)`
	`92`	`+ * @SuppressWarnings(PHPMD.ExcessiveClassComplexity)`
`91`	`93`	`*/`
`92`	`94`	`public function __construct(`
`93`	`95`	`ConfigSourceInterface $source,`
Original file line number	Diff line number	Diff line change
`@@ -226,7 +226,8 @@ protected function initData()`
`226`	`226`	`}`
`227`	`227`
`228`	`228`	`/**`
`229`		`- * {@inheritdoc}`
	`229`	`+ * @inheritdoc`
	`230`	`+ *`
`230`	`231`	`* @throws \InvalidArgumentException`
`231`	`232`	`* @since 100.1.0`
`232`	`233`	`*/`