Skip to content

Commit 913f875

Browse files
authored
Merge pull request #4128 from magento-engcom/msi-release-preparation
[MSI] Release preparation
2 parents f7d4822 + e26d0dc commit 913f875

File tree

4 files changed

+2
-53
lines changed

4 files changed

+2
-53
lines changed

app/code/Magento/ConfigurableProduct/Test/Mftf/Test/AdminCreateAndSwitchProductType.xml

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,6 @@
5353
<testCaseId value="MC-10930"/>
5454
<group value="catalog"/>
5555
<group value="mtf_migrated"/>
56-
<skip>
57-
<issueId value="MSI-2110"/>
58-
</skip>
5956
</annotations>
6057
<before>
6158
<createData entity="productAttributeWithTwoOptions" stepKey="createConfigProductAttribute"/>
@@ -93,10 +90,6 @@
9390
<useCaseId value="MAGETWO-44165"/>
9491
<testCaseId value="MAGETWO-29398"/>
9592
<group value="catalog"/>
96-
<group value="mtf_migrated"/>
97-
<skip>
98-
<issueId value="MSI-2110"/>
99-
</skip>
10093
</annotations>
10194
<before>
10295
<createData entity="productAttributeWithTwoOptions" stepKey="createConfigProductAttribute"/>
@@ -139,9 +132,6 @@
139132
<testCaseId value="MAGETWO-29398"/>
140133
<group value="catalog"/>
141134
<group value="mtf_migrated"/>
142-
<skip>
143-
<issueId value="MSI-2110"/>
144-
</skip>
145135
</annotations>
146136
<before>
147137
<createData entity="_defaultCategory" stepKey="createPreReqCategory"/>

dev/tests/static/testsuite/Magento/Test/Integrity/DeclarativeDependencyTest.php

Lines changed: 1 addition & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,6 @@ class DeclarativeDependencyTest extends \PHPUnit\Framework\TestCase
2222
*/
2323
private $dependencyProvider;
2424

25-
/**
26-
* @var array
27-
*/
28-
private $blacklistedDependencies = [];
29-
3025
/**
3126
* Sets up data
3227
*
@@ -50,14 +45,6 @@ protected function setUp()
5045
*/
5146
public function testUndeclaredDependencies()
5247
{
53-
/** TODO: Remove this temporary solution after MC-15534 is closed */
54-
$filePattern = __DIR__ . '/_files/dependency_test/blacklisted_dependencies_*.php';
55-
$blacklistedDependencies = [];
56-
foreach (glob($filePattern) as $fileName) {
57-
$blacklistedDependencies = array_merge($blacklistedDependencies, require $fileName);
58-
}
59-
$this->blacklistedDependencies = $blacklistedDependencies;
60-
6148
$invoker = new \Magento\Framework\App\Utility\AggregateInvoker($this);
6249
$invoker(
6350
/**
@@ -84,9 +71,7 @@ function ($file) {
8471
$result = [];
8572
foreach ($undeclaredDependency as $name => $modules) {
8673
$modules = array_unique($modules);
87-
if ($this->filterBlacklistedDependencies($foundModuleName, $modules)) {
88-
$result[] = $this->getErrorMessage($name) . "\n" . implode("\t\n", $modules) . "\n";
89-
}
74+
$result[] = $this->getErrorMessage($name) . "\n" . implode("\t\n", $modules) . "\n";
9075
}
9176
if (!empty($result)) {
9277
$this->fail(
@@ -98,24 +83,6 @@ function ($file) {
9883
);
9984
}
10085

101-
/**
102-
* Filter blacklisted dependencies.
103-
*
104-
* @todo Remove this temporary solution after MC-15534 is closed
105-
*
106-
* @param string $moduleName
107-
* @param array $dependencies
108-
* @return array
109-
*/
110-
private function filterBlacklistedDependencies(string $moduleName, array $dependencies): array
111-
{
112-
if (!empty($this->blacklistedDependencies[$moduleName])) {
113-
$dependencies = array_diff($dependencies, $this->blacklistedDependencies[$moduleName]);
114-
}
115-
116-
return $dependencies;
117-
}
118-
11986
/**
12087
* Convert file list to data provider structure.
12188
*

dev/tests/static/testsuite/Magento/Test/Integrity/_files/dependency_test/blacklisted_dependencies_ce.php

Lines changed: 0 additions & 9 deletions
This file was deleted.

dev/tests/static/testsuite/Magento/Test/Php/_files/phpcpd/blacklist/common.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -214,3 +214,4 @@ Magento/Elasticsearch/Model/Layer/Search
214214
Magento/Elasticsearch/Model/Adapter/FieldMapper/Product/FieldProvider/FieldName/Resolver
215215
Magento/Elasticsearch6/Model/Client
216216
Magento/Config/App/Config/Type
217+
Magento/InventoryReservationCli/Test/Integration

0 commit comments

Comments
 (0)