Skip to content

Commit 910ca33

Browse files
magento-engcom-teammagento-engcom-team
authored
🔃 [EngCom] Public Pull Requests - 2.3-develop
Accepted Public Pull Requests: - #14868: [Forwardport] Fix issue #13944. Show Store Views in Terms and Conditions grid. (by @rostyslav-hymon) - #14867: [forwardport] PR#12712 : Found 2 elements with non-unique id #email (by @julienanquetil) - magento-engcom-team/magento2ce#114: [2.3-develop] Forwardport of #11539 (by @magento-engcom-team) - #14382: Removed unused translation for comment tag (by @yogeshks) Fixed GitHub Issues: - #13944: Stores -> Terms and Conditions - No Store View shown (reported by @raymond62) has been fixed in #14868 by @rostyslav-hymon in 2.3-develop branch Related commits: 1. 9000f74 - #12712: Latest Google Chrome Browser issue with duplicate #email (reported by @lano-vargas) has been fixed in #14867 by @julienanquetil in 2.3-develop branch Related commits: 1. b7c0f1b - #14850: Found 2 elements with non-unique id #email: magento 2 contact (reported by @shivkumarsingh7) has been fixed in #14867 by @julienanquetil in 2.3-develop branch Related commits: 1. b7c0f1b - #9360: <depends> field doesn't work in system.xml for "radios" fields (reported by @WaPoNe) has been fixed in magento-engcom-team/magento2ce#114 by @magento-engcom-team in 2.3-develop branch Related commits: 1. da5692c 2. 9775cd8 3. e10a3ff
2 parents aced6fc + 04d756b commit 910ca33

File tree

9 files changed

+111
-32
lines changed

9 files changed

+111
-32
lines changed

‎app/code/Magento/Analytics/etc/adminhtml/system.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,14 @@
1717
Your reports can be accessed securely on a personalized dashboard outside of the admin panel by clicking on the
1818
"Go to Advanced Reporting" link. </br> For more information, see our <a href="https://magento.com/legal/terms/cloud-terms">
1919
terms and conditions</a>.]]></comment>
20-
<field id="enabled" translate="label comment" type="select" sortOrder="10" showInDefault="1" showInWebsite="0" showInStore="0">
20+
<field id="enabled" translate="label" type="select" sortOrder="10" showInDefault="1" showInWebsite="0" showInStore="0">
2121
<label>Advanced Reporting Service</label>
2222
<source_model>Magento\Config\Model\Config\Source\Enabledisable</source_model>
2323
<backend_model>Magento\Analytics\Model\Config\Backend\Enabled</backend_model>
2424
<frontend_model>Magento\Analytics\Block\Adminhtml\System\Config\SubscriptionStatusLabel</frontend_model>
2525
<config_path>analytics/subscription/enabled</config_path>
2626
</field>
27-
<field id="collection_time" translate="label comment" type="time" sortOrder="20" showInDefault="1" showInWebsite="0" showInStore="0">
27+
<field id="collection_time" translate="label" type="time" sortOrder="20" showInDefault="1" showInWebsite="0" showInStore="0">
2828
<label>Time of day to send data</label>
2929
<frontend_model>Magento\Analytics\Block\Adminhtml\System\Config\CollectionTimeLabel</frontend_model>
3030
<backend_model>Magento\Analytics\Model\Config\Backend\CollectionTime</backend_model>

‎app/code/Magento/Catalog/Block/Adminhtml/Product/Attribute/Edit/Tab/Front.php

Lines changed: 3 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -184,33 +184,19 @@ protected function _prepareForm()
184184
'form_after',
185185
$this->getLayout()->createBlock(
186186
\Magento\Backend\Block\Widget\Form\Element\Dependence::class
187-
)->addFieldMap(
188-
"is_wysiwyg_enabled",
189-
'wysiwyg_enabled'
190187
)->addFieldMap(
191188
"is_html_allowed_on_front",
192189
'html_allowed_on_front'
193190
)->addFieldMap(
194191
"frontend_input",
195192
'frontend_input_type'
196-
)->addFieldDependence(
197-
'wysiwyg_enabled',
198-
'frontend_input_type',
199-
'textarea'
200-
)->addFieldDependence(
201-
'html_allowed_on_front',
202-
'wysiwyg_enabled',
203-
'0'
204-
)
205-
->addFieldMap(
193+
)->addFieldMap(
206194
"is_searchable",
207195
'searchable'
208-
)
209-
->addFieldMap(
196+
)->addFieldMap(
210197
"is_visible_in_advanced_search",
211198
'advanced_search'
212-
)
213-
->addFieldDependence(
199+
)->addFieldDependence(
214200
'advanced_search',
215201
'searchable',
216202
'1'

‎app/code/Magento/Catalog/etc/adminhtml/system.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,10 @@
3636
</group>
3737
<group id="recently_products" translate="label" type="text" sortOrder="350" showInDefault="1" showInWebsite="1" showInStore="0">
3838
<label>Recently Viewed/Compared Products</label>
39-
<field id="recently_viewed_lifetime" translate="label comment" type="text" sortOrder="40" showInDefault="1" showInWebsite="0" showInStore="0" canRestore="1">
39+
<field id="recently_viewed_lifetime" translate="label" type="text" sortOrder="40" showInDefault="1" showInWebsite="0" showInStore="0" canRestore="1">
4040
<label>Lifetime of products in Recently Viewed Widget</label>
4141
</field>
42-
<field id="recently_compared_lifetime" translate="label comment" type="text" sortOrder="40" showInDefault="1" showInWebsite="0" showInStore="0" canRestore="1">
42+
<field id="recently_compared_lifetime" translate="label" type="text" sortOrder="40" showInDefault="1" showInWebsite="0" showInStore="0" canRestore="1">
4343
<label>Lifetime of products in Recently Compared Widget</label>
4444
</field>
4545
<field id="synchronize_with_backend" translate="label" type="select" showInDefault="1" canRestore="1">
@@ -83,7 +83,7 @@
8383
<backend_model>Magento\Catalog\Model\Indexer\Product\Flat\System\Config\Mode</backend_model>
8484
<source_model>Magento\Config\Model\Config\Source\Yesno</source_model>
8585
</field>
86-
<field id="default_sort_by" translate="label comment" type="select" sortOrder="6" showInDefault="1" showInWebsite="1" showInStore="1" canRestore="1">
86+
<field id="default_sort_by" translate="label" type="select" sortOrder="6" showInDefault="1" showInWebsite="1" showInStore="1" canRestore="1">
8787
<label>Product Listing Sort by</label>
8888
<source_model>Magento\Catalog\Model\Config\Source\ListSort</source_model>
8989
</field>

‎app/code/Magento/CheckoutAgreements/Block/Adminhtml/Agreement/Grid.php

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,27 +5,42 @@
55
*/
66
namespace Magento\CheckoutAgreements\Block\Adminhtml\Agreement;
77

8+
use Magento\Framework\App\ObjectManager;
9+
use Magento\CheckoutAgreements\Model\ResourceModel\Agreement\Grid\CollectionFactory as GridCollectionFactory;
10+
811
class Grid extends \Magento\Backend\Block\Widget\Grid\Extended
912
{
1013
/**
1114
* @var \Magento\CheckoutAgreements\Model\ResourceModel\Agreement\CollectionFactory
15+
* @deprecated
1216
*/
1317
protected $_collectionFactory;
1418

19+
/**
20+
* @param GridCollectionFactory
21+
*/
22+
private $gridCollectionFactory;
23+
1524
/**
1625
* @param \Magento\Backend\Block\Template\Context $context
1726
* @param \Magento\Backend\Helper\Data $backendHelper
1827
* @param \Magento\CheckoutAgreements\Model\ResourceModel\Agreement\CollectionFactory $collectionFactory
1928
* @param array $data
29+
* @param GridCollectionFactory $gridColFactory
2030
* @codeCoverageIgnore
2131
*/
2232
public function __construct(
2333
\Magento\Backend\Block\Template\Context $context,
2434
\Magento\Backend\Helper\Data $backendHelper,
2535
\Magento\CheckoutAgreements\Model\ResourceModel\Agreement\CollectionFactory $collectionFactory,
26-
array $data = []
36+
array $data = [],
37+
GridCollectionFactory $gridColFactory = null
2738
) {
39+
2840
$this->_collectionFactory = $collectionFactory;
41+
$this->gridCollectionFactory = $gridColFactory
42+
? : ObjectManager::getInstance()->get(GridCollectionFactory::class);
43+
2944
parent::__construct($context, $backendHelper, $data);
3045
}
3146

@@ -47,7 +62,7 @@ protected function _construct()
4762
*/
4863
protected function _prepareCollection()
4964
{
50-
$this->setCollection($this->_collectionFactory->create());
65+
$this->setCollection($this->gridCollectionFactory->create());
5166
return parent::_prepareCollection();
5267
}
5368

‎app/code/Magento/CheckoutAgreements/Model/ResourceModel/Agreement/Grid/Collection.php

Lines changed: 78 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,78 @@
1+
<?php
2+
/**
3+
* Copyright © Magento, Inc. All rights reserved.
4+
* See COPYING.txt for license details.
5+
*/
6+
declare(strict_types=1);
7+
8+
namespace Magento\CheckoutAgreements\Model\ResourceModel\Agreement\Grid;
9+
10+
/**
11+
* CheckoutAgreement Grid Collection
12+
*/
13+
class Collection extends \Magento\CheckoutAgreements\Model\ResourceModel\Agreement\Collection
14+
{
15+
16+
/**
17+
* {@inheritdoc}
18+
*/
19+
public function load($printQuery = false, $logQuery = false)
20+
{
21+
if ($this->isLoaded()) {
22+
return $this;
23+
}
24+
25+
parent::load($printQuery, $logQuery);
26+
27+
$this->addStoresToResult();
28+
29+
return $this;
30+
}
31+
32+
/**
33+
* @return void
34+
*/
35+
private function addStoresToResult()
36+
{
37+
$stores = $this->getStoresForAgreements();
38+
39+
if (!empty($stores)) {
40+
$storesByAgreementId = [];
41+
42+
foreach ($stores as $storeData) {
43+
$storesByAgreementId[$storeData['agreement_id']][] = $storeData['store_id'];
44+
}
45+
46+
foreach ($this as $item) {
47+
$agreementId = $item->getData('agreement_id');
48+
49+
if (!isset($storesByAgreementId[$agreementId])) {
50+
continue;
51+
}
52+
53+
$item->setData('stores', $storesByAgreementId[$agreementId]);
54+
}
55+
}
56+
}
57+
58+
/**
59+
* @return array
60+
*/
61+
private function getStoresForAgreements()
62+
{
63+
$agreementId = $this->getColumnValues('agreement_id');
64+
65+
if (!empty($agreementId)) {
66+
$select = $this->getConnection()->select()->from(
67+
['agreement_store' => 'checkout_agreement_store']
68+
)->where(
69+
'agreement_store.agreement_id IN (?)',
70+
$agreementId
71+
);
72+
73+
return $this->getConnection()->fetchAll($select);
74+
}
75+
76+
return [];
77+
}
78+
}

‎app/code/Magento/Customer/view/frontend/web/template/authentication-popup.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,10 @@
5454
id="login-form">
5555
<div class="fieldset login" data-bind="attr: {'data-hasrequired': $t('* Required Fields')}">
5656
<div class="field email required">
57-
<label class="label" for="email"><span data-bind="i18n: 'Email Address'"></span></label>
57+
<label class="label" for="customer-email"><span data-bind="i18n: 'Email Address'"></span></label>
5858
<div class="control">
5959
<input name="username"
60-
id="email"
60+
id="customer-email"
6161
type="email"
6262
class="input-text"
6363
data-bind="attr: {autocomplete: autocomplete}"

‎app/code/Magento/Sales/etc/adminhtml/system.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -106,15 +106,15 @@
106106
<comment>We'll use the default error above if you leave this empty.</comment>
107107
</field>
108108
</group>
109-
<group id="dashboard" translate="label comment" sortOrder="60" showInDefault="1" showInWebsite="0" showInStore="0">
109+
<group id="dashboard" translate="label" sortOrder="60" showInDefault="1" showInWebsite="0" showInStore="0">
110110
<label>Dashboard</label>
111-
<field id="use_aggregated_data" translate="label" sortOrder="10" type="select" showInDefault="1" showInWebsite="0" showInStore="0" canRestore="1">
111+
<field id="use_aggregated_data" translate="label comment" sortOrder="10" type="select" showInDefault="1" showInWebsite="0" showInStore="0" canRestore="1">
112112
<label>Use Aggregated Data</label>
113113
<source_model>Magento\Config\Model\Config\Source\Yesno</source_model>
114114
<comment>Improves dashboard performance but provides non-realtime data.</comment>
115115
</field>
116116
</group>
117-
<group id="orders" translate="label comment" sortOrder="70" showInDefault="1" showInWebsite="1" showInStore="0">
117+
<group id="orders" translate="label" sortOrder="70" showInDefault="1" showInWebsite="1" showInStore="0">
118118
<label>Orders Cron Settings</label>
119119
<field id="delete_pending_after" translate="label" type="text" sortOrder="6" showInDefault="1" showInWebsite="1" showInStore="0" canRestore="1">
120120
<label>Pending Payment Order Lifetime (minutes)</label>

‎app/code/Magento/Swatches/etc/adminhtml/system.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,10 @@
99
<system>
1010
<section id="catalog" translate="label" type="text" sortOrder="40" showInDefault="1" showInWebsite="1" showInStore="1">
1111
<group id="frontend" translate="label" type="text" sortOrder="100" showInDefault="1" showInWebsite="1" showInStore="1">
12-
<field id="swatches_per_product" translate="label comment" type="text" sortOrder="300" showInDefault="1" showInWebsite="1" showInStore="1" canRestore="1">
12+
<field id="swatches_per_product" translate="label" type="text" sortOrder="300" showInDefault="1" showInWebsite="1" showInStore="1" canRestore="1">
1313
<label>Swatches per Product</label>
1414
</field>
15-
<field id="show_swatches_in_product_list" translate="label comment" type="select" sortOrder="310" showInDefault="1" showInWebsite="1" showInStore="1" canRestore="1">
15+
<field id="show_swatches_in_product_list" translate="label" type="select" sortOrder="310" showInDefault="1" showInWebsite="1" showInStore="1" canRestore="1">
1616
<label>Show Swatches in Product List</label>
1717
<source_model>Magento\Config\Model\Config\Source\Yesno</source_model>
1818
</field>

‎app/code/Magento/Ups/etc/adminhtml/system.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@
106106
<label>Live Account</label>
107107
<source_model>Magento\Config\Model\Config\Source\Yesno</source_model>
108108
</field>
109-
<field id="unit_of_measure" translate="label comment" type="select" sortOrder="60" showInDefault="1" showInWebsite="1" showInStore="0" canRestore="1">
109+
<field id="unit_of_measure" translate="label" type="select" sortOrder="60" showInDefault="1" showInWebsite="1" showInStore="0" canRestore="1">
110110
<label>Weight Unit</label>
111111
<source_model>Magento\Ups\Model\Config\Source\Unitofmeasure</source_model>
112112
</field>

0 commit comments

Comments
 (0)