Skip to content

Commit 90bf25a

Browse files
authored
ENGCOM-6580: Remove extra space before semicolon and remove extra comma in php, phtml and js files #26342
2 parents d328952 + 105c403 commit 90bf25a

File tree

7 files changed

+38
-18
lines changed

7 files changed

+38
-18
lines changed

app/code/Magento/Backend/Block/Widget/Grid/Column/Renderer/AbstractRenderer.php

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,9 @@
99
use Magento\Framework\DataObject;
1010

1111
/**
12+
* Produce html output using the given data source.
13+
*
14+
* phpcs:disable Magento2.Classes.AbstractApi
1215
* Backend grid item abstract renderer
1316
* @api
1417
* @SuppressWarnings(PHPMD.NumberOfChildren)
@@ -53,7 +56,7 @@ public function getColumn()
5356
* Renders grid column
5457
*
5558
* @param DataObject $row
56-
* @return string
59+
* @return string
5760
*/
5861
public function render(DataObject $row)
5962
{
@@ -62,7 +65,7 @@ public function render(DataObject $row)
6265
$result .= $this->getColumn()->getEditOnly() ? ''
6366
: '<span class="admin__grid-control-value">' . $this->_getValue($row) . '</span>';
6467

65-
return $result . $this->_getInputValueElement($row) . '</div>' ;
68+
return $result . $this->_getInputValueElement($row) . '</div>';
6669
}
6770
return $this->_getValue($row);
6871
}
@@ -90,6 +93,7 @@ protected function _getValue(DataObject $row)
9093
if (is_string($getter)) {
9194
return $row->{$getter}();
9295
} elseif (is_callable($getter)) {
96+
//phpcs:ignore Magento2.Functions.DiscouragedFunction
9397
return call_user_func($getter, $row);
9498
}
9599
return '';

app/code/Magento/CatalogGraphQl/DataProvider/Product/SearchCriteriaBuilder.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ private function addVisibilityFilter(SearchCriteriaInterface $searchCriteria, bo
123123
{
124124
if ($isFilter && $isSearch) {
125125
// Index already contains products filtered by visibility: catalog, search, both
126-
return ;
126+
return;
127127
}
128128
$visibilityIds = $isSearch
129129
? $this->visibility->getVisibleInSearchIds()

app/code/Magento/Csp/Model/Collector/CspWhitelistXml/SchemaLocator.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ class SchemaLocator implements SchemaLocatorInterface
2222
*
2323
* @var string
2424
*/
25-
private $schema ;
25+
private $schema;
2626

2727
/**
2828
* @param Reader $moduleReader

app/code/Magento/Payment/Test/Unit/Gateway/Data/PaymentDataObjectTest.php

Lines changed: 27 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -5,46 +5,62 @@
55
*/
66
namespace Magento\Payment\Test\Unit\Gateway\Data;
77

8-
use Magento\Payment\Gateway\Data\PaymentDataObject;
98
use Magento\Payment\Gateway\Data\OrderAdapterInterface;
9+
use Magento\Payment\Gateway\Data\PaymentDataObject;
1010
use Magento\Payment\Model\InfoInterface;
11+
use PHPUnit\Framework\MockObject\MockObject;
1112

1213
/**
13-
* Class PaymentDataObjectTest
14+
* Tests for PaymentDataObject
1415
*/
1516
class PaymentDataObjectTest extends \PHPUnit\Framework\TestCase
1617
{
17-
/** @var PaymentDataObject */
18+
/**
19+
* @var PaymentDataObject
20+
*/
1821
protected $model;
1922

2023
/**
21-
* @var OrderAdapterInterface|\PHPUnit_Framework_MockObject_MockObject
24+
* @var OrderAdapterInterface|MockObject
2225
*/
2326
protected $orderMock;
2427

2528
/**
26-
* @var InfoInterface|\PHPUnit_Framework_MockObject_MockObject
29+
* @var InfoInterface|\MockObject
2730
*/
2831
protected $paymentMock;
2932

33+
/**
34+
* @inheritdoc
35+
*/
3036
protected function setUp()
3137
{
32-
$this->orderMock = $this->getMockBuilder(\Magento\Payment\Gateway\Data\OrderAdapterInterface::class)
38+
$this->orderMock = $this->getMockBuilder(OrderAdapterInterface::class)
3339
->getMockForAbstractClass();
3440

35-
$this->paymentMock = $this->getMockBuilder(\Magento\Payment\Model\InfoInterface::class)
41+
$this->paymentMock = $this->getMockBuilder(InfoInterface::class)
3642
->getMockForAbstractClass();
3743

3844
$this->model = new PaymentDataObject($this->orderMock, $this->paymentMock);
3945
}
4046

41-
public function testGetOrder()
47+
/**
48+
* Verify can get order
49+
*
50+
* @return void
51+
*/
52+
public function testGetOrder(): void
4253
{
43-
$this->assertSame($this->orderMock, $this->model->getOrder()) ;
54+
$this->assertSame($this->orderMock, $this->model->getOrder());
4455
}
4556

46-
public function testGetPayment()
57+
/**
58+
* Verify can get payment
59+
*
60+
* @return void
61+
*/
62+
public function testGetPayment(): void
4763
{
48-
$this->assertSame($this->paymentMock, $this->model->getPayment()) ;
64+
$this->assertSame($this->paymentMock, $this->model->getPayment());
4965
}
5066
}

app/code/Magento/Quote/Test/Unit/Model/Product/Plugin/UpdateQuoteItemsTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ class UpdateQuoteItemsTest extends \PHPUnit\Framework\TestCase
1515
/**
1616
* @var \PHPUnit_Framework_MockObject_MockObject|\Magento\Quote\Model\ResourceModel\Quote
1717
*/
18-
private $quoteResource ;
18+
private $quoteResource;
1919

2020
protected function setUp()
2121
{

app/code/Magento/Sales/Block/Adminhtml/Order/Status/NewStatus/Form.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ protected function _addStoresFieldset($model, $form)
100100
'fieldset_html_class' => 'store'
101101
]
102102
);
103-
return ;
103+
return;
104104
}
105105

106106
$renderer = $this->getLayout()->createBlock(

app/code/Magento/Tinymce3/view/base/web/tiny_mce/plugins/table/editor_plugin_src.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1222,7 +1222,7 @@
12221222
var last;
12231223

12241224
// Skip empty text nodes form the end
1225-
for (last = ed.getBody().lastChild; last && last.nodeType == 3 && !last.nodeValue.length; last = last.previousSibling) ;
1225+
for (last = ed.getBody().lastChild; last && last.nodeType == 3 && !last.nodeValue.length; last = last.previousSibling);
12261226

12271227
if (last && last.nodeName == 'TABLE')
12281228
ed.dom.add(ed.getBody(), 'p', null, '<br mce_bogus="1" />');

0 commit comments

Comments
 (0)