ENGCOM-948: Improve Customer GraphQL Model code quality #14158

Author: Stanislav Idolov

app/code/Magento/CustomerGraphQl/Model/Resolver/Customer.php

@@ -6,11 +6,12 @@
 
 namespace Magento\CustomerGraphQl\Model\Resolver;
 
+use Magento\Authorization\Model\UserContextInterface;
+use Magento\CustomerGraphQl\Model\Resolver\Customer\CustomerDataProvider;
 use Magento\Framework\Exception\NoSuchEntityException;
 use Magento\Framework\GraphQl\Exception\GraphQlAuthorizationException;
 use Magento\Framework\GraphQl\Exception\GraphQlNoSuchEntityException;
 use Magento\GraphQl\Model\ResolverInterface;
-use Magento\Framework\GraphQl\Exception\GraphQlInputException;
 use Magento\GraphQl\Model\ResolverContextInterface;
 
 /**
@@ -24,10 +25,10 @@ class Customer implements ResolverInterface
     private $customerResolver;
 
     /**
-     * @param \Magento\CustomerGraphQl\Model\Resolver\Customer\CustomerDataProvider $customerResolver
+     * @param CustomerDataProvider $customerResolver
      */
     public function __construct(
-        \Magento\CustomerGraphQl\Model\Resolver\Customer\CustomerDataProvider $customerResolver
+        CustomerDataProvider $customerResolver
     ) {
         $this->customerResolver = $customerResolver;
     }
@@ -37,7 +38,7 @@ public function __construct(
      */
     public function resolve(array $args, ResolverContextInterface $context)
     {
-        if ((!$context->getUserId()) || $context->getUserType() == 4) {
+        if ((!$context->getUserId()) || $context->getUserType() == UserContextInterface::USER_TYPE_GUEST) {
             throw new GraphQlAuthorizationException(
                 __(
                     'Current customer does not have access to the resource "%1"',

app/code/Magento/CustomerGraphQl/composer.json

@@ -6,6 +6,7 @@
   "require": {
     "php": "7.0.2|7.0.4|~7.0.6|~7.1.0",
     "magento/module-customer": "100.2.*",
+    "magento/module-authorization": "100.3.*",
     "magento/module-graph-ql": "100.0.*",
     "magento/framework": "100.3.*"
   },

app/code/Magento/CustomerGraphQl/etc/module.xml

@@ -9,6 +9,7 @@
     <module name="Magento_CustomerGraphQl" >
         <sequence>
             <module name="Magento_Customer"/>
+            <module name="Magento_Authorization"/>
             <module name="Magento_GraphQl"/>
         </sequence>
     </module>