MAGETWO-38180: Check if the theme is not a base for any virtual theme

 - Remove the deployment configuration check since this command belongs to module. It won't show up in the command list unless you installed it.

Author: Fred Sung

app/code/Magento/Theme/Console/Command/ThemeUninstallCommand.php

@@ -21,7 +21,6 @@
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Input\InputArgument;
-use Magento\Framework\App\DeploymentConfig;
 use Magento\Framework\Setup\BackupRollbackFactory;
 use Magento\Framework\App\Filesystem\DirectoryList;
 use Magento\Framework\Exception\LocalizedException;
@@ -41,13 +40,6 @@ class ThemeUninstallCommand extends Command
     const INPUT_KEY_THEMES = 'theme';
     const INPUT_KEY_CLEAR_STATIC_CONTENT = 'clear-static-content';
 
-    /**
-     * Deployment Configuration
-     *
-     * @var DeploymentConfig
-     */
-    private $deploymentConfig;
-
     /**
      * Maintenance Mode
      *
@@ -131,7 +123,6 @@ class ThemeUninstallCommand extends Command
      * @param Cache $cache
      * @param State\CleanupFiles $cleanupFiles
      * @param ComposerInformation $composer
-     * @param DeploymentConfig $deploymentConfig
      * @param MaintenanceMode $maintenanceMode
      * @param Filesystem $filesystem
      * @param DependencyChecker $dependencyChecker
@@ -146,7 +137,6 @@ public function __construct(
         Cache $cache,
         State\CleanupFiles $cleanupFiles,
         ComposerInformation $composer,
-        DeploymentConfig $deploymentConfig,
         MaintenanceMode $maintenanceMode,
         Filesystem $filesystem,
         DependencyChecker $dependencyChecker,
@@ -159,7 +149,6 @@ public function __construct(
         $this->cache = $cache;
         $this->cleanupFiles = $cleanupFiles;
         $this->composer = $composer;
-        $this->deploymentConfig = $deploymentConfig;
         $this->maintenanceMode = $maintenanceMode;
         $this->filesystem = $filesystem;
         $this->dependencyChecker = $dependencyChecker;
@@ -205,13 +194,6 @@ protected function configure()
      */
     protected function execute(InputInterface $input, OutputInterface $output)
     {
-        if (!$this->deploymentConfig->isAvailable()) {
-            $output->writeln(
-                '<error>You cannot run this command because the Magento application is not installed.</error>'
-            );
-            return;
-        }
-
         $themePaths = $input->getArgument(self::INPUT_KEY_THEMES);
         $validationMessages = $this->validate($themePaths);
         if (!empty($validationMessages)) {

app/code/Magento/Theme/Test/Unit/Console/Command/ThemeUninstallCommandTest.php

@@ -16,11 +16,6 @@
  */
 class ThemeUninstallCommandTest extends \PHPUnit_Framework_TestCase
 {
-    /**
-     * @var \Magento\Framework\App\DeploymentConfig|\PHPUnit_Framework_MockObject_MockObject
-     */
-    private $deploymentConfig;
-
     /**
      * @var \Magento\Framework\App\MaintenanceMode|\PHPUnit_Framework_MockObject_MockObject
      */
@@ -78,7 +73,6 @@ class ThemeUninstallCommandTest extends \PHPUnit_Framework_TestCase
 
     public function setUp()
     {
-        $this->deploymentConfig = $this->getMock('Magento\Framework\App\DeploymentConfig', [], [], '', false);
         $this->maintenanceMode = $this->getMock('Magento\Framework\App\MaintenanceMode', [], [], '', false);
         $composerInformation = $this->getMock('Magento\Framework\Composer\ComposerInformation', [], [], '', false);
         $composerInformation->expects($this->any())
@@ -109,7 +103,6 @@ public function setUp()
             $this->cache,
             $this->cleanupFiles,
             $composerInformation,
-            $this->deploymentConfig,
             $this->maintenanceMode,
             $this->filesystem,
             $this->dependencyChecker,
@@ -122,19 +115,8 @@ public function setUp()
         $this->tester = new CommandTester($this->command);
     }
 
-    public function testExecuteWithoutApplicationInstalled()
-    {
-        $this->deploymentConfig->expects($this->once())->method('isAvailable')->willReturn(false);
-        $this->tester->execute(['theme' => ['test']]);
-        $this->assertContains(
-            'You cannot run this command because the Magento application is not installed.',
-            $this->tester->getDisplay()
-        );
-    }
-
     public function testExecuteFailedValidationNotPackage()
     {
-        $this->deploymentConfig->expects($this->once())->method('isAvailable')->willReturn(true);
         $dirRead = $this->getMock('Magento\Framework\Filesystem\Directory\Read', [], [], '', false);
         // package name "dummy" is not in root composer.json file
         $dirRead->expects($this->any())
@@ -167,7 +149,6 @@ public function testExecuteFailedValidationNotPackage()
 
     public function testExecuteFailedValidationNotTheme()
     {
-        $this->deploymentConfig->expects($this->once())->method('isAvailable')->willReturn(true);
         $dirRead = $this->getMock('Magento\Framework\Filesystem\Directory\Read', [], [], '', false);
         $dirRead->expects($this->any())->method('isExist')->willReturn(false);
         $this->filesystem->expects($this->any())
@@ -187,7 +168,6 @@ public function testExecuteFailedValidationNotTheme()
 
     public function testExecuteFailedValidationMixed()
     {
-        $this->deploymentConfig->expects($this->once())->method('isAvailable')->willReturn(true);
         $dirRead = $this->getMock('Magento\Framework\Filesystem\Directory\Read', [], [], '', false);
         // package name "dummy" is not in root composer.json file
         $dirRead->expects($this->any())
@@ -237,7 +217,6 @@ public function testExecuteFailedValidationMixed()
 
     public function setUpPassValidation()
     {
-        $this->deploymentConfig->expects($this->once())->method('isAvailable')->willReturn(true);
         $dirRead = $this->getMock('Magento\Framework\Filesystem\Directory\Read', [], [], '', false);
         // package name "dummy" is not in root composer.json file
         $dirRead->expects($this->any())