ACP2E-285: Add to cart failed when cart total is zero and cart price rule is Fixed amount discount for whole cart

Chhandak.Barua · Chhandak.Barua · commit 90563cc5be9e · 2021-11-13T00:46:02.000+05:30
diff --git a/app/code/Magento/SalesRule/Helper/CartFixedDiscount.php b/app/code/Magento/SalesRule/Helper/CartFixedDiscount.php
@@ -109,7 +109,7 @@ public function getDiscountedAmountProportionally(
         string $discountType
     ): float {
         $baseItemPriceTotal = $baseItemPrice * $qty - $baseItemDiscountAmount;
-        $ratio = $baseItemPriceTotal / $baseRuleTotalsDiscount;
+        $ratio = $baseRuleTotalsDiscount != 0 ? $baseItemPriceTotal / $baseRuleTotalsDiscount : 0;
         $discountAmount = $this->deltaPriceRound->round($ruleDiscount * $ratio, $discountType);
         return $discountAmount;
     }

Original file line number	Diff line number	Diff line change
`@@ -109,7 +109,7 @@ public function getDiscountedAmountProportionally(`
`109`	`109`	`string $discountType`
`110`	`110`	`): float {`
`111`	`111`	`$baseItemPriceTotal = $baseItemPrice * $qty - $baseItemDiscountAmount;`
`112`		`- $ratio = $baseItemPriceTotal / $baseRuleTotalsDiscount;`
	`112`	`+ $ratio = $baseRuleTotalsDiscount != 0 ? $baseItemPriceTotal / $baseRuleTotalsDiscount : 0;`
`113`	`113`	`$discountAmount = $this->deltaPriceRound->round($ruleDiscount * $ratio, $discountType);`
`114`	`114`	`return $discountAmount;`
`115`	`115`	`}`