MC-3103: Custom Product Attributes with FullWidth Page Layout

- Resolve CR comments, update shouldDisplay function to isVisibleOnFrontend

Author: davemacaulay

app/code/Magento/Catalog/Block/Product/View/Attributes.php

@@ -79,7 +79,7 @@ public function getAdditionalData(array $excludeAttr = [])
         $product = $this->getProduct();
         $attributes = $product->getAttributes();
         foreach ($attributes as $attribute) {
-            if ($this->shouldDisplay($attribute, $excludeAttr)) {
+            if ($this->isVisibleOnFrontend($attribute, $excludeAttr)) {
                 $value = $attribute->getFrontend()->getValue($product);
 
                 if ($value instanceof Phrase) {
@@ -107,7 +107,7 @@ public function getAdditionalData(array $excludeAttr = [])
      * @param array $excludeAttr
      * @return bool
      */
-    protected function shouldDisplay(
+    protected function isVisibleOnFrontend(
         \Magento\Eav\Model\Entity\Attribute\AbstractAttribute $attribute,
         array $excludeAttr
     ) {