Skip to content

Commit 902fcdd

Browse files
committed
MC-35065: Catalog pricerules are not working with custom options as expected in Magento 2.3.0 product details page
1 parent 27f2d9d commit 902fcdd

File tree

1 file changed

+10
-9
lines changed
  • app/code/Magento/Catalog/Test/Unit/Model/Product/Option

1 file changed

+10
-9
lines changed

app/code/Magento/Catalog/Test/Unit/Model/Product/Option/ValueTest.php

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@
1212
use Magento\Catalog\Model\Product\Option\Value;
1313
use Magento\Catalog\Model\ResourceModel\Product\Option\Value\Collection;
1414
use Magento\Catalog\Model\ResourceModel\Product\Option\Value\CollectionFactory;
15-
use Magento\Catalog\Pricing\Price\CustomOptionPriceCalculator;
16-
1715
use Magento\Framework\Pricing\Price\PriceInterface;
1816
use Magento\Framework\Pricing\PriceInfoInterface;
1917
use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
2018
use PHPUnit\Framework\TestCase;
19+
use Magento\Catalog\Pricing\Price\CalculateCustomOptionCatalogRule;
20+
use PHPUnit\Framework\MockObject\MockObject;
2121

2222
/**
2323
* Test for \Magento\Catalog\Model\Product\Option\Value class.
@@ -30,17 +30,18 @@ class ValueTest extends TestCase
3030
private $model;
3131

3232
/**
33-
* @var CustomOptionPriceCalculator
33+
* @var CalculateCustomOptionCatalogRule|MockObject
3434
*/
35-
private $customOptionPriceCalculatorMock;
35+
private $CalculateCustomOptionCatalogRule;
3636

3737
protected function setUp(): void
3838
{
3939
$mockedResource = $this->getMockedResource();
4040
$mockedCollectionFactory = $this->getMockedValueCollectionFactory();
4141

42-
$this->customOptionPriceCalculatorMock = $this->createMock(
43-
CustomOptionPriceCalculator::class
42+
43+
$this->CalculateCustomOptionCatalogRule = $this->createMock(
44+
CalculateCustomOptionCatalogRule::class
4445
);
4546

4647
$helper = new ObjectManager($this);
@@ -49,7 +50,7 @@ protected function setUp(): void
4950
[
5051
'resource' => $mockedResource,
5152
'valueCollectionFactory' => $mockedCollectionFactory,
52-
'customOptionPriceCalculator' => $this->customOptionPriceCalculatorMock,
53+
'CalculateCustomOptionCatalogRule' => $this->CalculateCustomOptionCatalogRule
5354
]
5455
);
5556
$this->model->setOption($this->getMockedOption());
@@ -77,8 +78,8 @@ public function testGetPrice()
7778
$this->assertEquals($price, $this->model->getPrice(false));
7879

7980
$percentPrice = 100.0;
80-
$this->customOptionPriceCalculatorMock->expects($this->atLeastOnce())
81-
->method('getOptionPriceByPriceCode')
81+
$this->CalculateCustomOptionCatalogRule->expects($this->atLeastOnce())
82+
->method('execute')
8283
->willReturn($percentPrice);
8384
$this->assertEquals($percentPrice, $this->model->getPrice(true));
8485
}

0 commit comments

Comments
 (0)