Skip to content

Commit 8fcc850

Browse files
author
vpaladiychuk
committed
MAGETWO-35534: Unit Tests code coverage failures - Captcha and View
1 parent 768b5b5 commit 8fcc850

File tree

4 files changed

+78
-37
lines changed

4 files changed

+78
-37
lines changed

‎app/code/Magento/Captcha/Model/DefaultModel.php

100644100755
Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,22 +68,30 @@ class DefaultModel extends \Zend_Captcha_Image implements \Magento\Captcha\Model
6868
*/
6969
protected $_session;
7070

71+
/**
72+
* @var \Magento\Framework\Stdlib\DateTime\DateTime
73+
*/
74+
protected $dateModel;
75+
7176
/**
7277
* @param \Magento\Framework\Session\SessionManagerInterface $session
7378
* @param \Magento\Captcha\Helper\Data $captchaData
7479
* @param \Magento\Captcha\Model\Resource\LogFactory $resLogFactory
80+
* @param \Magento\Framework\Stdlib\DateTime\DateTime $dateModel
7581
* @param string $formId
7682
*/
7783
public function __construct(
7884
\Magento\Framework\Session\SessionManagerInterface $session,
7985
\Magento\Captcha\Helper\Data $captchaData,
8086
\Magento\Captcha\Model\Resource\LogFactory $resLogFactory,
87+
\Magento\Framework\Stdlib\DateTime\DateTime $dateModel,
8188
$formId
8289
) {
8390
$this->_session = $session;
8491
$this->_captchaData = $captchaData;
8592
$this->_resLogFactory = $resLogFactory;
8693
$this->_formId = $formId;
94+
$this->dateModel = $dateModel;
8795
}
8896

8997
/**
@@ -452,7 +460,7 @@ protected function _getTargetForms()
452460
public function getWord()
453461
{
454462
$sessionData = $this->_session->getData($this->_getFormIdKey(self::SESSION_WORD));
455-
return time() < $sessionData['expires'] ? $sessionData['data'] : null;
463+
return $this->dateModel->gmtTimestamp() < $sessionData['expires'] ? $sessionData['data'] : null;
456464
}
457465

458466
/**
@@ -465,7 +473,7 @@ protected function _setWord($word)
465473
{
466474
$this->_session->setData(
467475
$this->_getFormIdKey(self::SESSION_WORD),
468-
['data' => $word, 'expires' => time() + $this->getTimeout()]
476+
['data' => $word, 'expires' => $this->dateModel->gmtTimestamp() + $this->getTimeout()]
469477
);
470478
$this->_word = $word;
471479
return $this;

‎app/code/Magento/Captcha/Test/Unit/Model/DefaultTest.php

Lines changed: 33 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@
88
class DefaultTest extends \PHPUnit_Framework_TestCase
99
{
1010
/**
11-
* Expiration frame
11+
* Expiration date
1212
*/
13-
const EXPIRE_FRAME = 86400;
13+
const EXPIRATION_TIMESTAMP = 86400;
1414

1515
/**
1616
* Captcha default config data
@@ -72,13 +72,18 @@ class DefaultTest extends \PHPUnit_Framework_TestCase
7272
/**
7373
* @var \PHPUnit_Framework_MockObject_MockObject
7474
*/
75-
protected $_session;
75+
protected $session;
7676

7777
/**
7878
* @var \PHPUnit_Framework_MockObject_MockObject
7979
*/
8080
protected $_resLogFactory;
8181

82+
/**
83+
* @var \Magento\Framework\Stdlib\DateTime\DateTime|\PHPUnit_Framework_MockObject_MockObject
84+
*/
85+
protected $dateModel;
86+
8287
/**
8388
* Sets up the fixture, for example, opens a network connection.
8489
* This method is called before a test is executed.
@@ -132,11 +137,17 @@ protected function setUp()
132137
$this->returnValue($this->_getResourceModelStub())
133138
);
134139

135-
$this->_object = new \Magento\Captcha\Model\DefaultModel(
136-
$this->session,
137-
$this->_getHelperStub(),
138-
$this->_resLogFactory,
139-
'user_create'
140+
$this->dateModel = $this->getMock('Magento\Framework\Stdlib\DateTime\DateTime', [], [], '', false);
141+
142+
$this->_object = (new \Magento\Framework\TestFramework\Unit\Helper\ObjectManager($this))->getObject(
143+
'Magento\Captcha\Model\DefaultModel',
144+
[
145+
'session' => $this->session,
146+
'captchaData' => $this->_getHelperStub(),
147+
'resLogFactory' => $this->_resLogFactory,
148+
'formId' => 'user_create',
149+
'dateModel' => $this->dateModel
150+
]
140151
);
141152
}
142153

@@ -191,7 +202,8 @@ public function testIsCorrect()
191202
{
192203
self::$_defaultConfig['case_sensitive'] = '1';
193204
$this->assertFalse($this->_object->isCorrect('abcdef5'));
194-
$sessionData = ['user_create_word' => ['data' => 'AbCdEf5', 'expires' => time() + self::EXPIRE_FRAME]];
205+
$sessionData = ['user_create_word' => ['data' => 'AbCdEf5', 'expires' => self::EXPIRATION_TIMESTAMP]];
206+
$this->dateModel->expects($this->once())->method('gmtTimestamp')->willReturn(self::EXPIRATION_TIMESTAMP - 1);
195207
$this->_object->getSession()->setData($sessionData);
196208
self::$_defaultConfig['case_sensitive'] = '0';
197209
$this->assertTrue($this->_object->isCorrect('abcdef5'));
@@ -213,16 +225,8 @@ public function testGetImgSrc()
213225
*/
214226
public function testLogAttempt()
215227
{
216-
$captcha = new \Magento\Captcha\Model\DefaultModel(
217-
$this->session,
218-
$this->_getHelperStub(),
219-
$this->_resLogFactory,
220-
'user_create'
221-
);
222-
223-
$captcha->logAttempt('admin');
224-
225-
$this->assertEquals($captcha->getSession()->getData('user_create_show_captcha'), 1);
228+
$this->_object->logAttempt('admin');
229+
$this->assertEquals($this->_object->getSession()->getData('user_create_show_captcha'), 1);
226230
}
227231

228232
/**
@@ -231,9 +235,7 @@ public function testLogAttempt()
231235
public function testGetWord()
232236
{
233237
$this->assertEquals($this->_object->getWord(), 'AbCdEf5');
234-
$this->_object->getSession()->setData(
235-
['user_create_word' => ['data' => 'AbCdEf5', 'expires' => time() - 360]]
236-
);
238+
$this->dateModel->expects($this->once())->method('gmtTimestamp')->willReturn(self::EXPIRATION_TIMESTAMP + 1);
237239
$this->assertNull($this->_object->getWord());
238240
}
239241

@@ -256,7 +258,7 @@ protected function _getSessionStub()
256258
);
257259
$session->expects($this->any())->method('isLoggedIn')->will($this->returnValue(false));
258260

259-
$session->setData(['user_create_word' => ['data' => 'AbCdEf5', 'expires' => time() + self::EXPIRE_FRAME]]);
261+
$session->setData(['user_create_word' => ['data' => 'AbCdEf5', 'expires' => self::EXPIRATION_TIMESTAMP]]);
260262
return $session;
261263
}
262264

@@ -355,11 +357,14 @@ protected function _getStoreStub()
355357
*/
356358
public function testIsShownToLoggedInUser($expectedResult, $formId)
357359
{
358-
$captcha = new \Magento\Captcha\Model\DefaultModel(
359-
$this->session,
360-
$this->_getHelperStub(),
361-
$this->_resLogFactory,
362-
$formId
360+
$captcha = (new \Magento\Framework\TestFramework\Unit\Helper\ObjectManager($this))->getObject(
361+
'Magento\Captcha\Model\DefaultModel',
362+
[
363+
'session' => $this->session,
364+
'captchaData' => $this->_getHelperStub(),
365+
'resLogFactory' => $this->_resLogFactory,
366+
'formId' => $formId
367+
]
363368
);
364369
$this->assertEquals($expectedResult, $captcha->isShownToLoggedInUser());
365370
}

‎lib/internal/Magento/Framework/App/Test/Unit/View/Deployment/VersionTest.php

Lines changed: 24 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,11 @@
1111

1212
class VersionTest extends \PHPUnit_Framework_TestCase
1313
{
14+
/**
15+
* Current timestamp for test
16+
*/
17+
const CURRENT_TIMESTAMP = 360;
18+
1419
/**
1520
* @var Version
1621
*/
@@ -26,21 +31,35 @@ class VersionTest extends \PHPUnit_Framework_TestCase
2631
*/
2732
private $versionStorage;
2833

34+
/**
35+
* @var \Magento\Framework\Stdlib\DateTime\DateTime|\PHPUnit_Framework_MockObject_MockObject
36+
*/
37+
protected $dateModel;
38+
2939
protected function setUp()
3040
{
3141
$this->appState = $this->getMock('Magento\Framework\App\State', [], [], '', false);
3242
$this->versionStorage = $this->getMock('Magento\Framework\App\View\Deployment\Version\StorageInterface');
33-
$this->object = new Version($this->appState, $this->versionStorage);
43+
$this->dateModel = $this->getMock('Magento\Framework\Stdlib\DateTime\DateTime', [], [], '', false);
44+
$this->object = (new \Magento\Framework\TestFramework\Unit\Helper\ObjectManager($this))->getObject(
45+
'Magento\Framework\App\View\Deployment\Version',
46+
[
47+
'appState' => $this->appState,
48+
'versionStorage' => $this->versionStorage,
49+
'dateModel' => $this->dateModel
50+
]
51+
);
3452
}
3553

3654
public function testGetValueDeveloperMode()
3755
{
56+
$this->dateModel->expects($this->once())->method('gmtTimestamp')->willReturn(self::CURRENT_TIMESTAMP);
3857
$this->appState
3958
->expects($this->once())
4059
->method('getMode')
4160
->will($this->returnValue(\Magento\Framework\App\State::MODE_DEVELOPER));
4261
$this->versionStorage->expects($this->never())->method($this->anything());
43-
$this->assertInternalType('integer', $this->object->getValue());
62+
$this->assertEquals(self::CURRENT_TIMESTAMP, $this->object->getValue());
4463
$this->object->getValue(); // Ensure computation occurs only once and result is cached in memory
4564
}
4665

@@ -80,8 +99,9 @@ public function testGetValueDefaultModeSaving()
8099
->expects($this->once())
81100
->method('load')
82101
->will($this->throwException($storageException));
83-
$this->versionStorage->expects($this->once())->method('save')->with($this->equalTo(time(), 5));
84-
$this->assertEquals(time(), $this->object->getValue());
102+
$this->dateModel->expects($this->once())->method('gmtTimestamp')->willReturn(self::CURRENT_TIMESTAMP);
103+
$this->versionStorage->expects($this->once())->method('save')->with(self::CURRENT_TIMESTAMP);
104+
$this->assertEquals(self::CURRENT_TIMESTAMP, $this->object->getValue());
85105
$this->object->getValue(); // Ensure caching in memory
86106
}
87107
}

‎lib/internal/Magento/Framework/App/View/Deployment/Version.php

100644100755
Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,16 +26,24 @@ class Version
2626
*/
2727
private $cachedValue;
2828

29+
/**
30+
* @var \Magento\Framework\Stdlib\DateTime\DateTime
31+
*/
32+
protected $dateModel;
33+
2934
/**
3035
* @param \Magento\Framework\App\State $appState
3136
* @param Version\StorageInterface $versionStorage
37+
* @param \Magento\Framework\Stdlib\DateTime\DateTime $dateModel
3238
*/
3339
public function __construct(
3440
\Magento\Framework\App\State $appState,
35-
\Magento\Framework\App\View\Deployment\Version\StorageInterface $versionStorage
41+
\Magento\Framework\App\View\Deployment\Version\StorageInterface $versionStorage,
42+
\Magento\Framework\Stdlib\DateTime\DateTime $dateModel
3643
) {
3744
$this->appState = $appState;
3845
$this->versionStorage = $versionStorage;
46+
$this->dateModel = $dateModel;
3947
}
4048

4149
/**
@@ -64,13 +72,13 @@ protected function readValue($appMode)
6472
try {
6573
$result = $this->versionStorage->load();
6674
} catch (\UnexpectedValueException $e) {
67-
$result = (new \DateTime())->getTimestamp();
75+
$result = $this->dateModel->gmtTimestamp();
6876
$this->versionStorage->save($result);
6977
}
7078
break;
7179

7280
case \Magento\Framework\App\State::MODE_DEVELOPER:
73-
$result = (new \DateTime())->getTimestamp();
81+
$result = $this->dateModel->gmtTimestamp();
7482
break;
7583

7684
default:

0 commit comments

Comments
 (0)