ACP2E-3190: [Cloud] Products graphql having error when same simple product has assigned to multiple configurable products

- Initial Commit

Author: arnobsh

app/code/Magento/ConfigurableProductGraphQl/Model/ResourceModel/Product/Type/GetChildrenIdsByParentId.php

@@ -7,15 +7,13 @@
 
 namespace Magento\ConfigurableProductGraphQl\Model\Variant;
 
+use Exception;
 use Magento\Catalog\Api\Data\ProductInterface;
 use Magento\Catalog\Model\Product;
-use Magento\ConfigurableProductGraphQl\Model\ResourceModel\Product\Type\GetChildrenIdsByParentId;
 use Magento\Catalog\Model\ResourceModel\Product\Collection as ChildCollection;
 use Magento\Catalog\Model\ResourceModel\Product\CollectionFactory;
-use Magento\Framework\App\ObjectManager;
 use Magento\Framework\EntityManager\MetadataPool;
 use Magento\Framework\Api\SearchCriteriaBuilder;
-use Magento\Framework\Exception\LocalizedException;
 use Magento\Framework\ObjectManager\ResetAfterRequestInterface;
 use Magento\GraphQl\Model\Query\ContextInterface;
 use Magento\CatalogGraphQl\Model\Resolver\Products\DataProvider\Product\CollectionProcessorInterface;
@@ -24,7 +22,6 @@
 
 /**
  * Collection for fetching configurable child product data.
- * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class Collection implements ResetAfterRequestInterface
 {
@@ -68,42 +65,33 @@ class Collection implements ResetAfterRequestInterface
      */
     private $collectionPostProcessor;
 
-    /**
-     * @var GetChildrenIdsByParentId
-     */
-    private $getChildrenIdsByParentId;
-
     /**
      * @param CollectionFactory $childCollectionFactory
      * @param SearchCriteriaBuilder $searchCriteriaBuilder
      * @param MetadataPool $metadataPool
      * @param CollectionProcessorInterface $collectionProcessor
      * @param CollectionPostProcessor $collectionPostProcessor
-     * @param GetChildrenIdsByParentId|null $getChildrenIdsByParentId
      */
     public function __construct(
         CollectionFactory $childCollectionFactory,
         SearchCriteriaBuilder $searchCriteriaBuilder,
         MetadataPool $metadataPool,
         CollectionProcessorInterface $collectionProcessor,
-        CollectionPostProcessor $collectionPostProcessor,
-        ?GetChildrenIdsByParentId $getChildrenIdsByParentId = null
+        CollectionPostProcessor $collectionPostProcessor
     ) {
         $this->childCollectionFactory = $childCollectionFactory;
         $this->searchCriteriaBuilder = $searchCriteriaBuilder;
         $this->metadataPool = $metadataPool;
         $this->collectionProcessor = $collectionProcessor;
         $this->collectionPostProcessor = $collectionPostProcessor;
-        $this->getChildrenIdsByParentId = $getChildrenIdsByParentId
-            ?: ObjectManager::getInstance()->get(GetChildrenIdsByParentId::class);
     }
 
     /**
      * Add parent to collection filter
      *
      * @param Product $product
      * @return void
-     * @throws \Exception
+     * @throws Exception
      */
     public function addParentProduct(Product $product) : void
     {
@@ -138,7 +126,7 @@ public function addEavAttributes(array $attributeCodes) : void
      * @param ContextInterface $context
      * @param array $attributeCodes
      * @return array
-     * @throws LocalizedException
+     * @throws Exception
      */
     public function getChildProductsByParentId(int $id, ContextInterface $context, array $attributeCodes) : array
     {
@@ -157,7 +145,7 @@ public function getChildProductsByParentId(int $id, ContextInterface $context, a
      * @param ContextInterface $context
      * @param array $attributeCodes
      * @return array
-     * @throws LocalizedException
+     * @throws Exception
      */
     private function fetch(ContextInterface $context, array $attributeCodes) : array
     {
@@ -167,9 +155,18 @@ private function fetch(ContextInterface $context, array $attributeCodes) : array
 
         /** @var ChildCollection $childCollection */
         $childCollection = $this->childCollectionFactory->create();
-        $childrenIdsByParent = $this->getChildrenIdsByParentId->execute(array_keys($this->parentProducts));
+        $linkField = $this->metadataPool->getMetadata(ProductInterface::class)->getLinkField();
         $childCollection->addWebsiteFilter($context->getExtensionAttributes()->getStore()->getWebsiteId());
-        $childCollection->addIdFilter(array_keys($childrenIdsByParent));
+        $childCollection->getSelect()
+            ->columns(
+                ['parent_id' => new \Zend_Db_Expr('GROUP_CONCAT(`link_table`.parent_id)')]
+            )
+            ->join(
+                ['link_table' => $childCollection->getTable('catalog_product_super_link')],
+                'link_table.product_id = e.entity_id',
+                []
+            )
+            ->group('e.' . $linkField);
         $attributeCodes = array_unique(array_merge($this->attributeCodes, $attributeCodes));
 
         $this->collectionProcessor->process(
@@ -186,7 +183,9 @@ private function fetch(ContextInterface $context, array $attributeCodes) : array
                 continue;
             }
             $formattedChild = ['model' => $childProduct, 'sku' => $childProduct->getSku()];
-            foreach ($childrenIdsByParent[$childProduct->getId()] as $parentId) {
+
+            $parentIds = preg_split ("/\,/", (string) $childProduct->getParentId());
+            foreach ($parentIds as $parentId) {
                 if (!isset($this->childrenMap[$parentId])) {
                     $this->childrenMap[$parentId] = [];
                 }

app/code/Magento/ConfigurableProductGraphQl/Model/Variant/Collection.php

@@ -1,18 +1,7 @@
 <?php
-/************************************************************************
- *
+/**
  * Copyright 2024 Adobe
  * All Rights Reserved.
- *
- * NOTICE: All information contained herein is, and remains
- * the property of Adobe and its suppliers, if any. The intellectual
- * and technical concepts contained herein are proprietary to Adobe
- * and its suppliers and are protected by all applicable intellectual
- * property laws, including trade secret and copyright laws.
- * Dissemination of this information or reproduction of this material
- * is strictly forbidden unless prior written permission is obtained
- * from Adobe.
- * ************************************************************************
  */
 declare(strict_types=1);
 
@@ -81,6 +70,11 @@ public function testMultipleConfigurableProductCanHaveSameSimpleProduct()
 
         self::assertArrayNotHasKey('errors', $result);
         self::assertNotEmpty($result['products']);
+        self::assertCount(2, $result['products']['items']);
+        self::assertNotEmpty($result['products']['items'][0]['variants'][0]);
+        self::assertCount(2, $result['products']['items'][0]['variants'][0]);
+        self::assertNotEmpty($result['products']['items'][1]['variants'][0]);
+        self::assertCount(2, $result['products']['items'][1]['variants'][0]);
     }
 
     /**