MAGETWO-56743: Unable to upgrade with split databases

Stanislav Idolov · Stanislav Idolov · commit 8f21503fbb3a · 2016-08-12T10:42:51.000+03:00
-- CR fixes
diff --git a/app/code/Magento/Paypal/Setup/InstallSchema.php b/app/code/Magento/Paypal/Setup/InstallSchema.php
@@ -142,7 +142,6 @@ public function install(SchemaSetupInterface $setup, ModuleContextInterface $con
             'agreement_id',
             \Magento\Framework\DB\Ddl\Table::ACTION_CASCADE
         )->addForeignKey(
-            // TODO: refactor without FK.
             $installer->getFkName('paypal_billing_agreement_order', 'order_id', 'sales_order', 'entity_id'),
             'order_id',
             $installer->getTable('sales_order'),
diff --git a/app/code/Magento/Vault/Setup/InstallSchema.php b/app/code/Magento/Vault/Setup/InstallSchema.php
@@ -145,7 +145,6 @@ public function install(SchemaSetupInterface $setup, ModuleContextInterface $con
                 ['unsigned' => true, 'nullable' => false, 'primary' => true],
                 'Payment token Id'
             )->addForeignKey(
-                // TODO: refactor without FK.
                 $setup->getFkName(
                     $setup->getTable(self::ORDER_PAYMENT_TO_PAYMENT_TOKEN_TABLE),
                     'order_payment_id',
diff --git a/lib/internal/Magento/Framework/Module/Setup.php b/lib/internal/Magento/Framework/Module/Setup.php
@@ -74,6 +74,8 @@ public function getConnection($connectionName = null)
     }
 
     /**
+     * Returns default setup connection instance
+     *
      * @return \Magento\Framework\DB\Adapter\AdapterInterface
      */
     private function getDefaultConnection()

Original file line number	Diff line number	Diff line change
`@@ -74,6 +74,8 @@ public function getConnection($connectionName = null)`
`74`	`74`	`}`
`75`	`75`
`76`	`76`	`/**`
	`77`	`+ * Returns default setup connection instance`
	`78`	`+ *`
`77`	`79`	`* @return \Magento\Framework\DB\Adapter\AdapterInterface`
`78`	`80`	`*/`
`79`	`81`	`private function getDefaultConnection()`