Skip to content

Commit 8f08efe

Browse files
Add aria-atomic to messages appearing on storefront
1 parent a95a465 commit 8f08efe

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

app/code/Magento/Theme/view/frontend/templates/messages.phtml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
?>
77
<div data-bind="scope: 'messages'">
88
<!-- ko if: cookieMessages && cookieMessages.length > 0 -->
9-
<div role="alert" data-bind="foreach: { data: cookieMessages, as: 'message' }" class="messages">
9+
<div aria-atomic="true" role="alert" data-bind="foreach: { data: cookieMessages, as: 'message' }" class="messages">
1010
<div data-bind="attr: {
1111
class: 'message-' + message.type + ' ' + message.type + ' message',
1212
'data-ui-id': 'message-' + message.type
@@ -16,7 +16,7 @@
1616
</div>
1717
<!-- /ko -->
1818
<!-- ko if: messages().messages && messages().messages.length > 0 -->
19-
<div role="alert" data-bind="foreach: { data: messages().messages, as: 'message' }" class="messages">
19+
<div aria-atomic="true" role="alert" data-bind="foreach: { data: messages().messages, as: 'message' }" class="messages">
2020
<div data-bind="attr: {
2121
class: 'message-' + message.type + ' ' + message.type + ' message',
2222
'data-ui-id': 'message-' + message.type

app/code/Magento/Ui/view/frontend/web/template/messages.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,12 @@
66
-->
77
<div data-role="checkout-messages" class="messages" data-bind="visible: isVisible(), click: removeAll">
88
<!-- ko foreach: messageContainer.getErrorMessages() -->
9-
<div role="alert" class="message message-error error">
9+
<div aria-atomic="true" role="alert" class="message message-error error">
1010
<div data-ui-id="checkout-cart-validationmessages-message-error" data-bind="text: $data"></div>
1111
</div>
1212
<!--/ko-->
1313
<!-- ko foreach: messageContainer.getSuccessMessages() -->
14-
<div role="alert" class="message message-success success">
14+
<div aria-atomic="true" role="alert" class="message message-success success">
1515
<div data-ui-id="checkout-cart-validationmessages-message-success" data-bind="text: $data"></div>
1616
</div>
1717
<!--/ko-->

0 commit comments

Comments
 (0)