🔃 [EngCom] Public Pull Requests - 2.3-develop

Accepted Public Pull Requests:
 - #13189: Fix a misspelled parameter name in TaxTest (by @akiojalehto)
 - #13223: [2.3-develop] Fix missing discount label in checkout (by @ihor-sviziev)
 - #13138: [2.3-develop] Remove not used count() from templates + Fix issue with continue in templates 2.3 (by @ihor-sviziev)
 - #12992: [2.3.x] Fix undeclared dependency magento/zendframework1 by magento/framework (by @ihor-sviziev)
 - #13097: Fixed typo in event name (by @dverkade)
 - magento-engcom/magento2ce#1194: Integration Test Annotation magentoAppArea breaks with some valid values[forwardport]. (by @nmalevanec)


Fixed GitHub Issues:
 - #11428: Cart Price Rule Label is not working (reported by @sasilinux) has been fixed in #13223 by @ihor-sviziev in 2.3-develop branch
   Related commits:
     1. 1721ff1
     2. 90d508b
     3. 968d7af

 - #11497: Discount Rule does not show Default Rule Label (reported by @pmoreno1980) has been fixed in #13223 by @ihor-sviziev in 2.3-develop branch
   Related commits:
     1. 1721ff1
     2. 90d508b
     3. 968d7af

 - #12967: Undeclared dependency magento/zendframework1 by magento/framework (reported by @linden2015) has been fixed in #12992 by @ihor-sviziev in 2.3-develop branch
   Related commits:
     1. 326d1a0

 - #2907: Integration Test Annotation magentoAppArea breaks with some valid values (reported by @Vinai) has been fixed in magento-engcom/magento2ce#1194 by @nmalevanec in 2.3-develop branch
   Related commits:
     1. d7f13d0

Author: magento-team

app/code/Magento/Backend/Test/Unit/Model/Menu/ConfigTest.php

@@ -96,7 +96,7 @@ public function testGetMenuWithCachedObjectReturnsUnserializedObject()
         $this->assertEquals($this->menuMock, $this->model->getMenu());
     }
 
-    public function testGetMenuWithNotCachedObjectBuidlsObject()
+    public function testGetMenuWithNotCachedObjectBuildsObject()
     {
         $this->cacheInstanceMock->expects(
             $this->at(0)

app/code/Magento/Braintree/Test/Unit/Gateway/Config/CanVoidHandlerTest.php

@@ -39,7 +39,7 @@ public function testHandleNotOrderPayment()
         static::assertFalse($voidHandler->handle($subject));
     }
 
-    public function testHandleSomeAmoutWasPaid()
+    public function testHandleSomeAmountWasPaid()
     {
         $paymentDO = $this->createMock(PaymentDataObjectInterface::class);
         $subject = [

app/code/Magento/Braintree/Test/Unit/Model/Report/TransactionsCollectionTest.php

@@ -125,15 +125,15 @@ public function testGetItemsEmptyCollection()
      */
     public function testGetItemsWithLimit()
     {
-        $transations = range(1, TransactionsCollection::TRANSACTION_MAXIMUM_COUNT + 10);
+        $transactions = range(1, TransactionsCollection::TRANSACTION_MAXIMUM_COUNT + 10);
 
         $this->filterMapperMock->expects($this->once())
             ->method('getFilter')
             ->willReturn(new BraintreeSearchNodeStub());
 
         $this->braintreeAdapterMock->expects($this->once())
             ->method('search')
-            ->willReturn($transations);
+            ->willReturn($transactions);
 
         $this->entityFactoryMock->expects($this->exactly(TransactionsCollection::TRANSACTION_MAXIMUM_COUNT))
             ->method('create')
@@ -157,15 +157,15 @@ public function testGetItemsWithLimit()
      */
     public function testGetItemsWithNullLimit()
     {
-        $transations = range(1, TransactionsCollection::TRANSACTION_MAXIMUM_COUNT + 10);
+        $transactions = range(1, TransactionsCollection::TRANSACTION_MAXIMUM_COUNT + 10);
 
         $this->filterMapperMock->expects($this->once())
             ->method('getFilter')
             ->willReturn(new BraintreeSearchNodeStub());
 
         $this->braintreeAdapterMock->expects($this->once())
             ->method('search')
-            ->willReturn($transations);
+            ->willReturn($transactions);
 
         $this->entityFactoryMock->expects($this->exactly(TransactionsCollection::TRANSACTION_MAXIMUM_COUNT))
             ->method('create')

app/code/Magento/Bundle/Test/Unit/Model/Product/TypeTest.php

@@ -1365,7 +1365,7 @@ public function testPrepareForCartAdvancedParentClassReturnString()
     /**
      * @return void
      */
-    public function testPrepareForCartAdvancedAllrequiredOption()
+    public function testPrepareForCartAdvancedAllRequiredOption()
     {
         /** @var \PHPUnit_Framework_MockObject_MockObject|DefaultType $group */
         $group = $this->getMockBuilder(\Magento\Catalog\Model\Product\Option\Type\DefaultType::class)

app/code/Magento/Bundle/view/frontend/templates/sales/order/creditmemo/items/renderer.phtml

@@ -12,7 +12,6 @@
 
 <?php $items = $block->getChildren($parentItem) ?>
 <?php $_order = $block->getItem()->getOrderItem()->getOrder() ?>
-<?php $_count = count($items) ?>
 <?php $_index = 0 ?>
 
 <?php $_prevOptionId = '' ?>

app/code/Magento/Bundle/view/frontend/templates/sales/order/invoice/items/renderer.phtml

@@ -12,7 +12,6 @@
 <?php $_order = $block->getItem()->getOrderItem()->getOrder() ?>
 
 <?php $items = $block->getChildren($parentItem) ?>
-<?php $_count = count($items) ?>
 <?php $_index = 0 ?>
 
 <?php $_prevOptionId = '' ?>

app/code/Magento/Bundle/view/frontend/templates/sales/order/items/renderer.phtml

@@ -10,7 +10,6 @@
 ?>
 <?php $parentItem = $block->getItem() ?>
 <?php $items = array_merge([$parentItem], $parentItem->getChildrenItems()); ?>
-<?php $_count = count($items) ?>
 <?php $_index = 0 ?>
 
 <?php $_prevOptionId = '' ?>

app/code/Magento/Bundle/view/frontend/templates/sales/order/shipment/items/renderer.phtml

@@ -12,7 +12,6 @@
 <?php $parentItem = $block->getItem() ?>
 <?php $items = array_merge([$parentItem->getOrderItem()], $parentItem->getOrderItem()->getChildrenItems()) ?>
 <?php $shipItems = $block->getChildren($parentItem) ?>
-<?php $_count = count($items) ?>
 <?php $_index = 0 ?>
 
 <?php $_prevOptionId = '' ?>

app/code/Magento/Catalog/Model/ResourceModel/Product/Link/DeleteHandler.php

@@ -72,8 +72,8 @@ public function execute($entityType, $entity)
         $linkedProduct = $this->productRepository->get($entity->getLinkedProductSku());
         $product = $this->productRepository->get($entity->getSku());
         $linkTypesToId = $this->linkTypeProvider->getLinkTypes();
-        $prodyctHydrator = $this->metadataPool->getHydrator(ProductInterface::class);
-        $productData = $prodyctHydrator->extract($product);
+        $productHydrator = $this->metadataPool->getHydrator(ProductInterface::class);
+        $productData = $productHydrator->extract($product);
         $linkId = $this->linkResource->getProductLinkId(
             $productData[$this->metadataPool->getMetadata(ProductInterface::class)->getLinkField()],
             $linkedProduct->getId(),

app/code/Magento/Catalog/Model/ResourceModel/Product/Link/SaveHandler.php

@@ -97,8 +97,8 @@ public function execute($entityType, $entity)
 
         try {
             $linkTypesToId = $this->linkTypeProvider->getLinkTypes();
-            $prodyctHydrator = $this->metadataPool->getHydrator(ProductInterface::class);
-            $productData = $prodyctHydrator->extract($product);
+            $productHydrator = $this->metadataPool->getHydrator(ProductInterface::class);
+            $productData = $productHydrator->extract($product);
             $this->linkResource->saveProductLinks(
                 $productData[$this->metadataPool->getMetadata(ProductInterface::class)->getLinkField()],
                 $links,