Merge remote-tracking branch 'origin/2.3.3-develop' into MC-17878

Author: svitja

app/code/Magento/Catalog/Model/ProductLink/Search.php

@@ -10,7 +10,9 @@
 
 use Magento\Catalog\Api\Data\ProductInterface;
 
-/** Returns collection of product visible in catalog by search key */
+/**
+ * Returns collection of product visible in catalog by search key
+ */
 class Search
 {
     /**
@@ -58,7 +60,6 @@ public function prepareCollection(
     ): \Magento\Catalog\Model\ResourceModel\Product\Collection {
         $productCollection = $this->productCollectionFactory->create();
         $productCollection->addAttributeToSelect(ProductInterface::NAME);
-        $productCollection->setVisibility($this->catalogVisibility->getVisibleInCatalogIds());
         $productCollection->setPage($pageNum, $limit);
         $this->filter->addFilter($productCollection, 'fulltext', ['fulltext' => $searchKey]);
         $productCollection->setPage($pageNum, $limit);

app/code/Magento/Ui/view/base/web/js/grid/editing/record.js

@@ -134,11 +134,6 @@ define([
 
             field = utils.extend({}, fields.base, field);
 
-            field.__disableTmpl = {
-                label: true,
-                options: true
-            };
-
             return utils.template(field, {
                 record: this,
                 column: column

dev/tests/integration/testsuite/Magento/Catalog/Controller/Adminhtml/Product/SearchTest.php

@@ -38,7 +38,8 @@ public function testExecuteNonExistingSearchKey() : void
             ->setPostValue('limit', 50);
         $this->dispatch('backend/catalog/product/search');
         $responseBody = $this->getResponse()->getBody();
-        $this->assertContains('{"options":[],"total":0}', $responseBody);
+        $jsonResponse = json_decode($responseBody, true);
+        $this->assertEmpty($jsonResponse['options']);
     }
 
     /**
@@ -57,6 +58,24 @@ public function testExecuteNotVisibleIndividuallyProducts() : void
             ->setPostValue('limit', 50);
         $this->dispatch('backend/catalog/product/search');
         $responseBody = $this->getResponse()->getBody();
-        $this->assertContains('{"options":[],"total":0}', $responseBody);
+        $jsonResponse = json_decode($responseBody, true);
+        $this->assertEquals(1, $jsonResponse['total']);
+        $this->assertCount(1, $jsonResponse['options']);
+    }
+
+    /**
+     * @magentoDataFixture Magento/Catalog/_files/multiple_mixed_products.php
+     */
+    public function testExecuteEnabledAndDisabledProducts() : void
+    {
+        $this->getRequest()
+            ->setPostValue('searchKey', 'simple')
+            ->setPostValue('page', 1)
+            ->setPostValue('limit', 50);
+        $this->dispatch('backend/catalog/product/search');
+        $responseBody = $this->getResponse()->getBody();
+        $jsonResponse = json_decode($responseBody, true);
+        $this->assertEquals(7, $jsonResponse['total']);
+        $this->assertCount(7, $jsonResponse['options']);
     }
 }

lib/web/mage/utils/template.js

@@ -40,7 +40,7 @@ define([
      * To limit recursion for a specific property add __disableTmpl: {propertyName: numberOfCycles}.
      *
      * @param {String} tmpl
-     * @param {Object} target
+     * @param {Object | undefined} target
      * @returns {Boolean|Object}
      */
     function isTmplIgnored(tmpl, target) {
@@ -136,7 +136,9 @@ define([
             cycles = 0;
 
         while (~tmpl.indexOf(opener) && (typeof maxCycles === 'undefined' || cycles < maxCycles)) {
-            tmpl = template(tmpl, data);
+            if (!isTmplIgnored(tmpl)) {
+                tmpl = template(tmpl, data);
+            }
 
             if (tmpl === last) {
                 break;