Skip to content

Commit 8e37f84

Browse files
author
Andrii Kasian
committed
Merge remote-tracking branch 'mainline/develop' into S67
# Conflicts: # app/code/Magento/Search/Controller/Adminhtml/Term/Save.php # app/code/Magento/Search/Test/Unit/Controller/Adminhtml/Term/MassDeleteTest.php
1 parent d5df25d commit 8e37f84

File tree

3 files changed

+8
-17
lines changed

3 files changed

+8
-17
lines changed

app/code/Magento/Search/Controller/Adminhtml/Term/Save.php

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,8 @@
66
namespace Magento\Search\Controller\Adminhtml\Term;
77

88
use Magento\Backend\App\Action\Context;
9-
use Magento\Framework\View\Result\PageFactory;
9+
use Magento\Framework\Controller\ResultFactory;
1010
use Magento\Search\Model\QueryFactory;
11-
1211
use Magento\Search\Controller\Adminhtml\Term as TermController;
1312
use Magento\Framework\Exception\LocalizedException;
1413

@@ -21,15 +20,13 @@ class Save extends TermController
2120

2221
/**
2322
* @param Context $context
24-
* @param PageFactory $resultPageFactory
2523
* @param QueryFactory $queryFactory
2624
*/
2725
public function __construct(
2826
Context $context,
29-
PageFactory $resultPageFactory,
3027
QueryFactory $queryFactory
3128
) {
32-
parent::__construct($context, $resultPageFactory);
29+
parent::__construct($context);
3330
$this->queryFactory = $queryFactory;
3431
}
3532

@@ -102,8 +99,8 @@ private function loadQuery()
10299
private function proceedToEdit($data)
103100
{
104101
$this->_getSession()->setPageData($data);
105-
/** @var \Magento\Backend\Model\View\Result\Redirect $redirectResult */
106-
$redirectResult = $this->resultRedirectFactory->create();
102+
/** @var \Magento\Backend\Model\View\Result\Redirect $resultRedirect */
103+
$redirectResult = $this->resultFactory->create(ResultFactory::TYPE_REDIRECT);
107104
return $redirectResult->setPath('search/*/edit', ['id' => $this->getRequest()->getPost('query_id', null)]);
108105
}
109106
}

app/code/Magento/Search/Test/Unit/Controller/Adminhtml/Term/MassDeleteTest.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,6 @@ class MassDeleteTest extends \PHPUnit_Framework_TestCase
3232
/** @var \Magento\Framework\App\RequestInterface|\PHPUnit_Framework_MockObject_MockObject */
3333
private $request;
3434

35-
/** @var \Magento\Backend\Model\View\Result\Redirect|\PHPUnit_Framework_MockObject_MockObject */
36-
private $redirect;
37-
3835
/**
3936
* @var \Magento\Framework\Controller\ResultFactory|\PHPUnit_Framework_MockObject_MockObject
4037
*/

app/code/Magento/Search/Test/Unit/Controller/Adminhtml/Term/SaveTest.php

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ protected function setUp()
4343
->setMethods(['setPath'])
4444
->disableOriginalConstructor()
4545
->getMock();
46-
$redirectFactory = $this->getMockBuilder('Magento\Backend\Model\View\Result\RedirectFactory')
46+
$redirectFactory = $this->getMockBuilder('\Magento\Framework\Controller\ResultFactory')
4747
->setMethods(['create'])
4848
->disableOriginalConstructor()
4949
->getMock();
@@ -53,6 +53,9 @@ protected function setUp()
5353
$this->context->expects($this->any())
5454
->method('getResultRedirectFactory')
5555
->willReturn($redirectFactory);
56+
$this->context->expects($this->any())
57+
->method('getResultFactory')
58+
->willReturn($redirectFactory);
5659

5760
$this->request = $this->getMockBuilder('\Magento\Framework\App\RequestInterface')
5861
->disableOriginalConstructor()
@@ -86,11 +89,6 @@ protected function setUp()
8689
->method('getSession')
8790
->willReturn($this->session);
8891

89-
$pageFactory = $this->getMockBuilder('Magento\Framework\View\Result\PageFactory')
90-
->setMethods([])
91-
->disableOriginalConstructor()
92-
->getMock();
93-
9492
$this->query = $this->getMockBuilder('Magento\Search\Model\Query')
9593
->disableOriginalConstructor()
9694
->setMethods(['getId', 'load', 'addData', 'setIsProcessed', 'save', 'loadByQueryText', 'setStoreId'])
@@ -107,7 +105,6 @@ protected function setUp()
107105
'Magento\Search\Controller\Adminhtml\Term\Save',
108106
[
109107
'context' => $this->context,
110-
'resultPageFactory' => $pageFactory,
111108
'queryFactory' => $queryFactory,
112109
]
113110
);

0 commit comments

Comments
 (0)