MAGETWO-88504: Tiered pricing and quantity Increments do not work with decimal inventory

Author: dhorytskyi

app/code/Magento/Bundle/Ui/DataProvider/Product/BundleDataProvider.php

@@ -8,8 +8,6 @@
 use Magento\Catalog\Model\ResourceModel\Product\CollectionFactory;
 use Magento\Catalog\Ui\DataProvider\Product\ProductDataProvider;
 use Magento\Bundle\Helper\Data;
-use Magento\CatalogInventory\Api\StockRegistryInterface;
-use Magento\Framework\Exception\NoSuchEntityException;
 
 class BundleDataProvider extends ProductDataProvider
 {
@@ -18,11 +16,6 @@ class BundleDataProvider extends ProductDataProvider
      */
     protected $dataHelper;
 
-    /**
-     * @var StockRegistryInterface
-     */
-    private $stockRegistry;
-
     /**
      * Construct
      *
@@ -35,7 +28,6 @@ class BundleDataProvider extends ProductDataProvider
      * @param \Magento\Ui\DataProvider\AddFilterToCollectionInterface[] $addFilterStrategies
      * @param array $meta
      * @param array $data
-     * @param StockRegistryInterface $stockRegistry
      */
     public function __construct(
         $name,
@@ -46,8 +38,7 @@ public function __construct(
         array $meta = [],
         array $data = [],
         array $addFieldStrategies = [],
-        array $addFilterStrategies = [],
-        StockRegistryInterface $stockRegistry = null
+        array $addFilterStrategies = []
     ) {
         parent::__construct(
             $name,
@@ -61,8 +52,6 @@ public function __construct(
         );
 
         $this->dataHelper = $dataHelper;
-        $this->stockRegistry = $stockRegistry
-            ?: \Magento\Framework\App\ObjectManager::getInstance()->get(StockRegistryInterface::class);
     }
 
     /**
@@ -85,29 +74,9 @@ public function getData()
         }
         $items = $this->getCollection()->toArray();
 
-        foreach ($items as $index => $item) {
-            $items[$index]['selection_qty_is_integer'] = !$this->isProductQtyDecimal($item['entity_id']);
-        }
-
         return [
             'totalRecords' => $this->getCollection()->getSize(),
             'items' => array_values($items),
         ];
     }
-
-    /**
-     * @param int $productId
-     * @return bool
-     */
-    private function isProductQtyDecimal(int $productId): bool
-    {
-        try {
-            $productStock = $this->stockRegistry->getStockItem($productId);
-            $result = $productStock->getIsQtyDecimal();
-        } catch (NoSuchEntityException $e) {
-            $result = false;
-        }
-
-        return $result;
-    }
 }

app/code/Magento/Bundle/Ui/DataProvider/Product/Form/Modifier/BundlePanel.php

@@ -377,7 +377,6 @@ protected function getBundleOptions()
                                                     'selection_price_type' => '',
                                                     'selection_price_value' => '',
                                                     'selection_qty' => '',
-                                                    'selection_qty_is_integer' => '',
                                                 ],
                                                 'links' => ['insertData' => '${ $.provider }:${ $.dataProvider }'],
                                                 'imports' => [
@@ -683,11 +682,10 @@ protected function getBundleSelections()
                                 'validation' => [
                                     'required-entry' => true,
                                     'validate-number' => true,
-                                    'validate-digits' => true,
                                     'validate-greater-than-zero' => true
                                 ],
                                 'imports' => [
-                                    'validateDigits' => '${ $.provider }:${ $.parentScope }.selection_qty_is_integer',
+                                    'isInteger' => '${ $.provider }:${ $.parentScope }.selection_qty_is_integer'
                                 ],
                             ],
                         ],

app/code/Magento/Bundle/view/adminhtml/web/js/components/bundle-option-qty.js

@@ -13,8 +13,7 @@ define([
             valueUpdate: 'input',
             isInteger: true,
             validation: {
-                'validate-number': true,
-                'validate-digits': true
+                'validate-number': true
             }
         },
 
@@ -33,16 +32,6 @@ define([
             var notEqual = this.value() !== this.initialValue.toString();
 
             return !this.visible() ? false : notEqual;
-        },
-
-        /**
-         * Update field validation rules
-         *
-         * @param value
-         */
-        validateDigits: function(value) {
-            this.isInteger = value;
-            this.validation['validate-digits'] = this.isInteger;
         }
 
     });