Skip to content

Commit 8e0d7ba

Browse files
committed
Fix return type in ResetAttemptForFrontendObserver and ResetAttemptForBackendObserver classes. code cleaning
1 parent ba8fae3 commit 8e0d7ba

File tree

2 files changed

+30
-13
lines changed

2 files changed

+30
-13
lines changed

app/code/Magento/Captcha/Observer/ResetAttemptForBackendObserver.php

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,31 +5,39 @@
55
*/
66
namespace Magento\Captcha\Observer;
77

8+
use Magento\Captcha\Model\ResourceModel\Log;
9+
use Magento\Captcha\Model\ResourceModel\LogFactory;
10+
use Magento\Framework\Event\Observer;
811
use Magento\Framework\Event\ObserverInterface;
12+
use Magento\Framework\Exception\LocalizedException;
913

14+
/**
15+
* Reset captcha attempts for Backend
16+
*/
1017
class ResetAttemptForBackendObserver implements ObserverInterface
1118
{
1219
/**
13-
* @var \Magento\Captcha\Model\ResourceModel\LogFactory
20+
* @var LogFactory
1421
*/
1522
public $resLogFactory;
1623

1724
/**
18-
* @param \Magento\Captcha\Model\ResourceModel\LogFactory $resLogFactory
25+
* @param LogFactory $resLogFactory
1926
*/
2027
public function __construct(
21-
\Magento\Captcha\Model\ResourceModel\LogFactory $resLogFactory
28+
LogFactory $resLogFactory
2229
) {
2330
$this->resLogFactory = $resLogFactory;
2431
}
2532

2633
/**
2734
* Reset Attempts For Backend
2835
*
29-
* @param \Magento\Framework\Event\Observer $observer
30-
* @return \Magento\Captcha\Observer\ResetAttemptForBackendObserver
36+
* @param Observer $observer
37+
* @return Log
38+
* @throws LocalizedException
3139
*/
32-
public function execute(\Magento\Framework\Event\Observer $observer)
40+
public function execute(Observer $observer)
3341
{
3442
return $this->resLogFactory->create()->deleteUserAttempts($observer->getUser()->getUsername());
3543
}

app/code/Magento/Captcha/Observer/ResetAttemptForFrontendObserver.php

Lines changed: 16 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,33 +5,42 @@
55
*/
66
namespace Magento\Captcha\Observer;
77

8+
use Magento\Captcha\Model\ResourceModel\Log;
9+
use Magento\Captcha\Model\ResourceModel\LogFactory;
10+
use Magento\Customer\Model\Customer;
11+
use Magento\Framework\Event\Observer;
812
use Magento\Framework\Event\ObserverInterface;
13+
use Magento\Framework\Exception\LocalizedException;
914

15+
/**
16+
* Reset captcha attempts for Frontend
17+
*/
1018
class ResetAttemptForFrontendObserver implements ObserverInterface
1119
{
1220
/**
13-
* @var \Magento\Captcha\Model\ResourceModel\LogFactory
21+
* @var LogFactory
1422
*/
1523
public $resLogFactory;
1624

1725
/**
18-
* @param \Magento\Captcha\Model\ResourceModel\LogFactory $resLogFactory
26+
* @param LogFactory $resLogFactory
1927
*/
2028
public function __construct(
21-
\Magento\Captcha\Model\ResourceModel\LogFactory $resLogFactory
29+
LogFactory $resLogFactory
2230
) {
2331
$this->resLogFactory = $resLogFactory;
2432
}
2533

2634
/**
2735
* Reset Attempts For Frontend
2836
*
29-
* @param \Magento\Framework\Event\Observer $observer
30-
* @return \Magento\Captcha\Observer\ResetAttemptForFrontendObserver
37+
* @param Observer $observer
38+
* @return Log
39+
* @throws LocalizedException
3140
*/
32-
public function execute(\Magento\Framework\Event\Observer $observer)
41+
public function execute(Observer $observer)
3342
{
34-
/** @var \Magento\Customer\Model\Customer $model */
43+
/** @var Customer $model */
3544
$model = $observer->getModel();
3645

3746
return $this->resLogFactory->create()->deleteUserAttempts($model->getEmail());

0 commit comments

Comments
 (0)